-
Notifications
You must be signed in to change notification settings - Fork 80
Bump spring to 3.4.10 #2387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump spring to 3.4.10 #2387
Conversation
Summary of ChangesHello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine dependency upgrade, specifically updating the Spring Boot framework to version Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the Spring Boot version from 3.3.13 to 3.4.10. This is a minor version update which can introduce new features, deprecations, and potential breaking changes. The changes in the pom.xml files are correct. However, I have a couple of suggestions for improving maintainability. First, it would be beneficial to use a Maven property for the Spring Boot version to ensure consistency across modules and simplify future updates. I've left specific comments on how this can be done. Second, for a dependency upgrade of this nature, it's good practice to include a summary of the changes from the release notes in the pull request description, especially highlighting any breaking changes and confirming that the application has been tested against them. This helps reviewers understand the impact of the change and the verification that was done.
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-dependencies</artifactId> | ||
| <version>3.3.13</version> | ||
| <version>3.4.10</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve maintainability, consider using a Maven property to manage the Spring Boot version. This would involve adding a <properties> section to this POM and defining the version there. For example:
<properties>
<spring-boot.version>3.4.10</spring-boot.version>
</properties>Then you can use it like this:
<version>${spring-boot.version}</version>Ideally, this property would be defined in a parent POM (like lighty-parent) to ensure consistency across all modules that inherit from it.
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-parent</artifactId> | ||
| <version>3.3.13</version> | ||
| <version>3.4.10</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better maintainability, it's a good practice to manage dependency versions using properties. You could define a property for the Spring Boot version in the existing <properties> section of this POM and use it here. This would centralize the version and make future updates easier. For example:
In <properties>:
<spring-boot.version>3.4.10</spring-boot.version>And here:
<version>${spring-boot.version}</version>This is especially helpful as the same version is being updated in other modules, and centralizing version management is a key principle of Maven.
bac2a7b to
07816a6
Compare
07816a6 to
a48197a
Compare
https://github.com/spring-projects/spring-boot/releases/tag/v3.4.10 JIRA: LIGHTY-349 Signed-off-by: tobias.pobocik <[email protected]>
a48197a to
fe38e91
Compare
|
Not suitable for stability branch. |
https://github.com/spring-projects/spring-boot/releases/tag/v3.4.10