Skip to content

Commit 1bfa446

Browse files
andrestejerina97andrestejerina97
committed
correction: change the test structure
1 parent be85376 commit 1bfa446

File tree

6 files changed

+159
-12
lines changed

6 files changed

+159
-12
lines changed

‎tests/OpenTelemetry/Formatters/SponsorAdFormatterTest.php‎

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ private function createMockSubject(): mixed
5050
return $mock;
5151
}
5252

53-
public function testCreationAuditMessage(): void
53+
public function testSubjectCreationAuditMessage(): void
5454
{
5555
$formatter = new SponsorAdAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_CREATION);
5656
$formatter->setContext(AuditContextBuilder::default()->build());
@@ -61,7 +61,22 @@ public function testCreationAuditMessage(): void
6161
$this->assertStringContainsString(self::AD_TEXT, $result);
6262
}
6363

64-
public function testDeletionAuditMessage(): void
64+
public function testSubjectUpdateAuditMessage(): void
65+
{
66+
$formatter = new SponsorAdAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_UPDATE);
67+
$formatter->setContext(AuditContextBuilder::default()->build());
68+
$changeSet = [
69+
'text' => ['Old Text', self::AD_TEXT],
70+
'order' => [2, self::AD_ORDER]
71+
];
72+
$result = $formatter->format($this->mockSubject, $changeSet);
73+
74+
$this->assertNotNull($result);
75+
$this->assertStringContainsString('updated', $result);
76+
$this->assertStringContainsString(self::AD_TEXT, $result);
77+
}
78+
79+
public function testSubjectDeletionAuditMessage(): void
6580
{
6681
$formatter = new SponsorAdAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_DELETION);
6782
$formatter->setContext(AuditContextBuilder::default()->build());
@@ -79,4 +94,14 @@ public function testFormatterReturnsNullForInvalidSubject(): void
7994

8095
$this->assertNull($result);
8196
}
97+
98+
public function testFormatterHandlesEmptyChangeSet(): void
99+
{
100+
$formatter = new SponsorAdAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_UPDATE);
101+
$formatter->setContext(AuditContextBuilder::default()->build());
102+
$result = $formatter->format($this->mockSubject, []);
103+
104+
$this->assertNotNull($result);
105+
$this->assertStringContainsString('updated', $result);
106+
}
82107
}

‎tests/OpenTelemetry/Formatters/SponsorBadgeScanExtraQuestionAnswerFormatterTest.php‎

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ private function createMockSubject(): mixed
4949
return $mock;
5050
}
5151

52-
public function testCreationAuditMessage(): void
52+
public function testSubjectCreationAuditMessage(): void
5353
{
5454
$formatter = new SponsorBadgeScanExtraQuestionAnswerAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_CREATION);
5555
$formatter->setContext(AuditContextBuilder::default()->build());
@@ -61,7 +61,21 @@ public function testCreationAuditMessage(): void
6161
$this->assertStringContainsString(self::ANSWER_VALUE, $result);
6262
}
6363

64-
public function testDeletionAuditMessage(): void
64+
public function testSubjectUpdateAuditMessage(): void
65+
{
66+
$formatter = new SponsorBadgeScanExtraQuestionAnswerAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_UPDATE);
67+
$formatter->setContext(AuditContextBuilder::default()->build());
68+
$changeSet = [
69+
'value' => ['Old Answer', self::ANSWER_VALUE]
70+
];
71+
$result = $formatter->format($this->mockSubject, $changeSet);
72+
73+
$this->assertNotNull($result);
74+
$this->assertStringContainsString('updated', $result);
75+
$this->assertStringContainsString(self::QUESTION_LABEL, $result);
76+
}
77+
78+
public function testSubjectDeletionAuditMessage(): void
6579
{
6680
$formatter = new SponsorBadgeScanExtraQuestionAnswerAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_DELETION);
6781
$formatter->setContext(AuditContextBuilder::default()->build());
@@ -79,4 +93,14 @@ public function testFormatterReturnsNullForInvalidSubject(): void
7993

8094
$this->assertNull($result);
8195
}
96+
97+
public function testFormatterHandlesEmptyChangeSet(): void
98+
{
99+
$formatter = new SponsorBadgeScanExtraQuestionAnswerAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_UPDATE);
100+
$formatter->setContext(AuditContextBuilder::default()->build());
101+
$result = $formatter->format($this->mockSubject, []);
102+
103+
$this->assertNotNull($result);
104+
$this->assertStringContainsString('updated', $result);
105+
}
82106
}

‎tests/OpenTelemetry/Formatters/SponsorBadgeScanFormatterTest.php‎

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ private function createMockSubject(): mixed
5454
return $mock;
5555
}
5656

57-
public function testCreationAuditMessage(): void
57+
public function testSubjectCreationAuditMessage(): void
5858
{
5959
$formatter = new SponsorBadgeScanAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_CREATION);
6060
$formatter->setContext(AuditContextBuilder::default()->build());
@@ -65,7 +65,21 @@ public function testCreationAuditMessage(): void
6565
$this->assertStringContainsString(self::USER_EMAIL, $result);
6666
}
6767

68-
public function testDeletionAuditMessage(): void
68+
public function testSubjectUpdateAuditMessage(): void
69+
{
70+
$formatter = new SponsorBadgeScanAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_UPDATE);
71+
$formatter->setContext(AuditContextBuilder::default()->build());
72+
$changeSet = [
73+
'qr_code' => ['QR999999', self::QR_CODE]
74+
];
75+
$result = $formatter->format($this->mockSubject, $changeSet);
76+
77+
$this->assertNotNull($result);
78+
$this->assertStringContainsString('updated', $result);
79+
$this->assertStringContainsString(self::USER_EMAIL, $result);
80+
}
81+
82+
public function testSubjectDeletionAuditMessage(): void
6983
{
7084
$formatter = new SponsorBadgeScanAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_DELETION);
7185
$formatter->setContext(AuditContextBuilder::default()->build());
@@ -83,4 +97,14 @@ public function testFormatterReturnsNullForInvalidSubject(): void
8397

8498
$this->assertNull($result);
8599
}
100+
101+
public function testFormatterHandlesEmptyChangeSet(): void
102+
{
103+
$formatter = new SponsorBadgeScanAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_UPDATE);
104+
$formatter->setContext(AuditContextBuilder::default()->build());
105+
$result = $formatter->format($this->mockSubject, []);
106+
107+
$this->assertNotNull($result);
108+
$this->assertStringContainsString('updated', $result);
109+
}
86110
}

‎tests/OpenTelemetry/Formatters/SponsorMaterialFormatterTest.php‎

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ private function createMockSubject(): mixed
5050
return $mock;
5151
}
5252

53-
public function testCreationAuditMessage(): void
53+
public function testSubjectCreationAuditMessage(): void
5454
{
5555
$formatter = new SponsorMaterialAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_CREATION);
5656
$formatter->setContext(AuditContextBuilder::default()->build());
@@ -62,7 +62,22 @@ public function testCreationAuditMessage(): void
6262
$this->assertStringContainsString(self::MATERIAL_TYPE, $result);
6363
}
6464

65-
public function testDeletionAuditMessage(): void
65+
public function testSubjectUpdateAuditMessage(): void
66+
{
67+
$formatter = new SponsorMaterialAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_UPDATE);
68+
$formatter->setContext(AuditContextBuilder::default()->build());
69+
$changeSet = [
70+
'name' => ['Old Report', self::MATERIAL_NAME],
71+
'order' => [1, self::MATERIAL_ORDER]
72+
];
73+
$result = $formatter->format($this->mockSubject, $changeSet);
74+
75+
$this->assertNotNull($result);
76+
$this->assertStringContainsString('updated', $result);
77+
$this->assertStringContainsString(self::MATERIAL_NAME, $result);
78+
}
79+
80+
public function testSubjectDeletionAuditMessage(): void
6681
{
6782
$formatter = new SponsorMaterialAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_DELETION);
6883
$formatter->setContext(AuditContextBuilder::default()->build());
@@ -80,4 +95,14 @@ public function testFormatterReturnsNullForInvalidSubject(): void
8095

8196
$this->assertNull($result);
8297
}
98+
99+
public function testFormatterHandlesEmptyChangeSet(): void
100+
{
101+
$formatter = new SponsorMaterialAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_UPDATE);
102+
$formatter->setContext(AuditContextBuilder::default()->build());
103+
$result = $formatter->format($this->mockSubject, []);
104+
105+
$this->assertNotNull($result);
106+
$this->assertStringContainsString('updated', $result);
107+
}
83108
}

‎tests/OpenTelemetry/Formatters/SponsorSocialNetworkFormatterTest.php‎

Lines changed: 27 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ private function createMockSubject(): mixed
4848
return $mock;
4949
}
5050

51-
public function testCreationAuditMessage(): void
51+
public function testSubjectCreationAuditMessage(): void
5252
{
5353
$formatter = new SponsorSocialNetworkAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_CREATION);
5454
$formatter->setContext(AuditContextBuilder::default()->build());
@@ -60,7 +60,22 @@ public function testCreationAuditMessage(): void
6060
$this->assertStringContainsString(self::ICON_CSS, $result);
6161
}
6262

63-
public function testDeletionAuditMessage(): void
63+
public function testSubjectUpdateAuditMessage(): void
64+
{
65+
$formatter = new SponsorSocialNetworkAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_UPDATE);
66+
$formatter->setContext(AuditContextBuilder::default()->build());
67+
$changeSet = [
68+
'link' => ['https://twitter.com/old', self::NETWORK_LINK],
69+
'icon_css' => ['fa-facebook', self::ICON_CSS]
70+
];
71+
$result = $formatter->format($this->mockSubject, $changeSet);
72+
73+
$this->assertNotNull($result);
74+
$this->assertStringContainsString('updated', $result);
75+
$this->assertStringContainsString(self::NETWORK_LINK, $result);
76+
}
77+
78+
public function testSubjectDeletionAuditMessage(): void
6479
{
6580
$formatter = new SponsorSocialNetworkAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_DELETION);
6681
$formatter->setContext(AuditContextBuilder::default()->build());
@@ -78,4 +93,14 @@ public function testFormatterReturnsNullForInvalidSubject(): void
7893

7994
$this->assertNull($result);
8095
}
96+
97+
public function testFormatterHandlesEmptyChangeSet(): void
98+
{
99+
$formatter = new SponsorSocialNetworkAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_UPDATE);
100+
$formatter->setContext(AuditContextBuilder::default()->build());
101+
$result = $formatter->format($this->mockSubject, []);
102+
103+
$this->assertNotNull($result);
104+
$this->assertStringContainsString('updated', $result);
105+
}
81106
}

‎tests/OpenTelemetry/Formatters/SponsorUserInfoGrantFormatterTest.php‎

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ private function createMockSubject(): mixed
4949
return $mock;
5050
}
5151

52-
public function testCreationAuditMessage(): void
52+
public function testSubjectCreationAuditMessage(): void
5353
{
5454
$formatter = new SponsorUserInfoGrantAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_CREATION);
5555
$formatter->setContext(AuditContextBuilder::default()->build());
@@ -60,7 +60,21 @@ public function testCreationAuditMessage(): void
6060
$this->assertStringContainsString(self::ALLOWED_USER_EMAIL, $result);
6161
}
6262

63-
public function testDeletionAuditMessage(): void
63+
public function testSubjectUpdateAuditMessage(): void
64+
{
65+
$formatter = new SponsorUserInfoGrantAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_UPDATE);
66+
$formatter->setContext(AuditContextBuilder::default()->build());
67+
$changeSet = [
68+
'allowed_user_id' => [101, 102]
69+
];
70+
$result = $formatter->format($this->mockSubject, $changeSet);
71+
72+
$this->assertNotNull($result);
73+
$this->assertStringContainsString('updated', $result);
74+
$this->assertStringContainsString(self::ALLOWED_USER_EMAIL, $result);
75+
}
76+
77+
public function testSubjectDeletionAuditMessage(): void
6478
{
6579
$formatter = new SponsorUserInfoGrantAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_DELETION);
6680
$formatter->setContext(AuditContextBuilder::default()->build());
@@ -78,4 +92,14 @@ public function testFormatterReturnsNullForInvalidSubject(): void
7892

7993
$this->assertNull($result);
8094
}
95+
96+
public function testFormatterHandlesEmptyChangeSet(): void
97+
{
98+
$formatter = new SponsorUserInfoGrantAuditLogFormatter(IAuditStrategy::EVENT_ENTITY_UPDATE);
99+
$formatter->setContext(AuditContextBuilder::default()->build());
100+
$result = $formatter->format($this->mockSubject, []);
101+
102+
$this->assertNotNull($result);
103+
$this->assertStringContainsString('updated', $result);
104+
}
81105
}

0 commit comments

Comments
 (0)