fix(refresh-token): add retry mechanism with back off to emit new AT (#199)

* fix(refresh-token): add retry mechanism with back off to emit new AT

* chore(ci): add jest run

* chore(ci): add build test

* fix(refresh-token): fix retry exhaustion bug, dropzone accept callback, and response.ok handling

* Fix retryWithBackoff exhaustion guard (attempt === maxRetries was dead
  code after loop bound change to < maxRetries; errors were silently
  swallowed, function returned undefined instead of throwing).
* Fix Dropzone accept callback to call done() on error path, preventing
  files from getting stuck in an indeterminate state.
* Use response.ok instead of checking individual status codes, closing
  a gap where 4xx codes other than 400 fell through unhandled.
* Add ok property to existing test mocks to match the new response.ok check.
* Export retryWithBackoff and add 5 unit tests covering retry count,
  auth error short-circuit, transient recovery, and exponential backoff.
* Add defensive check for missing access_token in refresh response.

* fix(refresh-token): The loop bound is now attempt < maxRetries

* consistent with the exhaustion guard attempt === maxRetries - 1.
With MAX_RETRIES = 5, the function makes exactly 5 attempts
(0 through 4), no dead code.

* fix(refresh-token): improved HTTP error handling

Author: smarcet

.github/workflows/build_test.yml

@@ -0,0 +1,15 @@
+name: build_test
+
+on: [push, pull_request]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 18
+      - run: yarn install
+      - run: yarn build

.github/workflows/jest.yml

@@ -0,0 +1,15 @@
+name: jest
+
+on: [push, pull_request]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 18
+      - run: yarn install
+      - run: yarn test

src/components/extra-questions/__test__/extra-questions.test.js

@@ -11,6 +11,9 @@ import {toSlug} from '../../../utils/methods';
 
 Enzyme.configure({adapter: new Adapter()});
 
+// jsdom does not implement scrollIntoView
+Element.prototype.scrollIntoView = jest.fn();
+
 const questions = [
     {
         "id": 93,

src/components/inputs/upload-input-v2/dropzone.js

@@ -4,6 +4,7 @@ import 'dropzone/dist/dropzone.css';
 import {Icon} from './icon'
 import PropTypes from 'prop-types';
 import {getAccessToken, initLogOut} from '../../security/methods';
+import {AUTH_ERROR_REFRESH_TOKEN_NETWORK_ERROR} from '../../security/constants';
 import {getMD5} from "../../../utils/crypto";
 
 let Dropzone = null;
@@ -61,7 +62,12 @@ export class DropzoneJS extends React.Component {
             } catch (e) {
                 console.log(e);
                 this.onError(e);
-                initLogOut();
+                // only logout on genuine auth errors, not transient network failures
+                if (!e.message || !e.message.startsWith(AUTH_ERROR_REFRESH_TOKEN_NETWORK_ERROR)) {
+                    initLogOut();
+                }
+                done(e.message || 'Auth error');
+                return;
             }
             if (options.maxFiles && options.maxFiles < (this.state.files.length + this.props.uploadCount)) {
                 done('Max files reached.');