Contribute: zfs driver and zfs driver shared over ISCSI #5654

openmilanese · 2021-11-29T16:48:50Z

I make available my integration work on zfs, based on the ceph driver.

zfs is for single node and zfs_iscsi for shared

https://github.com/openmilanese/zfs_iscsi.git
https://github.com/openmilanese/zfs.git

tinova · 2022-04-25T08:55:17Z

src/fireedge/etc/sunstone/admin/user-tab.yaml

+    enabled: true
+    actions:
+      change_authentication: true
+      update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:01Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:03Z

src/sunstone/etc/sunstone-views/mixed/cloud.yaml

+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:06Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:08Z

src/sunstone/etc/sunstone-views/mixed/admin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:10Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:12Z

src/sunstone/etc/sunstone-views/vcenter/cloud.yaml

+      settings_showback_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:15Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:17Z

src/sunstone/etc/sunstone-views/kvm/cloud.yaml

+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:19Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:21Z

src/sunstone/etc/sunstone-views/vcenter/groupadmin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:24Z

src/sunstone/etc/sunstone-views/kvm/admin.yaml

+      settings_auth_tab: true
+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:26Z

src/sunstone/etc/sunstone-views/mixed/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:28Z

src/sunstone/etc/sunstone-views/kvm/cloud.yaml

+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:30Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:32Z

src/sunstone/etc/sunstone-views/kvm/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:35Z

src/sunstone/etc/sunstone-views/vcenter/user.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:37Z

src/sunstone/etc/sunstone-views/mixed/admin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:39Z

src/sunstone/etc/sunstone-views/vcenter/admin.yaml

+      User.two_factor_auth: true
+      # Buttons for settings_config_tab
+      Settings.change_language: true
+      Settings.change_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:42Z

src/sunstone/etc/sunstone-views/kvm/groupadmin.yaml

+    actions:
+      User.refresh: true
+      User.create_dialog: true
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

tinova · 2022-10-18T16:52:45Z

src/sunstone/etc/sunstone-views/mixed/cloud.yaml

+    actions:
+      # Buttons for settings_info_tab
+      User.update_password: true


Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.

It appears your code contains a hardcoded password. Hardcoded secrets or credentials can allow attackers to bypass authentication methods and perform malicious actions. We recommend revoking access to resources using this credential and storing future credentials in a management service such as AWS Secrets Manager.

Learn more about the use of hardcoded credentials

Signed-off-by: Miguel E. Ruiz <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

* Removes stripping of non-matching schema attributes when casting initial values into VM Template. This is necessary due to some schemas not being strictly defined on initial loading. If this is set to true, those initial values will be dropped, i.e. placement constraints. Signed-off-by: Victor Hansson <[email protected]> (cherry picked from commit bca79a4)

Signed-off-by: dcarracedo <[email protected]>

Signed-off-by: josepselga <[email protected]> Co-authored-by: Pavel Czerný <[email protected]>

xmllint versions between 2.11 and 2.12 (both included) contain a regression which makes it not return an error code. This commit uses xpath.rb in places where logic requires checking the return code, as well as some backwards-compatible modifications in xpath.rb to support it. Discussion: https://gitlab.gnome.org/GNOME/libxml2/-/issues/673 + https://gitlab.gnome.org/GNOME/libxml2/-/issues/690 Commit introducing regression: https://gitlab.gnome.org/GNOME/libxml2/-/commit/e85f9b98a5389c69167176ae6600091e719ec38f Commit fixing it: https://gitlab.gnome.org/GNOME/libxml2/-/commit/87bebd25f11be333f0742ee5dc80e07d306c76df Signed-off-by: Guillermo Ramos <[email protected]>

- Adds the vGPU profile selector to the VM Template's update/create dialog, under the PCI Devices tab. Signed-off-by: Victor Hansson <[email protected]>

(cherry picked from commit 365e95b)

Signed-off-by: Victor Hansson <[email protected]>

Signed-off-by: dcarracedo <[email protected]>

Signed-off-by: ArnauGabrielAtienza <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

Signed-off-by: josepselga <[email protected]>

* Upgrade fast-xml-parser to v4 * Refresh actions * Update PCI profile selector Signed-off-by: Victor Hansson <[email protected]> Co-authored-by: Jorge Miguel Lobo Escalona <[email protected]>

This reverts commit 77d389f.

(cherry picked from commit 39e72cd)

- Upgrade zeromq to 6.5.1 - Upgrade fast-xml-parser to v4 - Remove manual HE encoding - Update PCI profile selector - Add missing data-cy selector(s) - Reverts 524da99 (This needs to be further tested to measure performance impact => Uploaded files are not deleted from /var/tmp one#7252) - Fixes sec_group update call Signed-off-by: Victor Hansson <[email protected]> Co-authored-by: Jorge Miguel Lobo Escalona <[email protected]>

Signed-off-by: Mirko Stojiljkovic <[email protected]>

Signed-off-by: Miguel E. Ruiz <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

Signed-off-by: Victor Hansson <[email protected]> (cherry picked from commit 20d2c06)

)

Signed-off-by: Victor Hansson <[email protected]>

allowed character are the alphanumeric, dot, dash and underscore to avoid possible shell escapes (cherry picked from commit a1c7ebb) (cherry picked from commit 1c728211bc3adf7f3653e2567b76bcdcc09f3946)

Signed-off-by: Ross <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

Signed-off-by: dcarracedo <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

Signed-off-by: dcarracedo <[email protected]>

rsmontero force-pushed the master branch 4 times, most recently from 0b269ff to b94dad5 Compare December 14, 2021 16:49

rsmontero force-pushed the master branch from 2377a4e to 995f2d1 Compare March 25, 2022 13:00

tinova reviewed Apr 25, 2022

View reviewed changes

rsmontero force-pushed the master branch 2 times, most recently from 9e1985e to d019bd4 Compare April 28, 2022 14:43

rsmontero force-pushed the master branch from e4e6b6c to 04bbc74 Compare July 27, 2022 14:32

rsmontero force-pushed the master branch from 2024f62 to 3f300f3 Compare October 6, 2022 09:08

tinova reviewed Oct 18, 2022

View reviewed changes

MiguelERuiz and others added 30 commits October 6, 2025 16:55

B #7202: Avoid drop context on vm template instantiate (#3858)

7f9e56e

Signed-off-by: Miguel E. Ruiz <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

M #-: Breadcrumb style adjustment (#3868)

dd40d3b

Signed-off-by: dcarracedo <[email protected]>

B #7249: Fix history after resize in poweroff (#3867)

b172332

M #-: Add Debian13 Gemfile.lock (#3864)

7ae9e62

M #-: Fix goca test sometimes failing on VM restore (#3856)

924b4a6

F #7268: Automatically update PCI available profiles (#3857)

3694c1c

Signed-off-by: josepselga <[email protected]> Co-authored-by: Pavel Czerný <[email protected]>

M #-: Add back vGPU profile selector (#3869)

c5e50b3

- Adds the vGPU profile selector to the VM Template's update/create dialog, under the PCI Devices tab. Signed-off-by: Victor Hansson <[email protected]>

Preserve PROFILE in PCI device if defined

6ed5f95

(cherry picked from commit 365e95b)

B #7158: Cast placement on instantiate (#3870)

56015ee

Signed-off-by: Victor Hansson <[email protected]>

B #7031: Order repeat type in periodic actions (#3871)

0c90a6a

Signed-off-by: dcarracedo <[email protected]>

M #-: Implement EVC override (#3875)

34dd8ae

Signed-off-by: ArnauGabrielAtienza <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

M #-: Use vGPU name for vGPU PCI devices (#3876)

62872c4

Signed-off-by: josepselga <[email protected]>

F #7172: Refresh actions hook fix (#3877)

77d389f

* Upgrade fast-xml-parser to v4 * Refresh actions * Update PCI profile selector Signed-off-by: Victor Hansson <[email protected]> Co-authored-by: Jorge Miguel Lobo Escalona <[email protected]>

Revert "F #7172: Refresh actions hook fix (#3877)"

4cb3280

This reverts commit 77d389f.

M #-: Show error content not pointer in SCHED_MESSAGE (#3878)

34b808b

(cherry picked from commit 39e72cd)

F #7281: Divide Vm CPU usahe with 100 (#3881)

02637c2

Signed-off-by: Mirko Stojiljkovic <[email protected]>

B #7098: Extract properly Custom vars on VM Template (#3885)

d874e8b

Signed-off-by: Miguel E. Ruiz <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

#7212: Revert zmq changes (#3886)

f40ba4a

Signed-off-by: Victor Hansson <[email protected]> (cherry picked from commit 20d2c06)

B #6951: delete cluster_vnc_bitmap record when deleting a cluster (#3882

77c59fb

)

B #6853: fix bash regex bug in FS datastore (#3883)

605e2da

B #-: Fix fullscreen toggle (#3887)

263087b

Signed-off-by: Victor Hansson <[email protected]>

M #-: Always render disk snapshot revert button (#3888)

d94a324

Signed-off-by: Victor Hansson <[email protected]>

B #7307: add disk serial attribute on disk hotplug

d006301

allowed character are the alphanumeric, dot, dash and underscore to avoid possible shell escapes (cherry picked from commit a1c7ebb) (cherry picked from commit 1c728211bc3adf7f3653e2567b76bcdcc09f3946)

B #7063: Fix cluster assign for virtual network (#3891)

9f6c8ba

Signed-off-by: Ross <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

F #7172: Fireedge do not refresh actions! (#3893)

c9fef8a

M #-: Fix disk cost calculation (#3897)

f35fcb9

Signed-off-by: dcarracedo <[email protected]> Co-authored-by: Tino Vázquez <[email protected]>

M #-: Doc bug template (#3901)

aa85035

Signed-off-by: dcarracedo <[email protected]>

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Are you sure you want to change the base?

Contribute: zfs driver and zfs driver shared over ISCSI #5654

Uh oh!

Conversation

openmilanese commented Nov 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

25 participants

openmilanese commented Nov 29, 2021 •

edited

Loading