fix: useMaxAPDU

Author: thewhobox

.vscode/launch.json

@@ -27,7 +27,7 @@
             "preLaunchTask": "build",
             // If you have changed target frameworks, make sure to update the program path.
             "program": "${workspaceFolder}/bin/Debug/net9.0/KnxFileTransferClient.dll",
-            "args": ["open", "--pkg", "52"],
+            "args": ["open", "--pkg", "50"],
             "cwd": "${workspaceFolder}",
             // For more information about the 'console' field, see https://aka.ms/VSCode-CS-LaunchJson-Console
             "console": "integratedTerminal",

Program.cs

@@ -122,6 +122,7 @@ static async Task<int> Main(string[] args)
                 throw new Exception($"Das Zielgerät {arguments.PhysicalAddress} ist nicht erreichbar.", ex);
             }
             Console.WriteLine($"Info:  Verbindung zum KNX-Gerät {arguments.Get<string>("pa")} hergestellt");
+            useMaxAPDU = 255;
             // TODO get real MaxFrameLength from connection
             // if(conn.MaxFrameLength < useMaxAPDU)
             //     useMaxAPDU = conn.MaxFrameLength;
@@ -130,14 +131,14 @@ static async Task<int> Main(string[] args)
             device.SetMaxFrameLength(useMaxAPDU);
             Console.WriteLine($"Info:  Gerät MaxAPDU: {device.MaxFrameLength}");
             Console.WriteLine($"Info:  Verwende MaxAPDU: {useMaxAPDU}");
-            Console.WriteLine($"Info:  Verwende Package: {arguments.Get<int>("pkg")}");
             if(arguments.Get<int>("pkg") > (useMaxAPDU - 3)) {
                 Console.ForegroundColor = ConsoleColor.DarkYellow;
                 Console.WriteLine("WARN:  Package ist größer als MaxAPDU");
                 Console.WriteLine($"WARN:  Package wird geändert auf {useMaxAPDU-3}");
                 Console.ResetColor();
                 arguments.Set("pkg", useMaxAPDU-3);
             }
+            Console.WriteLine($"Info:  Verwende Package: {arguments.Get<int>("pkg")}");
             // Set the MaxAPDU that we calculated
             device.MaxFrameLength = useMaxAPDU;
 
@@ -165,10 +166,20 @@ static async Task<int> Main(string[] args)
                     string args3 = Console.ReadLine() ?? "";
                     string[] args2 = args3.Split(" ");
                     arguments = new Arguments();
-                    await arguments.Init(args2, true);
-                    await device.Connect(true);
-                    // Set the MaxAPDU that we calculated
-                    device.MaxFrameLength = useMaxAPDU;
+                    try
+                    {
+                        await arguments.Init(args2, true);
+                        await device.Connect(true);
+                        // Set the MaxAPDU that we calculated
+                        device.MaxFrameLength = useMaxAPDU;
+                    } catch(Exception ex)
+                    {
+                        Console.ForegroundColor = ConsoleColor.Red;
+                        Console.WriteLine("Error: " + ex.Message);
+                        Console.ResetColor();
+                        isOpen = false;
+                        continue;
+                    }
                 }
 
                 try
@@ -735,6 +746,20 @@ private static async Task update(Arguments args, FileTransferClient client)
                 return;
             }
 
+            Console.WriteLine("Info:  Dateiübertragung abgeschlossen                          ");
+            Console.WriteLine("Info:  Übertragene Firmware wird geprüft...                    ");
+
+            Lib.FileInfo fileInfo = await client.FileInfo("/fw.bin", args.Get<bool>("force"));
+            Console.WriteLine($"Info:  CRC der übertragene Firmware: {fileInfo.GetCrc()}");
+            byte[] file = FileHandler.GetBytes(args.Source);
+
+            CRCTool crc = new();
+            crc.Init(CRCTool.CRCCode.CRC32);
+            ulong crc32 = crc.CalculateCRC(file);
+            byte[] x = BitConverter.GetBytes(crc32).Take(4).Reverse().ToArray();
+            string crc32str = BitConverter.ToString(x).Replace("-", "");
+            Console.WriteLine($"Info:  CRC der lokalen Firmware:      {crc32str}");
+
             Console.WriteLine("Info:  Gerät wird neu gestartet                                ");
 
             await device.InvokeFunctionProperty(159, 101, System.Text.UTF8Encoding.UTF8.GetBytes("/fw.bin" + char.MinValue));