Skip to content

[Bug]: cargo make patina-test fails (regression) #1443

@thomashinds

Description

@thomashinds

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

cargo make patina-test (and therefore cargo make all fails with several errors like the following:

error[E0433]: failed to resolve: could not find `TEST_CASES` in `__private_api`
  --> components/patina_adv_logger/src/integration_test.rs:21:1
   |
21 | #[patina_test]
   | ^^^^^^^^^^^^^^ could not find `TEST_CASES` in `__private_api`
   |
note: found an item that was configured out
  --> components/patina_test/src/__private_api.rs:28:12
   |
26 | #[cfg(feature = "test-runner")]
   |       ----------------------- the item is gated behind the `test-runner` feature
27 | #[linkme::distributed_slice]
28 | pub static TEST_CASES: [TestCase];
   |            ^^^^^^^^^^
   = note: this error originates in the attribute macro `patina_test` (in Nightly builds, run with -Z macro-backtrace for more info)

This regressed in commit acb5c1b, clobbering changes in Makefile.toml from 16fd292
(see https://github.com/OpenDevicePartnership/patina/commits/main/Makefile.toml)

Expected Behavior

cargo make patina-test succeeds

Steps To Reproduce

cargo make patina-test

Build Environment

n/a

Version Information

main since https://github.com/OpenDevicePartnership/patina/commit/acb5c1bf0dfb4ab55b40df5cdb9c9e1e50f3ea84

Urgency

Medium

Are you going to fix this?

Someone else needs to fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

cargo-make-patina-test.txt

Metadata

Metadata

Assignees

Labels

type:bugSomething isn't workingurgency:mediumImportant with a moderate impact

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions