Conversation
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on January 1
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
Related to OpenCloning/OpenCloning_backend#383 |
| end, | ||
| strand, | ||
| repository_id: sequence_accession, | ||
| coordinates: formatSequenceLocationString(start, end, strand), |
There was a problem hiding this comment.
Bug: URL strand parameter not converted to number before comparison
The strand value from URL parameters is a string (e.g., '-1' or '1'), but formatSequenceLocationString compares it against the number -1 with strict equality. Since '-1' !== -1, the complement format will never be generated for negative strand sequences loaded from URL parameters. The strand value needs to be converted to a number (e.g., Number(strand)) before being passed to formatSequenceLocationString.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #563 +/- ##
==========================================
+ Coverage 82.32% 82.39% +0.06%
==========================================
Files 176 177 +1
Lines 6157 6181 +24
Branches 1319 1328 +9
==========================================
+ Hits 5069 5093 +24
Misses 1088 1088 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Issue #562
Note
Update frontend to use repository_id/coordinates-based source schema with new repository metadata, add strict URL param validation for genome coordinates, and refresh tests and example files.
repository_id+coordinates(e.g.,formatSequenceLocationString) instead ofsequence_accession/start/end/strand; removerepository_nameusage.repositoryMetadataand refactor repository UI to use sourcetype(e.g.,NCBISequenceSource,AddgeneIdSource); update request endpoints to use slugs.start/end,strand∈ {1, -1},start>0, `end>start}); show specific error alerts.GenomeCoordinatesMessagerendering usingcoordinatesandrepository_id.{ source, sequence }structure.formatSequenceLocationStringhelper...formatting; strand validation); update alert selector path.schema_versionto0.4.9and update example JSONs to new fields (repository_id,coordinates); removerepository_nameentries and update SnapGene/GenBank fields accordingly.Written by Cursor Bugbot for commit ea0e120. This will update automatically on new commits. Configure here.