proposed new solution with deepEquals on Objects, fix also added to ChangedExamples.java, Fixed suggestion from copilot, grammatical error

Author: wexom

core/src/main/java/org/openapitools/openapidiff/core/model/ChangedExample.java

@@ -1,6 +1,7 @@
 package org.openapitools.openapidiff.core.model;
 
-import java.lang.reflect.Array;
+import org.apache.commons.lang3.builder.EqualsBuilder;
+
 import java.util.Objects;
 
 public class ChangedExample implements Changed {
@@ -31,35 +32,10 @@ public void setRightExample(Object rightExample) {
 
   @Override
   public DiffResult isChanged() {
-    DiffResult arrayDiff = compareArrays();
-    if (arrayDiff != null) {
-      return arrayDiff;
-    }
-
-    return Objects.equals(leftExample, rightExample) ? DiffResult.NO_CHANGES : DiffResult.METADATA;
-  }
-
-  private DiffResult compareArrays() {
-    if (leftExample == null || rightExample == null) {
-      return null;
-    }
-
-    if (!leftExample.getClass().isArray() || !rightExample.getClass().isArray()) {
-      return null;
-    }
-
-    int leftLength = Array.getLength(leftExample);
-
-    if (leftLength != Array.getLength(rightExample)) {
+    if (!Objects.deepEquals(leftExample, rightExample)) {
       return DiffResult.METADATA;
     }
 
-    for (int i = 0; i < leftLength; i++) {
-      if (!Objects.deepEquals(Array.get(leftExample, i), Array.get(rightExample, i))) {
-        return DiffResult.METADATA;
-      }
-    }
-
     return DiffResult.NO_CHANGES;
   }
 

core/src/main/java/org/openapitools/openapidiff/core/model/ChangedExamples.java

@@ -30,7 +30,7 @@ public void setRightExamples(Object rightExamples) {
 
   @Override
   public DiffResult isChanged() {
-    if (!Objects.equals(leftExamples, rightExamples)) {
+    if (!Objects.deepEquals(leftExamples, rightExamples)) {
       return DiffResult.METADATA;
     }
     return DiffResult.NO_CHANGES;

core/src/main/java/org/openapitools/openapidiff/core/output/AsciidocRender.java

@@ -34,7 +34,7 @@ public void render(ChangedOpenApi diff, OutputStreamWriter outputStreamWriter) {
               diff.getNewSpecOpenApi().getInfo().getVersion()));
       safelyAppend(outputStreamWriter, System.lineSeparator());
       safelyAppend(outputStreamWriter, System.lineSeparator());
-      safelyAppend(outputStreamWriter, "NOTE: No differences. Specifications are equivalents");
+      safelyAppend(outputStreamWriter, "NOTE: No differences. Specifications are equivalent");
     } else {
       safelyAppend(
           outputStreamWriter,

core/src/main/java/org/openapitools/openapidiff/core/output/ConsoleRender.java

@@ -27,7 +27,7 @@ public class ConsoleRender implements Render {
   public void render(ChangedOpenApi diff, OutputStreamWriter outputStreamWriter) {
     this.diff = diff;
     if (diff.isUnchanged()) {
-      safelyAppend(outputStreamWriter, "No differences. Specifications are equivalents");
+      safelyAppend(outputStreamWriter, "No differences. Specifications are equivalent");
     } else {
       safelyAppend(outputStreamWriter, bigTitle("Api Change Log"));
       safelyAppend(

core/src/test/java/org/openapitools/openapidiff/core/output/ConsoleRenderTest.java

@@ -89,6 +89,6 @@ void renderShowsNoDifferencesWhenCSVMediaTypeResponseExampleIsByteArray() {
     render.render(diff, outputStreamWriter);
     assertThat(outputStream.toString()).isNotBlank();
     assertThat(outputStream.toString())
-        .hasToString("No differences. Specifications are equivalents");
+        .hasToString("No differences. Specifications are equivalent");
   }
 }