[18.0] base_tier_validation: Reviews pending indefinitely

[victoralmau]

Although I detected this behavior in v18, it probably also occurred in previous versions.

Example use case:

• Install purchase_request_tier_validation (or any other)
• Modify the Marc Demo user and define the Purchase Request > Purchase Request Manager permission
• Create a Tier definition called “New Tier Validation 1,” linked to the user Marc Demo, Approve by sequence=True, Sequence=20
• Create a Tier definition called “New Tier Validation 2,” linked to the user Mitchell Admin, Approve by sequence=True, Sequence=10, Send reminder message on pending reviews=3
• Create a test user with permissions in Purchase Request
• Log in with the test user and create a Purchase request + click on the Request validation button. Two reviews will have been created: Marc Demo + Mitchell Admin
• Log in with Marc Demo to the previously created purchase request and click on Reject. The purchase request will be rejected.
• The linked review Mitchell Admin will remain pending
• Change the date (create_date) of the created tier_review records and set it to 3 days less.
• Run the “Send Tier Review Reminder” cron manually. An activity will have been created for Mitchell Admin linked to the pending review of the previously created Purchase Request. Even if the activity is canceled or completed, it will continue to be created indefinitely.

What is the appropriate behavior in this case?

IMO: If there are several pending reviews and one is rejected, the rest of the reviews should be automatically canceled.

Ping @LoisRForgeFlow

@Tecnativa TT61255

[LoisRForgeFlow]

Hi @victoralmau

I see, what you propose

"IMO: If there are several pending reviews and one is rejected, the rest of the reviews should be automatically canceled."

makes sense. The issue with that is that we would need to either remove the pending reviews loosing the ability to trace or add a new state "cancelled". The second option looks better but requires more code changes.

Thoughts?

[victoralmau]

I think the best option is to use the more “complex” option of adding the cancel status.
If you agree, I will prepare the corresponding changes.

[LoisRForgeFlow]

@victoralmau I agree, let's go that way!