diff --git a/upgrade_analysis/models/upgrade_analysis.py b/upgrade_analysis/models/upgrade_analysis.py index 0b9a4b72082..8eefad21ba7 100644 --- a/upgrade_analysis/models/upgrade_analysis.py +++ b/upgrade_analysis/models/upgrade_analysis.py @@ -370,7 +370,9 @@ def _get_xml_diff( # (usually None) model = self.env[local_record.attrib["model"]] field = model._fields[attribs["name"]] - attribs["eval"] = ast.unparse(ast.Constant(field.falsy_value)) + eval_constant = ast.unparse(ast.Constant(field.falsy_value)) + if eval_constant != "''": + attribs["eval"] = eval_constant element.append(etree.Element(record_remote_dict[key].tag, attribs)) else: oldrepr = self._get_node_value(record_remote_dict[key]) diff --git a/upgrade_analysis/tests/test_module.py b/upgrade_analysis/tests/test_module.py index fc23f2457a4..65d93b8d924 100644 --- a/upgrade_analysis/tests/test_module.py +++ b/upgrade_analysis/tests/test_module.py @@ -136,6 +136,7 @@ def test_xml_comparison(self): name="module_ids" eval="[Command.set([ref('base.module_web')])]" /> + some name """ ), @@ -150,3 +151,4 @@ def test_xml_comparison(self): }, ) self.assertIn('', diff) + self.assertIn('', diff)