Build Failure in flash_image.c Due to Comparison Always Evaluating to True

[cwozny]

There appears to be a build failure when compiling the flash image utility in both the master branch and tagged release 2025.10:

[ 67%] Building C object host/utilities/bladeRF-cli/CMakeFiles/bladeRF-cli.dir/src/cmd/flash_image.c.o
~/bladeRF/host/utilities/bladeRF-cli/src/cmd/flash_image.c:71:35: error: overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare]
71 | if (val[i] >= 'a' || val[i] <= 'f') {
| ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [host/utilities/bladeRF-cli/CMakeFiles/bladeRF-cli.dir/src/cmd/flash_image.c.o] Error 1
make[1]: *** [host/utilities/bladeRF-cli/CMakeFiles/bladeRF-cli.dir/all] Error 2
make: *** [all] Error 2

This is with clang v21:

% gcc -v
Apple clang version 21.0.0 (clang-2100.0.123.102)
Target: arm64-apple-darwin25.4.0

It looks like that block of code is attempting to capitalize lowercase letters, so I suspect the conditional should be:

if ('a' <= val[i] && val[i] <= 'f')

[root-drift-flux]

I was able to replicate this issue -
clang version 21.1.7
Target: x86_64-unknown-linux-musl
Thread model: posix
InstalledDir: /usr/lib/llvm/21/bin

Surely is supposed to be a &&.

[cwozny]

It looks like pull request #1045 from November 25 and #1062 from today both resolve this issue.