Skip to content

Commit 4580e91

Browse files
committed
Merge remote-tracking branch 'upstream/main' into fp8-rl-mxfp8-weight-sync
# Conflicts: # skyrl/backends/skyrl_train/inference_servers/new_inference_worker_wrap.py
2 parents 1d1dccc + b0f74ac commit 4580e91

67 files changed

Lines changed: 1869 additions & 717 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.claude/docs/ci.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
- Compute config: `l4_ci` (referenced from `ci/anyscale_*.yaml`).
1414
- Cloud: `sky-anyscale-aws-us-east-1`.
15-
- Image: `novaskyai/skyrl-train-ray-2.56.0-py3.12-cu12.8` (varies per workflow).
15+
- Image: `novaskyai/skyrl-train-ray-2.57.0-py3.12-cu13.0` (varies per workflow).
1616
- Logs: visit the Anyscale job page linked from the GitHub Actions step output. Stderr from Ray workers shows up under the head node logs, not the entrypoint logs.
1717

1818
## Adding a New Test to CI

.claude/docs/tinker.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ SkyRL's implementation of the [Tinker API](https://tinker-docs.thinkingmachines.
55
## Code Layout
66

77
- **`skyrl/tinker/api.py`** -- FastAPI HTTP server. Receives Tinker SDK requests, writes them to SQLite/Postgres, returns future IDs.
8+
- **`skyrl/tinker/proto_serialization.py`** -- Proto wire-format conversion. SDK >= 0.25.0 sends `forward_backward` request bodies as protobuf (with forward-only passes routed to `/forward_backward` via a `forward_only` flag instead of `/forward`) and requires proto-serialized `SampleResponse`/`ForwardBackwardOutput` results from `retrieve_future`. Mirrors the SDK's `tinker/proto/{request,response}_conv.py`; round-trip tested in `tests/tinker/test_proto_serialization.py`.
89
- **`skyrl/tinker/engine.py`** -- Background subprocess (`TinkerEngine`). Polls DB, batches compatible requests, dispatches to backend.
910
- **`skyrl/tinker/types.py`** -- Internal Pydantic models (distinct from API request/response models in `api.py`). `LOSS_TYPES` dict defines valid loss functions.
1011
- **`skyrl/tinker/config.py`** -- `EngineConfig` Pydantic model. `add_model()` auto-generates argparse flags from Pydantic fields.

.github/workflows/cpu_skyrl.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,12 @@ jobs:
3737
steps:
3838
- uses: actions/checkout@v4
3939
- name: Install uv
40-
run: |
41-
curl -LsSf https://astral.sh/uv/install.sh | sh
40+
# Use the action rather than the curl installer: on GitHub-hosted runners it
41+
# also restores/saves ~/.cache/uv between runs, which matters here because
42+
# this job resolves several distinct extra sets (tinker/jax/dev).
43+
uses: astral-sh/setup-uv@v6
44+
with:
45+
enable-cache: true
4246
- name: Run lint
4347
run: |
4448
# Pin to match the ruff rev in .pre-commit-config.yaml. Unpinned `uvx ruff`

.github/workflows/cpu_skyrl_train.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ jobs:
4242
with:
4343
# Semantic version range syntax or exact version of a Python version
4444
python-version: '3.12'
45-
cache: 'pip'
4645
- name: Install the latest version of uv
4746
uses: astral-sh/setup-uv@v6
4847
with:
@@ -64,7 +63,6 @@ jobs:
6463
uses: actions/setup-python@v5
6564
with:
6665
python-version: '3.12'
67-
cache: 'pip'
6866
- name: Install the latest version of uv
6967
uses: astral-sh/setup-uv@v6
7068
with:
@@ -88,7 +86,6 @@ jobs:
8886
uses: actions/setup-python@v5
8987
with:
9088
python-version: '3.12'
91-
cache: 'pip'
9289
- name: Install the latest version of uv
9390
uses: astral-sh/setup-uv@v6
9491
with:

.github/workflows/gpu_ci_h100.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ jobs:
5252
uses: actions/setup-python@v5
5353
with:
5454
python-version: '3.12'
55-
cache: 'pip'
5655
- name: Install the latest version of uv
5756
uses: astral-sh/setup-uv@v6
5857
with:

.github/workflows/gpu_e2e_ci.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626
with:
2727
# Semantic version range syntax or exact version of a Python version
2828
python-version: '3.12'
29-
cache: 'pip'
3029
- name: Install the latest version of uv
3130
uses: astral-sh/setup-uv@v6
3231
with:

.github/workflows/gpu_e2e_ci_fully_async.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626
with:
2727
# Semantic version range syntax or exact version of a Python version
2828
python-version: '3.12'
29-
cache: 'pip'
3029
- name: Install the latest version of uv
3130
uses: astral-sh/setup-uv@v6
3231
with:

.github/workflows/gpu_e2e_ci_megatron.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626
with:
2727
# Semantic version range syntax or exact version of a Python version
2828
python-version: '3.12'
29-
cache: 'pip'
3029
- name: Install the latest version of uv
3130
uses: astral-sh/setup-uv@v6
3231
with:

.github/workflows/gpu_e2e_ci_sft.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626
with:
2727
# Semantic version range syntax or exact version of a Python version
2828
python-version: '3.12'
29-
cache: 'pip'
3029
- name: Install the latest version of uv
3130
uses: astral-sh/setup-uv@v6
3231
with:

.github/workflows/gpu_e2e_ci_tinker.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626
with:
2727
# Semantic version range syntax or exact version of a Python version
2828
python-version: '3.12'
29-
cache: 'pip'
3029
- name: Install the latest version of uv
3130
uses: astral-sh/setup-uv@v6
3231
with:

0 commit comments

Comments
 (0)