Skip to content

Commit 67db99b

Browse files
authored
Merge pull request #92 from NorthShoreAutomation/bugfix/field-list-bugs
bugfix: fix FieldResponse models to to be optional
2 parents 9dc6e78 + 2a6d53c commit 67db99b

File tree

1 file changed

+18
-17
lines changed

1 file changed

+18
-17
lines changed

pythonik/models/metadata/fields.py

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -86,38 +86,39 @@ class Field(_FieldConfigurable):
8686

8787

8888
class FieldResponse(BaseModel):
89-
auto_set: bool
90-
date_created: datetime
91-
date_modified: datetime
89+
auto_set: Optional[bool] = None
90+
date_created: Optional[datetime] = None
91+
date_modified: Optional[datetime] = None
9292
description: Optional[str] = None
9393
external_id: Optional[str] = None
94-
field_type: IconikFieldType
95-
hide_if_not_set: bool
96-
is_block_field: bool
97-
is_warning_field: bool
98-
label: str
94+
field_type: Optional[IconikFieldType] = None
95+
hide_if_not_set: Optional[bool] = None
96+
is_block_field: Optional[bool] = None
97+
is_warning_field: Optional[bool] = None
98+
label: Optional[str] = None
9999
mapped_field_name: Optional[str] = None
100100
max_value: Optional[float] = None
101101
min_value: Optional[float] = None
102-
multi: bool
103-
name: str
102+
multi: Optional[bool] = None
103+
name: Optional[str] = None
104104
options: Optional[List[FieldOption]] = None
105-
read_only: bool
106-
representative: bool
107-
required: bool
108-
sortable: bool
105+
read_only: Optional[bool] = None
106+
representative: Optional[bool] = None
107+
required: Optional[bool] = None
108+
sortable: Optional[bool] = None
109109
source_url: Optional[HttpUrl] = None
110-
use_as_facet: bool
110+
use_as_facet: Optional[bool] = None
111111

112112
class Config:
113113
use_enum_values = True
114114

115115

116116
class FieldListResponse(BaseModel):
117117
"""Response model for a paginated list of metadata fields.
118-
118+
119119
This follows the standard pagination format used by the Iconik API.
120120
"""
121+
121122
first_url: Optional[str] = None
122123
last_url: Optional[str] = None
123124
next_url: Optional[str] = None
@@ -127,6 +128,6 @@ class FieldListResponse(BaseModel):
127128
per_page: Optional[int] = None
128129
prev_url: Optional[str] = None
129130
total: Optional[int] = None
130-
131+
131132
class Config:
132133
use_enum_values = True

0 commit comments

Comments
 (0)