Ext.Stats.Sync crashes the game often before main menu

[Serpens66]

Operating System

Windows

Extender Version

v60

Game Version

v3.6.117.3735

Bug Summary

Code like this often crashes the game before reaching the main menu.
But it is not 100% reproduceable for whatever reason.

Ext.Events.StatsLoaded:Subscribe(function(e)
  for i,name in pairs(Ext.Stats.GetStats("SkillData")) do
    if name=="Target_RangedInfusion" then
      Ext.Stats.Sync(name,false) 
    end
  end
end)

of course in my real code I do some changes to some of them, before calling Sync. My current assumption was that it can crash when calling Sync while nothing was changed. But even after adding a check if sth was changed, it sometimes crashes.
I never had a crash when I outcommented the Sync, that is why I assume this is causing it.

The Extender Log does not mention anything that sounds helpful. So it just crashes without any error in the log.

No response

[Serpens66]

I tested more. The crash is only "random" on startup to main menu. So in 50% of the cases it crashes before main menu, but then it will crash when loading a savegame. So the crash in general is 100% reproduceable on my side.

And I did more tests, this is the result:

Ext.Events.StatsLoaded:Subscribe(function(e)
  
  
  -- crashed
  for i,name in pairs(Ext.Stats.GetStats("SkillData")) do
    if name=="Target_RangedInfusion" then
      Ext.Stats.Sync(name,false) 
    end
  end
  
  
  -- no crash
  -- local names = {"Target_RangedInfusion"}
  -- for _,name in ipairs(names) do
    -- Ext.Stats.Sync(name,false)
  -- end
  

  -- no crash
  -- local need_sync = {}
  -- for i,name in pairs(Ext.Stats.GetStats("SkillData")) do
    -- if name=="Target_RangedInfusion" then
      -- table.insert(need_sync,name)
    -- end
  -- end
  -- for _,name in ipairs(need_sync) do
    -- Ext.Stats.Sync(name,false)
  -- end
  
  -- no crash
  -- local need_sync = {}
  -- for i,name in pairs(Ext.Stats.GetStats("SkillData")) do
    -- if name=="Target_RangedInfusion" then
      -- table.insert(need_sync,name)
      -- Ext.Stats.Sync(name,false)
    -- end
  -- end
  
  -- crashed
  -- local need_sync = {}
  -- for i,name in pairs(Ext.Stats.GetStats("SkillData")) do
    -- if name=="Target_RangedInfusion" then
      -- Ext.Print("SERPSTATSLOADED",name)
      -- Ext.Stats.Sync(name,false)
    -- end
  -- end
  
  -- no crash
  -- for i,name in pairs(Ext.Stats.GetStats("SkillData")) do
    -- Ext.Stats.Sync(name,false)
  -- end
  
  
  Ext.Print("SERPSTATSLOADED")
  
end)

I also uploaded a crash mod with this code here: https://github.com/Serpens66/My-Divinity-Original-Sin-2-DEF-Mods/tree/main/CrashModExtender/Mods/CrashModExtender (also the pak can be found there)

[Serpens66]

Sync can also break Skill:

  local name="Target_RangedInfusion"
  local MyStat = Ext.Stats.Get(name)
  local SkillProperties = MyStat["SkillProperties"] 
  MyStat["SkillProperties"] = SkillProperties
  Ext.Stats.Sync(name,false)

This code called in StatsLoaded will break the skill (shows wrong tooltip and when you try to activate it, the game wil crash)

Is the reason for these problems just that I should not call "Sync" within StatsLoaded and outside of it it will work fine? Or is Sync buggy?

[Norbyte]

StatsLoaded is special because it is called when the appropriate cached object managers (SkillPrototypeManager etc) are not yet loaded.
Sync() serves a dual purpose, it sends the updated stats entry to the client and it updates the cached copy within the prototype manager.
Since the protos are built after StatsLoaded, prematurely filling the cache may lead to issues.