fix: Performance and code quality improvements (v1.2.1)

Performance optimizations and code quality improvements for maintainability:

PERFORMANCE:
- Replace += operators with ArrayList.Add() for better performance in loops
- Optimize array operations in Get-PIMPendingRequests and Get-PIMRolesBatch
- Improve memory efficiency for large role collections

CODE READABILITY:
- Replace backtick line continuations with parameter splatting
- Simplify complex Sort-Object statements with variable-based approaches
- Improve maintainability of Microsoft Graph API calls

MODULE REQUIREMENTS:
- Add explicit #Requires statements for Microsoft Graph modules (v2.29.0+)
- Declare dependency on Az.Accounts (v5.1.0+)
- Ensure consistent module version requirements

TECHNICAL DEBT:
- Clean up performance anti-patterns identified in code review
- Improve overall code maintainability and readability
- Maintain backward compatibility while optimizing internals

No breaking changes
Addresses performance concerns and improves development experience.

Author: Noble-Effeciency13

CHANGELOG.md

@@ -15,6 +15,29 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ---
 
+## [1.2.1] - 2025-08-04
+
+### Added
+- **Automatic Dependency Resolution**: Enhanced `Start-PIMActivation` with automatic conflict detection and module installation
+- **Force Parameter**: Added `-Force` parameter to `Start-PIMActivation` for fully automated dependency resolution
+- **Clean Console Output**: Suppressed verbose output noise while preserving debugging capabilities when requested
+- **Module Requirements**: Added explicit `#Requires` statements for all required Microsoft Graph modules and versions
+
+### Fixed
+- **Verbose Output Noise**: Suppressed "Populating RepositorySourceLocation" and other unwanted Get-Module verbose messages
+- **Function Import Verbosity**: Eliminated verbose function import messages during module loading  
+- **Console Clutter**: Removed duplicate dependency checking logic and unnecessary output during normal operation
+- **Performance**: Replaced `+=` operators with `ArrayList.Add()` for better performance in loops and array operations
+- **Code Readability**: Replaced backtick line continuations with parameter splatting for improved maintainability
+
+### Technical Improvements
+- **Resolve-PIMDependencies**: New internal function for comprehensive dependency resolution with retry logic
+- **Enhanced Error Messages**: Improved user guidance for dependency resolution issues
+- **Code Quality**: Performance optimizations including ArrayList usage and cleaner parameter handling
+- **Maintainability**: Improved code structure with splatting instead of line continuations
+
+---
+
 ## [1.2.0] - 2025-07-31
 
 ### Added

PIMActivation.psd1

@@ -3,7 +3,7 @@
     RootModule = 'PIMActivation.psm1'
 
     # Version number of this module.
-    ModuleVersion = '1.2.0'
+    ModuleVersion = '1.2.1'
 
     # Supported PSEditions - Requires PowerShell Core (7+)
     CompatiblePSEditions = @('Core')
@@ -26,17 +26,13 @@
     # Minimum version of the PowerShell engine required by this module
     PowerShellVersion = '7.0'
 
-    # Modules that must be imported into the global environment prior to importing this module
-    RequiredModules = @(
-        @{ ModuleName = 'Microsoft.Graph.Authentication'; RequiredVersion = '2.29.1' },
-        @{ ModuleName = 'Microsoft.Graph.Users'; RequiredVersion = '2.29.1' },
-        @{ ModuleName = 'Microsoft.Graph.Identity.DirectoryManagement'; RequiredVersion = '2.29.1' },
-        @{ ModuleName = 'Microsoft.Graph.Identity.Governance'; RequiredVersion = '2.29.1' },
-        @{ ModuleName = 'Az.Accounts'; RequiredVersion = '5.1.0' }
-    )
+    # Modules are dynamically installed and imported by the module's initialization logic
+    RequiredModules = @()
 
     # Functions to export from this module
-    FunctionsToExport = @('Start-PIMActivation')
+FunctionsToExport = @(
+    'Start-PIMActivation'
+)
 
     # Cmdlets to export from this module
     CmdletsToExport = @()
@@ -64,113 +60,27 @@
 
             # ReleaseNotes
             ReleaseNotes = @'
-## Release Notes v1.2.0
-
-### 🚀 Major Performance Enhancements
-- **Batch API Operations**: Complete rewrite of role fetching logic using batch operations (85% reduction in API calls)
-- **Intelligent Duplicate Role Handling**: Advanced algorithm for managing multiple instances of same role with proper group attribution
-- **Enhanced Group-Role Attribution**: Sophisticated cross-referencing system showing which groups provide which roles
-- **Comprehensive Error Handling**: Bulletproof property access protection preventing common PowerShell errors
-
-### 🎯 UI/UX Improvements
-- **Smooth Progress Flow**: Coordinated progress tracking across all loading phases (no more backwards jumps)
-- **Group Visibility**: ProvidedRoles functionality shows exactly which roles each group membership provides
-- **Proper Expiration Attribution**: Duplicate roles now show individual expiration times based on their providing groups
-- **Enhanced Resource Display**: Shows "Entra ID (via Group: GroupName)" for group-derived roles
-
-### 🔧 Technical Improvements
-- **Advanced Array Handling**: @() wrapper implementation preventing .Count property errors
-- **Safe Property Access**: PSObject.Properties pattern for bulletproof property checking
-- **Intelligent Caching**: Enhanced cache invalidation system with proper timing
-- **Defensive Coding**: Comprehensive try-catch blocks around all critical operations
-
-### 🔍 Debugging & Logging
-- **Enhanced Verbose Logging**: Detailed progress tracking with differentiated handling for groups vs Entra roles
-- **Sophisticated Matching Logic**: Priority-based group assignment with temporal vs permanent preferences
-- **Cross-Reference Validation**: Extensive debugging for group-role relationship verification
-
-## Release Notes v1.1.1
-
-### Added
-- **Just-in-Time Module Loading**: New `Initialize-PIMModules` system that loads modules only when needed
-- **Version Pinning**: Exact module version enforcement to prevent compatibility issues
-- **Assembly Conflict Prevention**: Automatic removal of conflicting module versions from session
-- Module loading state tracking and compatibility validation
-
-### Changed
-- **Updated Module Versions**: Now uses Microsoft.Graph 2.29.1 + Az.Accounts 5.1.0 (tested working combination)
-- Replaced legacy `Install-RequiredModules` with new `Initialize-PIMModules` function
-- Improved module initialization in `Start-PIMActivation` function
-- Updated CI/CD workflow to use latest compatible module versions
-
-### Removed
-- **Scripts Folder**: Removed compatibility testing tools (no longer needed with version pinning)
-- Legacy module installation and validation code
-- Outdated module version requirements
-
-### Fixed
-- Resolved `AuthenticateAsync` method signature compatibility issues
-- Improved module loading reliability and error handling
-- Enhanced troubleshooting guidance for version conflicts
-
-## Release Notes v1.1.0
-
-### ⚡ Major Improvements
-- **WAM Authentication**: Implemented Windows Web Account Manager (WAM) for reliable authentication
-- **Removed MSAL.PS Dependency**: Now uses direct MSAL.NET calls for better reliability and performance
-- **Enhanced Authentication Context**: Improved handling of conditional access policies
-
-### 🔧 Technical Changes
-- Direct integration with Az.Accounts MSAL assemblies
-- Eliminated PowerShell 5.1 fallback - now fully PowerShell 7+ native
-- Improved error handling and timeout management
-- Better assembly loading and management
-
-## Release Notes v1.0.1
-
-### 🔧 Bug Fixes
-- Fixed authentication context token acquisition for conditional access policies
-- Enhanced error handling for authentication scenarios
-- Improved MSAL.PS integration for more reliable interactive authentication prompts
-- Fixed timing issues with authentication context token validation
-
-### 🆕 New Features
-- Added token caching to minimize re-authentication prompts
-- Enhanced authentication context flow with better error messages
-- Improved handling of authentication timeouts and cancellation
-
-### 🔧 Technical Changes
-- Better integration with MSAL.PS for authentication context scenarios
-- Enhanced token validation and refresh logic
-- Improved error handling for authentication context failures
-
-## Release Notes v1.0.0
-
-### 🎉 Initial Release
-- **Modern GUI Interface**: Clean Windows Forms application for PIM role management
-- **Multi-Role Support**: Activate Microsoft Entra ID roles and PIM-enabled security groups
-- **Authentication Context**: Seamless handling of Conditional Access authentication context policies
-- **Bulk Operations**: Select and activate multiple roles simultaneously with policy validation
-- **PowerShell Compatibility**: Requires PowerShell 7+ for optimal performance and modern language features
-- **Policy Compliance**: Automatic detection of MFA, justification, and ticket requirements
-- **Real-time Updates**: Live monitoring of active assignments and pending requests
-
-### 🔧 Technical Features
-- Direct REST API calls for authentication context preservation  
-- Automatic module dependency management
-- Comprehensive error handling and user feedback
-
-### 📋 Requirements
-- Windows Operating System
-- PowerShell 7+ (Download from https://aka.ms/powershell)
-- Microsoft Graph PowerShell modules (auto-installed)
-- Az.Accounts module for WAM authentication support
-- Appropriate Entra ID permissions for PIM role management
-
-### 📝 Development Note
-This module was developed with the assistance of AI tools (GitHub Copilot and Claude), combining AI-accelerated development with human expertise in Microsoft identity and security workflows.
-
-For detailed usage instructions, see the README.md file.
+## PIMActivation v1.2.1
+
+### � What's New
+- Enhanced automatic dependency resolution
+- Added -Force parameter for fully automated setup
+- Cleaner console output with reduced verbose noise
+- Improved error handling and user guidance
+
+### � Full Release Notes
+For complete release notes, changelog, and detailed information:
+- **GitHub Releases**: https://github.com/Noble-Effeciency13/PIMActivation/releases
+- **Changelog**: https://github.com/Noble-Effeciency13/PIMActivation/blob/main/CHANGELOG.md
+- **Documentation**: https://github.com/Noble-Effeciency13/PIMActivation/blob/main/README.md
+
+### � Getting Started
+```powershell
+Install-Module PIMActivation -Scope CurrentUser
+Start-PIMActivation
+```
+
+PowerShell module for Microsoft Entra ID Privileged Identity Management (PIM) role activations through a modern GUI interface.
 '@
             # Flag to indicate whether the module requires explicit user acceptance
             RequireLicenseAcceptance = $false

PIMActivation.psm1

@@ -1,4 +1,32 @@
 #Requires -Version 7.0
+#Requires -Modules @{
+    ModuleName = 'Microsoft.Graph.Authentication'
+    ModuleVersion = '2.29.0'
+}
+#Requires -Modules @{
+    ModuleName = 'Microsoft.Graph.Users'
+    ModuleVersion = '2.29.0'
+}
+#Requires -Modules @{
+    ModuleName = 'Microsoft.Graph.Identity.DirectoryManagement'
+    ModuleVersion = '2.29.0'
+}
+#Requires -Modules @{
+    ModuleName = 'Microsoft.Graph.Identity.Governance'
+    ModuleVersion = '2.29.0'
+}
+#Requires -Modules @{
+    ModuleName = 'Microsoft.Graph.Groups'
+    ModuleVersion = '2.29.0'
+}
+#Requires -Modules @{
+    ModuleName = 'Microsoft.Graph.Identity.SignIns'
+    ModuleVersion = '2.29.0'
+}
+#Requires -Modules @{
+    ModuleName = 'Az.Accounts'
+    ModuleVersion = '5.1.0'
+}
 
 # Set strict mode for better error handling
 Set-StrictMode -Version Latest
@@ -69,10 +97,12 @@ $script:AuthContextCompletionTime = $null
 # Module loading state for just-in-time loading
 $script:ModuleLoadingState = @{}
 $script:RequiredModuleVersions = @{
-    'Microsoft.Graph.Authentication' = '2.29.1'
-    'Microsoft.Graph.Users' = '2.29.1'
-    'Microsoft.Graph.Identity.DirectoryManagement' = '2.29.1'
-    'Microsoft.Graph.Identity.Governance' = '2.29.1'
+    'Microsoft.Graph.Authentication' = '2.29.0'
+    'Microsoft.Graph.Users' = '2.29.0'
+    'Microsoft.Graph.Identity.DirectoryManagement' = '2.29.0'
+    'Microsoft.Graph.Identity.Governance' = '2.29.0'
+    'Microsoft.Graph.Groups' = '2.29.0'
+    'Microsoft.Graph.Identity.SignIns' = '2.29.0'
     'Az.Accounts' = '5.1.0'
 }
 
@@ -81,26 +111,29 @@ $script:RequiredModuleVersions = @{
 #region Import Functions
 
 # Import all functions from subdirectories
-$functionFolders = @(
+$functionFolders = [System.Collections.ArrayList]::new()
+$null = $functionFolders.AddRange(@(
     'Authentication',
     'RoleManagement', 
     'UI',
     'Utilities'
-)
+))
 
 # Note: Profiles folder contains placeholder functions for planned features
-$functionFolders += 'Profiles'
+$null = $functionFolders.Add('Profiles')
 
 # Import private functions from organized folders
+# Temporarily suppress verbose output during function imports to reduce noise
+$originalVerbosePreference = $VerbosePreference
+$VerbosePreference = 'SilentlyContinue'
+
 foreach ($folder in $functionFolders) {
     $folderPath = Join-Path -Path "$script:ModuleRoot\Private" -ChildPath $folder
     if (Test-Path -Path $folderPath) {
-        Write-Verbose "Importing functions from $folder"
         $functions = Get-ChildItem -Path $folderPath -Filter '*.ps1' -File -ErrorAction SilentlyContinue
 
         foreach ($function in $functions) {
             try {
-                Write-Verbose "Importing $($function.Name)"
                 . $function.FullName
             }
             catch {
@@ -114,7 +147,6 @@ foreach ($folder in $functionFolders) {
 $privateRoot = Get-ChildItem -Path "$script:ModuleRoot\Private" -Filter '*.ps1' -File -ErrorAction SilentlyContinue
 foreach ($import in $privateRoot) {
     try {
-        Write-Verbose "Importing $($import.Name)"
         . $import.FullName
     }
     catch {
@@ -126,14 +158,16 @@ foreach ($import in $privateRoot) {
 $Public = @(Get-ChildItem -Path "$script:ModuleRoot\Public" -Filter '*.ps1' -File -ErrorAction SilentlyContinue)
 foreach ($import in $Public) {
     try {
-        Write-Verbose "Importing public function $($import.Name)"
         . $import.FullName
     }
     catch {
         Write-Error -Message "Failed to import function $($import.FullName): $_"
     }
 }
 
+# Restore original verbose preference
+$VerbosePreference = $originalVerbosePreference
+
 #endregion Import Functions
 
 #region Export Module Members
@@ -143,6 +177,14 @@ Export-ModuleMember -Function $Public.BaseName -Alias *
 
 #endregion Export Module Members
 
+#region Module Initialization
+
+# Dependencies are loaded on-demand when Start-PIMActivation is called
+# This ensures clean module loading and avoids import-time dependency issues
+# All dependency management is handled automatically by Start-PIMActivation
+
+#endregion Module Initialization
+
 #region Cleanup
 
 # Clean up variables

Private/Authentication/Clear-AuthenticationCache.ps1

@@ -59,9 +59,9 @@ function Clear-AuthenticationCache {
             $edgeCookies = Join-Path $env:LOCALAPPDATA "Microsoft\Edge\User Data\Default\Cookies"
             $chromeCookies = Join-Path $env:LOCALAPPDATA "Google\Chrome\User Data\Default\Cookies"
 
-            $browserPaths = @()
-            if (Test-Path $edgeCookies) { $browserPaths += "Edge" }
-            if (Test-Path $chromeCookies) { $browserPaths += "Chrome" }
+            $browserPaths = [System.Collections.ArrayList]::new()
+            if (Test-Path $edgeCookies) { $null = $browserPaths.Add("Edge") }
+            if (Test-Path $chromeCookies) { $null = $browserPaths.Add("Chrome") }
 
             if ($browserPaths.Count -gt 0) {
                 Write-Verbose "Browser cookie stores detected for: $($browserPaths -join ', ')"