Move getTarballCache() into fetchers::Settings #14368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps the tarball cache open across calls.
github-actions
bot
added
the
fetching
Ericson2314
reviewed
Nov 4, 2025
|
|
||
| namespace nix { | ||
|
|
||
| struct GitRepo; |
Member
There was a problem hiding this comment.
Any reason to not have this in fetchers too?
Ericson2314
approved these changes
Nov 4, 2025
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
Thanks for getting rid of a global variable, Eelco!
Ericson2314
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
fetcher::Settings::getTarballCache()caches theGitRepoobject, so this keeps the tarball cache open across calls.Cherry-picked from DeterminateSystems#49.
Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.