TimescaleDB container fails to restore Samba app 3.4.3

[DavidePrincipi]

Steps to reproduce

• Deploy NS8 Samba app version 3.4.3
• Attempt a restore of a domain controller using backup with TimescaleDB created in version 3.0.0

Expected behavior

• The restore process completes successfully and the DC is operational

Actual behavior

• The timescaledb container fails to restore correctly, leading to several errors (see below) and aborting the restoration process entirely.

• Notable errors include missing TimescaleDB internal relations/columns, failures on COPY operations for non-existent views, and missing functions in triggers:

    ERROR:  relation "_timescaledb_catalog.chunk_index" does not exist
    ERROR:  column "finalized" of relation "continuous_agg" does not exist
    ERROR:  cannot copy to view "bgw_job"
    ERROR:  relation "_timescaledb_config.bgw_job_id_seq" does not exist
    ERROR:  function _timescaledb_functions.insert_blocker() does not exist
  

• Restoration output excerpts:

    task/module/samba1/...: restore-module/60resume_state is starting
    Restore samba_audit data in TimescaleDB:
    Error sample:
    pg_restore: error: could not execute query: ERROR:  relation "_timescaledb_catalog.chunk_index" does not exist
    pg_restore: error: could not execute query: ERROR:  column "finalized" of relation "continuous_agg" does not exist
    pg_restore: error: COPY failed for table "bgw_job": ERROR:  cannot copy to view "bgw_job"
    pg_restore: error: could not execute query: ERROR:  relation "_timescaledb_config.bgw_job_id_seq" does not exist
    pg_restore: error: could not execute query: ERROR:  function _timescaledb_functions.insert_blocker() does not exist
    action "restore-module" status is "aborted" at step 60resume_state
  

Attachment

samba-restore.txt

Components

• NethServer 8
• Samba app version: 3.4.3
• TimescaleDB container (PostgreSQL 17.7, TimescaleDB extension docker.io image timescaledb:2.25.2-pg17)

See also

• Related logs and full output attached (see samba-restore.txt)
• Discussion https://mattermost.nethesis.it/nethesis/pl/38wiu7he5tnnmdh7318yw93s7r

[DavidePrincipi]

Workaround

Remove/rename the samba_audit.pgdump file under the state/ directory. Manually execute the restore action steps:

runagent -m samba1 ../actions/restore-module/60resume_state
runagent -m samba1 ../actions/restore-module/70update_routes_symlink
runagent -m samba1 ../actions/restore-module/80advertise_service
runagent -m samba1 ../actions/restore-module/80provision_metrics
runagent -m samba1 ../actions/restore-module/80start_amld
runagent -m samba1 ../actions/restore-module/90bind_user_domain

[DavidePrincipi]

In Testing Samba 3.4.4-dev.1

Test case 0

Test backup/restore of Samba with an instance that has undergone multiple in-place TimescaleDB version upgrades and a long history of data (months). NOTE: this has been already VERIFIED during development, at least in one case.

Test case 1

Test backup/restore of Samba without File Server, which has an empty TimescaleDB.

Test case 2

Test backup/restore of Samba DC + File Server, with enabled Samba Audit on some shares.

Test case 3

Test backup/restore of Samba File Server, joined to an external AD, with enabled Samba Audit on some shares.

[mrmarkuz]

Test case 1 - 3 verified

Note: I didn't find a good server that fulfills the requirements for test case 0 yet.