Final “2.x” interface. #215
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@klebba — You asked about a PR to show what the interface will look like. Here one is! This is just throwaway work since it’s pointing to a different PR, but I’ll keep recreating every time I make changes so that you can stay updated here. |
Collaborator
Author
|
The git diff shown in the |
theengineear
force-pushed
the
ready-2x-interface
branch
from
bc23055 to
69c8936
Compare
theengineear
force-pushed
the
ready-2x-interface
branch
3 times, most recently
from
56ae8dd to
c5a3540
Compare
Contributor
^ can we incorporate this somewhere? my thought is that the x-template would be a mime type |
theengineear
force-pushed
the
ready-2x-interface
branch
2 times, most recently
from
9460060 to
19367eb
Compare
theengineear
force-pushed
the
2x
branch
2 times, most recently
from
3c2943e to
5533a58
Compare
theengineear
commented
Aug 6, 2025
| // the parser is _very_ strict, we can make a lot of simplifying assumptions. | ||
| static #onToken( | ||
| // These areguments are passed in through a “bind”. | ||
| // These arguments are passed in through a “bind”. |
Collaborator
Author
There was a problem hiding this comment.
This is unrelated, just found a typo.
theengineear
commented
Aug 6, 2025
| node[name] = value; | ||
| } | ||
|
|
||
| // TODO: Future state here once “ifDefined” is gone. |
Collaborator
Author
There was a problem hiding this comment.
The future is now!
theengineear
force-pushed
the
2x
branch
2 times, most recently
from
42e2490 to
d7ddf41
Compare
* Removes “ifDefined” (previously just deprecated). * Removes “repeat” (previously just deprecated). * Removes some “future state” commentary (cleanup). Closes #314.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.