Describe the bug
Possible bug in the trough collector class (csp_solver_trough_collector_receiver.cpp) during the end gain calculations. In loop_optical_eta(), SolarAz is compared against 90 (degrees) but SolarAz has already been converted to radians. Code is likely always assuming sun is in southern sky, regardless of actual position.
Expected behavior
EndGain calculation should change depending on location of site relative to equator.
Change 90 to pi/2
Screenshots
Describe the bug
Possible bug in the trough collector class (csp_solver_trough_collector_receiver.cpp) during the end gain calculations. In loop_optical_eta(), SolarAz is compared against 90 (degrees) but SolarAz has already been converted to radians. Code is likely always assuming sun is in southern sky, regardless of actual position.
Expected behavior
EndGain calculation should change depending on location of site relative to equator.
Change 90 to pi/2
Screenshots
