Skip to content

Commit 73fb3e2

Browse files
committed
Merge branch 'fix-vtxcol-is-baked' into 'release/v1.2'
[REMIX-4580] Fix default values for isVertexColorBakedLighting See merge request lightspeedrtx/dxvk-remix-nv!1691
2 parents 3ce7f35 + 98b32fd commit 73fb3e2

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

public/include/remix/remix.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -722,7 +722,7 @@ namespace remix {
722722
textureAlphaOperation = 1 /* DxvkRtTextureOperation::SelectArg1 */;
723723
tFactor = 0XFFFFFFFF;
724724
isTextureFactorBlend = false;
725-
isVertexColorBakedLighting = false;
725+
isVertexColorBakedLighting = true;
726726
static_assert(sizeof remixapi_InstanceInfoBlendEXT == 96);
727727
}
728728
};

src/dxvk/rtx_render/rtx_materials.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ struct RtSurface {
291291
bool isAnimatedWater = false;
292292
bool isClipPlaneEnabled = false;
293293
bool isTextureFactorBlend = false;
294-
bool isVertexColorBakedLighting = false;
294+
bool isVertexColorBakedLighting = true;
295295
bool isMotionBlurMaskOut = false;
296296
bool skipSurfaceInteractionSpritesheetAdjustment = false;
297297
bool isInsideFrustum = false;
@@ -1600,7 +1600,7 @@ struct LegacyMaterialData {
16001600
uint32_t tFactor = 0xffffffff; // Value for D3DRS_TEXTUREFACTOR, default value of is opaque white
16011601
D3DMATERIAL9 d3dMaterial = {};
16021602
bool isTextureFactorBlend = false;
1603-
bool isVertexColorBakedLighting = false;
1603+
bool isVertexColorBakedLighting = true;
16041604

16051605
void setHashOverride(XXH64_hash_t hash) {
16061606
m_cachedHash = hash;

src/dxvk/rtx_render/rtx_remix_api.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -726,7 +726,7 @@ dxvk::ExternalDrawState dxvk::RemixAPIPrivateAccessor::toRtDrawState(const remix
726726
prototype.materialData.textureAlphaArg2Source = (RtTextureArgSource) extBlend->textureAlphaArg2Source;
727727
prototype.materialData.tFactor = extBlend->tFactor;
728728
prototype.materialData.isTextureFactorBlend = extBlend->isTextureFactorBlend;
729-
prototype.materialData.isVertexColorBakedLighting = (s_apiVersion >= REMIXAPI_VERSION_MAKE(0, 5, 2)) ? extBlend->isVertexColorBakedLighting : false;
729+
prototype.materialData.isVertexColorBakedLighting = (s_apiVersion >= REMIXAPI_VERSION_MAKE(0, 5, 2)) ? extBlend->isVertexColorBakedLighting : RtxOptions::vertexColorIsBakedLighting();
730730
prototype.materialData.blendMode.colorSrcFactor = (VkBlendFactor) extBlend->srcColorBlendFactor;
731731
prototype.materialData.blendMode.colorDstFactor = (VkBlendFactor) extBlend->dstColorBlendFactor;
732732
prototype.materialData.blendMode.colorBlendOp = (VkBlendOp) extBlend->colorBlendOp;

0 commit comments

Comments
 (0)