fix(compute-stack): disable self-hosted collector by default

Author: mikeyrcamp

deploy/stacks/nvcf-compute-plane/helmfile.d/02-nvca.yaml.gotmpl

@@ -90,7 +90,7 @@ helmDefaults:
 {{- $nvcaOp := dig "nvcaOperator" dict .Values.global }}
 {{- $selfManaged := dig "selfManaged" dict $nvcaOp }}
 {{- $otelCollector := dig "otelCollector" dict $selfManaged }}
-{{- $otelCollectorEnabled := dig "enabled" $computeObservabilityEnabled $otelCollector }}
+{{- $otelCollectorEnabled := dig "enabled" false $otelCollector }}
 {{- $defaultOTelCollectorImageRepository := printf "%s/%s/nvcf-otel-collector" .Values.global.image.registry .Values.global.image.repository }}
 {{- $otelCollectorImageRepository := dig "imageRepository" $defaultOTelCollectorImageRepository $otelCollector }}
 

deploy/stacks/nvcf-compute-plane/tests/observability-profile.sh

@@ -84,13 +84,9 @@ for profile in default disabled control compute all; do
   render_values "$profile" "$values"
 
   case "$profile" in
-    default|compute|all)
-      test "$(collector_enabled "$values")" = "true" ||
-        fail "$profile profile did not enable the NVCA collector"
-      ;;
-    disabled|control)
+    default|disabled|control|compute|all)
       test "$(collector_enabled "$values")" = "false" ||
-        fail "$profile profile enabled the NVCA collector"
+        fail "$profile profile enabled the self-managed NVCA collector by default"
       ;;
   esac
 done