Skip to content

Commit bd89567

Browse files
authored
feat(icms-translate): bump BYOO collector default CPU to 1000m (#1185)
Signed-off-by: shobham <shobham@nvidia.com>
1 parent 7da4dde commit bd89567

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/libraries/go/lib/pkg/icms-translate/translate/common/otel.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -263,12 +263,12 @@ func getCommonOTelEnvs(allEnvSet map[string]string, otelPodIPOverride string) []
263263
func GetDefaultContainerResourcesBYOO() corev1.ResourceRequirements {
264264
return corev1.ResourceRequirements{
265265
Requests: corev1.ResourceList{
266-
corev1.ResourceCPU: *resource.NewMilliQuantity(500, resource.DecimalSI), // 500m
267-
corev1.ResourceMemory: *resource.NewQuantity(1<<31, resource.BinarySI), // 2Gi
266+
corev1.ResourceCPU: *resource.NewMilliQuantity(1000, resource.DecimalSI), // 1000m
267+
corev1.ResourceMemory: *resource.NewQuantity(1<<31, resource.BinarySI), // 2Gi
268268
},
269269
Limits: corev1.ResourceList{
270-
corev1.ResourceCPU: *resource.NewMilliQuantity(500, resource.DecimalSI), // 500m
271-
corev1.ResourceMemory: *resource.NewQuantity(1<<31, resource.BinarySI), // 2Gi
270+
corev1.ResourceCPU: *resource.NewMilliQuantity(1000, resource.DecimalSI), // 1000m
271+
corev1.ResourceMemory: *resource.NewQuantity(1<<31, resource.BinarySI), // 2Gi
272272
},
273273
}
274274
}

src/libraries/go/lib/pkg/icms-translate/translate/common/otel_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -512,9 +512,9 @@ func TestNewOTelContainer(t *testing.T) {
512512
assert.Equal(t, []corev1.Capability{"NET_RAW"}, container.SecurityContext.Capabilities.Drop)
513513

514514
assert.NotNil(t, container.Resources)
515-
assert.Equal(t, "500m", container.Resources.Limits.Cpu().String())
515+
assert.Equal(t, "1", container.Resources.Limits.Cpu().String())
516516
assert.Equal(t, "2Gi", container.Resources.Limits.Memory().String())
517-
assert.Equal(t, "500m", container.Resources.Requests.Cpu().String())
517+
assert.Equal(t, "1", container.Resources.Requests.Cpu().String())
518518
assert.Equal(t, "2Gi", container.Resources.Requests.Memory().String())
519519

520520
assert.NotNil(t, container.ReadinessProbe)

0 commit comments

Comments
 (0)