feat: [ami] implement boot_first (#50)

This PR:

- Adds a proper `boot_first` implementation for AMI by matching boot
options on the alias field (`Pxe`, `Hdd`, `UefiHttp`) and moving the
matched entry to the front of the boot order. Previously this delegated
to the standard implementation which returned `NotSupported`.
- Refactors the duplicated system/boot options fetch logic into shared
helpers

Signed-off-by: Krish Dandiwala <kdandiwala@nvidia.com>

Author: krish-nvidia

src/ami.rs

@@ -517,7 +517,12 @@ impl Redfish for Bmc {
     }
 
     async fn boot_first(&self, target: Boot) -> Result<(), RedfishError> {
-        self.s.boot_first(target).await
+        let alias = match target {
+            Boot::Pxe => "Pxe",
+            Boot::HardDisk => "Hdd",
+            Boot::UefiHttp => "UefiHttp",
+        };
+        self.set_boot_order(alias).await
     }
 
     /// AMI BMC requires If-Match header for boot order changes
@@ -742,23 +747,7 @@ impl Redfish for Bmc {
         mac_address: &str,
     ) -> Result<Option<String>, RedfishError> {
         let mac = mac_address.to_uppercase();
-        let system = self.get_system().await?;
-
-        let boot_options_id =
-            system
-                .boot
-                .boot_options
-                .clone()
-                .ok_or_else(|| RedfishError::MissingKey {
-                    key: "boot.boot_options".to_string(),
-                    url: system.odata.odata_id.clone(),
-                })?;
-
-        let all_boot_options: Vec<BootOption> = self
-            .get_collection(boot_options_id)
-            .await
-            .and_then(|c| c.try_get::<BootOption>())?
-            .members;
+        let (system, all_boot_options) = self.get_system_and_boot_options().await?;
 
         let target = all_boot_options.iter().find(|opt| {
             let display = opt.display_name.to_uppercase();
@@ -971,19 +960,10 @@ impl Bmc {
         self.s.client.patch_with_if_match(&url, data).await
     }
 
-    /// Get expected and actual first boot option for checking boot order setup.
-    ///
-    /// AMI boot option format example:
-    /// DisplayName: "[Slot2]UEFI: HTTP IPv4 Nvidia Network Adapter - B8:E9:24:17:6D:72 P1"
-    /// BootOptionReference: "Boot0001"
-    ///
-    async fn get_expected_and_actual_first_boot_option(
+    async fn get_system_and_boot_options(
         &self,
-        boot_interface_mac: &str,
-    ) -> Result<(Option<String>, Option<String>), RedfishError> {
-        let mac = boot_interface_mac.to_uppercase();
+    ) -> Result<(ComputerSystem, Vec<BootOption>), RedfishError> {
         let system = self.get_system().await?;
-
         let boot_options_id =
             system
                 .boot
@@ -993,14 +973,68 @@ impl Bmc {
                     key: "boot.boot_options".to_string(),
                     url: system.odata.odata_id.clone(),
                 })?;
-
         let all_boot_options: Vec<BootOption> = self
             .get_collection(boot_options_id)
             .await
             .and_then(|c| c.try_get::<BootOption>())?
             .members;
+        Ok((system, all_boot_options))
+    }
+
+    /// Finds the first boot option matching the given alias and moves it to the front
+    /// of the boot order.
+    async fn set_boot_order(&self, alias: &str) -> Result<(), RedfishError> {
+        let (system, all_boot_options) = self.get_system_and_boot_options().await?;
+
+        let target = all_boot_options
+            .iter()
+            .find(|opt| opt.alias.as_deref() == Some(alias));
+
+        let target_ref = target
+            .ok_or_else(|| {
+                let all_names: Vec<_> = all_boot_options
+                    .iter()
+                    .map(|b| {
+                        format!(
+                            "{}: {} (alias={})",
+                            b.boot_option_reference,
+                            b.display_name,
+                            b.alias.as_deref().unwrap_or("none")
+                        )
+                    })
+                    .collect();
+                RedfishError::MissingBootOption(format!(
+                    "No boot option with alias {:?} found; available: {:#?}",
+                    alias, all_names
+                ))
+            })?
+            .boot_option_reference
+            .clone();
+
+        let mut boot_order = system.boot.boot_order;
+
+        if boot_order.first() == Some(&target_ref) {
+            return Ok(());
+        }
+
+        boot_order.retain(|id| id != &target_ref);
+        boot_order.insert(0, target_ref);
+        self.change_boot_order(boot_order).await
+    }
+
+    /// Get expected and actual first boot option for checking boot order setup.
+    ///
+    /// AMI boot option format example:
+    /// DisplayName: "[Slot2]UEFI: HTTP IPv4 Nvidia Network Adapter - B8:E9:24:17:6D:72 P1"
+    /// BootOptionReference: "Boot0001"
+    ///
+    async fn get_expected_and_actual_first_boot_option(
+        &self,
+        boot_interface_mac: &str,
+    ) -> Result<(Option<String>, Option<String>), RedfishError> {
+        let mac = boot_interface_mac.to_uppercase();
+        let (system, all_boot_options) = self.get_system_and_boot_options().await?;
 
-        // Find expected boot option display name (HTTP IPv4 with matching MAC)
         let expected_first_boot_option = all_boot_options
             .iter()
             .find(|opt| {