feat: add set_boot_override trait method with HttpBootUri support

This PR adds a new `BootOverride` struct and `Redfish::set_boot_override` trait method that exposes full Redfish Boot override support:
- `target` -- e.g. (`UefiHttp`, `Hdd`, etc...)
- `enabled` -- e.g. (`Once`, `Continuous`, `Disabled`)
- `mode` -- e.g. (`UEFI`, `Legacy`)
- `http_boot_uri` -- (an optional `ipxe.efi` URI, which allows us to override DHCP option 67).

The `boot_once`/`boot_first` paths now route through it internally, so existing callers keep their current behavior.

The purpose of this is for upcoming feature work: when `http_boot_uri` is set together with `target = UefiHttp`, the BMC pins the boot URL, and the host will UEFI HTTP boot from it *without* needing DHCP option 67 (which we currently set with `carbide-dhcp`). When `http_boot_uri` is None, the firmware falls back to option 67 per the UEFI HTTP Boot specification. The idea is we can start controlling the `ipxe.efi` boot URL via Redfish and not need to have `carbide-dhcp` populate it via option 67, reducing depdencencies on `carbide-dhcp` as the DHCP server.

Vendor support implemented (via standard Boot resource `PATCH`) for: `nvidia_gh200`, `nvidia_gbx00`, `nvidia_dpu`, `nvidia_viking`, `nvidia_gbswitch`, `hpe`, `supermicro`, `ami`.

Returning `NotSupported` (planned as follow-up PRs) for: `dell`, `lenovo`. Both BMCs require a vendor-specific BIOS-attribute path (`HttpDev1Uri` on iDRAC, XCC equivalent on Lenovo) -- they don't expose the standard `Boot.HttpBootUri` property.

...and then `standard` and `liteon_powershelf` will just stay `NotSupported`.

It currently returns `Result<Option<String>, RedfishError>` -- `Some(job_id)` is reserved for vendors that schedule the change via a BIOS settings job (e.g. future `dell` + `lenovo` impls); current vendors apply immediately and return `None`.

Also fixes a stray trailing space in `Systems/{id}/Settings ` and `Systems/{id}/SD ` URLs across the NVIDIA family vendors.

Tests added.

Signed-off-by: Chet Nichols III <chetn@nvidia.com>

Author: chet

src/ami.rs

@@ -27,7 +27,10 @@ use crate::{
     jsonmap,
     model::{
         account_service::ManagerAccount,
-        boot::{BootSourceOverrideEnabled, BootSourceOverrideTarget},
+        boot::{
+            BootOverride, BootSourceOverrideEnabled, BootSourceOverrideMode,
+            BootSourceOverrideTarget,
+        },
         certificate::Certificate,
         chassis::{Assembly, Chassis, NetworkAdapter},
         component_integrity::ComponentIntegrities,
@@ -586,8 +589,17 @@ impl Redfish for Bmc {
                 Boot::HardDisk => BootSourceOverrideTarget::Hdd,
                 Boot::UefiHttp => BootSourceOverrideTarget::UefiHttp,
             };
-            self.set_boot_override(override_target, BootSourceOverrideEnabled::Once)
-                .await
+            Redfish::set_boot_override(
+                self,
+                BootOverride {
+                    target: override_target,
+                    enabled: BootSourceOverrideEnabled::Once,
+                    mode: None,
+                    http_boot_uri: None,
+                },
+            )
+            .await?;
+            Ok(())
         })
     }
 
@@ -605,6 +617,39 @@ impl Redfish for Bmc {
         })
     }
 
+    /// AMI requires patching `/Systems/{id}` (NOT `/SD`) with an `If-Match` header.
+    fn set_boot_override<'a>(
+        &'a self,
+        settings: BootOverride,
+    ) -> crate::RedfishFuture<'a, Result<Option<String>, RedfishError>> {
+        Box::pin(async move {
+            let mut boot_data: HashMap<String, serde_json::Value> = HashMap::new();
+            boot_data.insert(
+                "BootSourceOverrideTarget".to_string(),
+                settings.target.to_string().into(),
+            );
+            boot_data.insert(
+                "BootSourceOverrideEnabled".to_string(),
+                settings.enabled.to_string().into(),
+            );
+            // AMI BMCs default to UEFI mode when the caller doesn't specify one.
+            let mode = settings.mode.unwrap_or(BootSourceOverrideMode::UEFI);
+            boot_data.insert(
+                "BootSourceOverrideMode".to_string(),
+                mode.to_string().into(),
+            );
+            if let Some(uri) = settings.http_boot_uri {
+                boot_data.insert("HttpBootUri".to_string(), uri.into());
+            }
+            let url = format!("Systems/{}", self.s.system_id());
+            self.s
+                .client
+                .patch_with_if_match(&url, HashMap::from([("Boot", boot_data)]))
+                .await?;
+            Ok(None)
+        })
+    }
+
     /// AMI BMC requires If-Match header for boot order changes
     fn change_boot_order<'a>(
         &'a self,
@@ -1124,28 +1169,6 @@ impl Redfish for Bmc {
 }
 
 impl Bmc {
-    /// AMI requires patching to /Systems/{id} (NOT /SD) with If-Match header
-    async fn set_boot_override(
-        &self,
-        override_target: BootSourceOverrideTarget,
-        override_enabled: BootSourceOverrideEnabled,
-    ) -> Result<(), RedfishError> {
-        let boot_data = HashMap::from([
-            ("BootSourceOverrideMode".to_string(), "UEFI".to_string()),
-            (
-                "BootSourceOverrideEnabled".to_string(),
-                override_enabled.to_string(),
-            ),
-            (
-                "BootSourceOverrideTarget".to_string(),
-                override_target.to_string(),
-            ),
-        ]);
-        let data = HashMap::from([("Boot", boot_data)]);
-        let url = format!("Systems/{}", self.s.system_id());
-        self.s.client.patch_with_if_match(&url, data).await
-    }
-
     async fn get_system_and_boot_options(
         &self,
     ) -> Result<(ComputerSystem, Vec<BootOption>), RedfishError> {

src/dell.rs

@@ -31,6 +31,7 @@ use crate::{
     jsonmap,
     model::{
         account_service::ManagerAccount,
+        boot::BootOverride,
         certificate::Certificate,
         chassis::{Assembly, Chassis, NetworkAdapter},
         component_integrity::ComponentIntegrities,
@@ -603,6 +604,21 @@ impl Redfish for Bmc {
         })
     }
 
+    /// Not yet implemented on Dell iDRAC. Dell does not expose the standard
+    /// Redfish `Boot.HttpBootUri` property; setting an HTTP boot URI on Dell
+    /// requires PATCHing the `HttpDev1Uri` and related BIOS attributes via
+    /// `/Systems/{id}/Bios/Settings`. Planned as a follow-up PR.
+    fn set_boot_override<'a>(
+        &'a self,
+        _settings: BootOverride,
+    ) -> crate::RedfishFuture<'a, Result<Option<String>, RedfishError>> {
+        Box::pin(async move {
+            Err(RedfishError::NotSupported(
+                "No Dell set_boot_override implementation".to_string(),
+            ))
+        })
+    }
+
     fn clear_tpm<'a>(&'a self) -> crate::RedfishFuture<'a, Result<(), RedfishError>> {
         Box::pin(async move {
             self.delete_job_queue().await?;

src/hpe.rs

@@ -27,6 +27,7 @@ use serde_json::Value;
 use crate::{
     model::{
         account_service::ManagerAccount,
+        boot::{BootOverride, BootSourceOverrideMode},
         certificate::Certificate,
         chassis::{Assembly, Chassis, NetworkAdapter},
         component_integrity::ComponentIntegrities,
@@ -475,6 +476,38 @@ impl Redfish for Bmc {
         Box::pin(async move { self.boot_first(target).await })
     }
 
+    fn set_boot_override<'a>(
+        &'a self,
+        settings: BootOverride,
+    ) -> crate::RedfishFuture<'a, Result<Option<String>, RedfishError>> {
+        Box::pin(async move {
+            let mut boot_data: HashMap<String, serde_json::Value> = HashMap::new();
+            boot_data.insert(
+                "BootSourceOverrideTarget".to_string(),
+                settings.target.to_string().into(),
+            );
+            boot_data.insert(
+                "BootSourceOverrideEnabled".to_string(),
+                settings.enabled.to_string().into(),
+            );
+            // HPE iLO defaults to UEFI mode when the caller doesn't specify one.
+            let mode = settings.mode.unwrap_or(BootSourceOverrideMode::UEFI);
+            boot_data.insert(
+                "BootSourceOverrideMode".to_string(),
+                mode.to_string().into(),
+            );
+            if let Some(uri) = settings.http_boot_uri {
+                boot_data.insert("HttpBootUri".to_string(), uri.into());
+            }
+            let url = format!("Systems/{}", self.s.system_id());
+            self.s
+                .client
+                .patch(&url, HashMap::from([("Boot", boot_data)]))
+                .await?;
+            Ok(None)
+        })
+    }
+
     fn clear_tpm<'a>(&'a self) -> crate::RedfishFuture<'a, Result<(), RedfishError>> {
         Box::pin(async move {
             let tpm = hpe::TpmAttributes {

src/lenovo.rs

@@ -34,6 +34,7 @@ use tokio::time::sleep;
 use tracing::debug;
 
 use crate::model::account_service::ManagerAccount;
+use crate::model::boot::BootOverride;
 use crate::model::certificate::Certificate;
 use crate::model::component_integrity::ComponentIntegrities;
 use crate::model::oem::lenovo::{BootSettings, FrontPanelUSB, LenovoBootOrder};
@@ -586,6 +587,21 @@ impl Redfish for Bmc {
         })
     }
 
+    /// Not yet implemented on Lenovo XCC. Like Dell, Lenovo does not expose
+    /// the standard Redfish `Boot.HttpBootUri` property; setting an HTTP boot
+    /// URI on Lenovo requires a vendor-specific BIOS attribute path. Planned
+    /// as a follow-up PR.
+    fn set_boot_override<'a>(
+        &'a self,
+        _settings: BootOverride,
+    ) -> crate::RedfishFuture<'a, Result<Option<String>, RedfishError>> {
+        Box::pin(async move {
+            Err(RedfishError::NotSupported(
+                "No Lenovo set_boot_override implementation".to_string(),
+            ))
+        })
+    }
+
     fn clear_tpm<'a>(&'a self) -> crate::RedfishFuture<'a, Result<(), RedfishError>> {
         Box::pin(async move {
             let mut body = HashMap::new();

src/lib.rs

@@ -23,6 +23,9 @@ use std::{collections::HashMap, fmt, future::Future, path::Path, pin::Pin, time:
 
 pub mod model;
 use model::account_service::ManagerAccount;
+pub use model::boot::{
+    BootOverride, BootSourceOverrideEnabled, BootSourceOverrideMode, BootSourceOverrideTarget,
+};
 pub use model::chassis::{Assembly, Chassis, NetworkAdapter};
 pub use model::ethernet_interface::EthernetInterface;
 pub use model::network_device_function::NetworkDeviceFunction;
@@ -284,6 +287,27 @@ pub trait Redfish: Send + Sync + 'static {
     /// Change boot order putting this target first
     fn boot_first<'a>(&'a self, target: Boot) -> RedfishFuture<'a, Result<(), RedfishError>>;
 
+    /// Set a boot source override, optionally including an HTTP boot URI.
+    ///
+    /// This is a lower-level alternative to [`Redfish::boot_once`] /
+    /// [`Redfish::boot_first`] that exposes the full Redfish `Boot` override
+    /// shape: `target`, `enabled` (`Once`/`Continuous`/`Disabled`), `mode`
+    /// (`UEFI`/`Legacy`), and `http_boot_uri`.
+    ///
+    /// When `target` is `UefiHttp` and `http_boot_uri` is `Some`, the BMC pins
+    /// the boot URL — the host will UEFI-HTTP-boot from that URI on the next
+    /// applicable boot without needing DHCP option 67. If `http_boot_uri` is
+    /// `None`, the firmware falls back to DHCP option 67 per the UEFI HTTP
+    /// Boot specification.
+    ///
+    /// Returns an optional job ID. Vendors that route the change through a
+    /// BIOS settings job schedule it to apply on next reboot and return the
+    /// job ID. Vendors that apply the change immediately return `None`.
+    fn set_boot_override<'a>(
+        &'a self,
+        settings: BootOverride,
+    ) -> RedfishFuture<'a, Result<Option<String>, RedfishError>>;
+
     /// Change boot order by setting boot array.
     fn change_boot_order<'a>(
         &'a self,

src/liteon_powershelf.rs

@@ -4,6 +4,7 @@ use std::{collections::HashMap, path::Path, time::Duration};
 use tokio::fs::File;
 
 use crate::model::account_service::ManagerAccount;
+use crate::model::boot::BootOverride;
 use crate::model::certificate::Certificate;
 use crate::model::component_integrity::ComponentIntegrities;
 use crate::model::oem::nvidia_dpu::{HostPrivilegeLevel, NicMode};
@@ -342,6 +343,17 @@ impl Redfish for Bmc {
         })
     }
 
+    fn set_boot_override<'a>(
+        &'a self,
+        _settings: BootOverride,
+    ) -> crate::RedfishFuture<'a, Result<Option<String>, RedfishError>> {
+        Box::pin(async move {
+            Err(RedfishError::NotSupported(
+                "Lite-on powershelf does not support boot source overrides".to_string(),
+            ))
+        })
+    }
+
     fn clear_tpm<'a>(&'a self) -> crate::RedfishFuture<'a, Result<(), RedfishError>> {
         Box::pin(async move { self.s.clear_tpm().await })
     }

src/model/boot.rs

@@ -113,6 +113,27 @@ pub enum BootSourceOverrideMode {
     InvalidValue,
 }
 
+impl fmt::Display for BootSourceOverrideMode {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        fmt::Debug::fmt(self, f)
+    }
+}
+
+/// Settings for a Redfish boot source override, applied via
+/// [`Redfish::set_boot_override`](crate::Redfish::set_boot_override).
+///
+/// `target` and `enabled` are required. `mode` is typically `UEFI` for modern
+/// systems and can be left `None` to keep the current mode unchanged. `http_boot_uri`
+/// only applies when `target` is `UefiHttp`; if `None`, the firmware obtains the
+/// boot URL from DHCP option 67 as specified by the UEFI HTTP Boot specification.
+#[derive(Debug, Clone)]
+pub struct BootOverride {
+    pub target: BootSourceOverrideTarget,
+    pub enabled: BootSourceOverrideEnabled,
+    pub mode: Option<BootSourceOverrideMode>,
+    pub http_boot_uri: Option<String>,
+}
+
 #[derive(Debug, Serialize, Deserialize, Clone, PartialEq, Eq)]
 pub enum TrustedModuleRequiredToBoot {
     Disabled,