Skip to content

Commit ff758ac

Browse files
committed
Address review: drop actions:read on public repo; document Linux-only CI and Windows (Git Bash)
1 parent b0d89d5 commit ff758ac

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

.github/workflows/secret-scan-pulse.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,8 @@
33
# SPDX-License-Identifier: Apache-2.0
44
#
55
# CI secret-scan enforcement via NVIDIA/security-workflows (Pulse).
6-
# Local advisory scanning is the secret-scan-trufflehog pre-commit hook.
6+
# Runs on Linux nv-gha-runners (Pulse Docker image + OIDC/Vault) — Linux-only by design.
7+
# The local secret-scan-trufflehog pre-commit hook is cross-platform (Linux/macOS/Windows via Git Bash).
78
# Pinned to a reviewed commit SHA; bump when NVIDIA/security-workflows consolidates.
89

910
name: Secret Scan (Pulse)
@@ -26,7 +27,6 @@ permissions:
2627
contents: read
2728
id-token: write # OIDC -> Vault -> nvcr.io image pull
2829
security-events: write # publish redacted SARIF to code scanning
29-
actions: read # required by upload-sarif
3030

3131
jobs:
3232
secret-scan:

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,10 +79,10 @@ warning reminding you to run `pre-commit install`.
7979

8080
Two complementary controls prevent accidental credential leakage:
8181

82-
- **Local pre-commit** (`secret-scan-trufflehog`, via `.pre-commit-config.yaml`): catches credentials before commit. Requires `trufflehog` on your PATH (the wrapper prints install commands if missing). Never commit a flagged secret; check with maintainers on false positives, and only use `git commit --no-verify` in exceptional, agreed cases.
83-
- **Server-side enforcement** (Pulse reusable workflow from `NVIDIA/security-workflows`, pinned by SHA): runs on `main`, `ctk-next`, and trusted copy-pr-bot branches, and blocks merges on verified secrets.
82+
- **Local pre-commit** (`secret-scan-trufflehog`, via `.pre-commit-config.yaml`): catches credentials before commit. Self-installing — no manual setup beyond `pre-commit install`; the hook downloads a pinned, checksum-verified `trufflehog` on first use. Never commit a flagged secret; check with maintainers on false positives, and only use `git commit --no-verify` in exceptional, agreed cases.
83+
- **Server-side enforcement** (Pulse reusable workflow from `NVIDIA/security-workflows`, pinned by SHA): runs on `main`, `ctk-next`, and trusted copy-pr-bot branches on Linux runners, and blocks merges on verified secrets.
8484

85-
The local hook is skipped on hosted pre-commit.ci (no `trufflehog` binary there); Pulse remains the authoritative CI enforcement.
85+
The local hook is skipped on hosted pre-commit.ci (no `trufflehog` binary there); Pulse remains the authoritative CI enforcement. On **Windows**, run the hook from a Git Bash / MSYS shell (bundled with Git for Windows), which the hook requires; the CI (Pulse) control is Linux-runner-only by design.
8686

8787

8888
## Signing Your Work

0 commit comments

Comments
 (0)