Skip to content

Commit ad923af

Browse files
lockwobrmchmarny
andcommitted
ix(bundler): v0.12 rc1 smoke-test follow-ups (#677)
Co-authored-by: Mark Chmarny <mchmarny@users.noreply.github.com>
1 parent db328c1 commit ad923af

1 file changed

Lines changed: 16 additions & 8 deletions

File tree

‎pkg/bundler/deployer/helm/templates/README.md.tmpl‎

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -78,13 +78,15 @@ helm upgrade --install {{ .Name }} {{ .Repository }}/{{ .ChartName }} \
7878
--version {{ .Version }} \
7979
-n {{ .Namespace }} --create-namespace \
8080
-f {{ .Name }}/values.yaml \
81+
-f {{ .Name }}/cluster-values.yaml \
8182
--wait --timeout 10m
8283
{{ else -}}
8384
helm upgrade --install {{ .Name }} {{ .ChartName }} \
8485
--repo {{ .Repository }} \
8586
--version {{ .Version }} \
8687
-n {{ .Namespace }} --create-namespace \
8788
-f {{ .Name }}/values.yaml \
89+
-f {{ .Name }}/cluster-values.yaml \
8890
--wait --timeout 10m
8991
{{ end -}}
9092
```
@@ -98,21 +100,27 @@ kubectl apply -f {{ .Name }}/manifests/
98100

99101
## Customization
100102

101-
Each component folder has its own `values.yaml` (static) and `cluster-values.yaml`
102-
(dynamic, per-cluster). Edit either before deploying:
103+
Each Helm component has two values files in its directory:
103104

104-
```bash
105-
vim NNN-<component-name>/values.yaml
106-
vim NNN-<component-name>/cluster-values.yaml
107-
```
105+
- `values.yaml` — resolved configuration from the recipe. Edit to override defaults:
106+
107+
```bash
108+
vim gpu-operator/values.yaml
109+
```
110+
111+
- `cluster-values.yaml` — install-time parameters. Any paths declared with
112+
`aicr bundle --dynamic <component>:<path>` are pulled out of `values.yaml`
113+
and placed here for you to fill in. The file is always created (empty if
114+
no dynamic paths were declared) and passed to `helm upgrade --install`
115+
alongside `values.yaml` by both `deploy.sh` and the per-component commands
116+
in the "Manual Installation" section above.
108117

109118
## Upgrade
110119

111120
Re-run the per-component install.sh to upgrade an already-installed release:
112121

113122
```bash
114-
cd NNN-<component-name>
115-
bash install.sh
123+
helm upgrade <component> <chart> --version <version> -n <namespace> -f <component>/values.yaml -f <component>/cluster-values.yaml --wait --timeout 10m
116124
```
117125

118126
## Uninstall

0 commit comments

Comments
 (0)