From be8b020a3dd9587b2d3bc0374c684e4ef83f20a8 Mon Sep 17 00:00:00 2001 From: Florent Benoit Date: Thu, 21 May 2026 13:45:22 +0200 Subject: [PATCH] fix(scripts): use portable lowercase in normalize_bool for Bash 3.2 Replace ${1,,} (Bash 4+) with printf/tr to fix "bad substitution" on macOS stock Bash 3.2, matching the existing pattern in gateway.sh. fixes https://github.com/NVIDIA/OpenShell/issues/1485 Signed-off-by: Florent Benoit --- tasks/scripts/gateway-vm.sh | 4 +++- tasks/scripts/package-snap.sh | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tasks/scripts/gateway-vm.sh b/tasks/scripts/gateway-vm.sh index 7228d718c..c8bfb58ee 100755 --- a/tasks/scripts/gateway-vm.sh +++ b/tasks/scripts/gateway-vm.sh @@ -58,7 +58,9 @@ normalize_arch() { } normalize_bool() { - case "${1,,}" in + local val + val="$(printf '%s' "$1" | tr '[:upper:]' '[:lower:]')" + case "${val}" in 1|true|yes|on) echo "true" ;; 0|false|no|off) echo "false" ;; *) diff --git a/tasks/scripts/package-snap.sh b/tasks/scripts/package-snap.sh index 8c299d352..c7f26e0ce 100755 --- a/tasks/scripts/package-snap.sh +++ b/tasks/scripts/package-snap.sh @@ -59,7 +59,9 @@ infer_snap_arch() { } normalize_bool() { - case "${1,,}" in + local val + val="$(printf '%s' "$1" | tr '[:upper:]' '[:lower:]')" + case "${val}" in 1 | true | yes | on) echo "1" ;; 0 | false | no | off) echo "0" ;; *)