-
Notifications
You must be signed in to change notification settings - Fork 650
Move to cuda 13.1 #6116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to cuda 13.1 #6116
Conversation
Signed-off-by: Janusz Lisiecki <[email protected]>
|
CI MESSAGE: [39761209]: BUILD STARTED |
Greptile OverviewGreptile SummaryThis PR upgrades DALI's build infrastructure from CUDA 13.0 to CUDA 13.1, making 13.1 the new default and officially supported version. Major changes:
The changes follow the established pattern used in previous CUDA version transitions, maintaining consistency with existing Dockerfiles (like CUDA 13.0). The fatbinary wrapper workaround for clang compatibility is preserved. All configuration files are properly synchronized. Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant build.sh
participant Docker
participant CUDA131_Dockerfile
participant Ubuntu_Repo
participant NVIDIA_Repo
User->>build.sh: Execute build with CUDA_VERSION=13.1
build.sh->>build.sh: Validate CUDA_VERSION (131 now accepted)
build.sh->>Docker: Build CUDA toolkit image
Docker->>CUDA131_Dockerfile: Use Dockerfile.cuda131.{arch}.deps
CUDA131_Dockerfile->>Ubuntu_Repo: Install base packages (wget, etc)
CUDA131_Dockerfile->>NVIDIA_Repo: Add CUDA repository (ubuntu2204)
CUDA131_Dockerfile->>NVIDIA_Repo: Install CUDA 13.1 packages (cuda-cudart-13-1, etc)
CUDA131_Dockerfile->>NVIDIA_Repo: Install nvJPEG2K 0.9.0.43
CUDA131_Dockerfile->>NVIDIA_Repo: Download nvcomp 5.1.0.21_cuda13
CUDA131_Dockerfile->>CUDA131_Dockerfile: Create fatbinary wrapper
CUDA131_Dockerfile-->>Docker: Return built toolkit image
Docker->>build.sh: Toolkit image ready
build.sh->>Docker: Build DALI with CUDA 13.1
Docker-->>User: DALI wheel with CUDA 13.1 support
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, no comments
|
CI MESSAGE: [39761209]: BUILD PASSED |
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A