Skip to content

Conversation

@JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Dec 7, 2025

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • moves to cuda 13.1

Additional information:

Affected modules and functionalities:

  • dockerfiles

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • the build for CUDA 13.x
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
      • compilation guide
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Janusz Lisiecki <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [39761209]: BUILD STARTED

@greptile-apps
Copy link

greptile-apps bot commented Dec 7, 2025

Greptile Overview

Greptile Summary

This PR upgrades DALI's build infrastructure from CUDA 13.0 to CUDA 13.1, making 13.1 the new default and officially supported version.

Major changes:

  • Created new Dockerfiles for CUDA 13.1 (both x86_64 and aarch64 architectures) based on Ubuntu 24.04
  • Updated CUDA toolkit packages from 13-0 to 13-1 versions (CUDA 13.1.80)
  • Upgraded nvcomp library from 5.0.0.6 to 5.1.0.21 for CUDA 13
  • Updated build.sh default from 13.0 to 13.1 and added validation for version 131
  • Updated documentation to reflect 13.1 as officially supported and deprecated 13.0

The changes follow the established pattern used in previous CUDA version transitions, maintaining consistency with existing Dockerfiles (like CUDA 13.0). The fatbinary wrapper workaround for clang compatibility is preserved. All configuration files are properly synchronized.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward version upgrades following established patterns. The new Dockerfiles closely mirror the existing CUDA 13.0 files with appropriate version updates. All configuration changes are consistent across files (build script validation, documentation, and defaults). The PR only affects build infrastructure and doesn't modify core functionality. Existing tests for CUDA 13.x builds will validate the changes.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
docker/Dockerfile.cuda131.x86_64.deps 5/5 New Dockerfile for CUDA 13.1 x86_64, updates base image to Ubuntu 24.04, CUDA packages to 13-1 versions, and nvcomp to 5.1.0.21
docker/Dockerfile.cuda131.aarch64.deps 5/5 New Dockerfile for CUDA 13.1 aarch64, mirrors x86_64 version with appropriate architecture-specific paths (sbsa vs x86_64)
docker/build.sh 5/5 Updated default CUDA version from 13.0 to 13.1, added 13.1 to validation list and help text
docs/compilation.rst 5/5 Updated documentation to reflect 13.1 as officially supported, deprecated 13.0, and changed default to 13.1

Sequence Diagram

sequenceDiagram
    participant User
    participant build.sh
    participant Docker
    participant CUDA131_Dockerfile
    participant Ubuntu_Repo
    participant NVIDIA_Repo
    
    User->>build.sh: Execute build with CUDA_VERSION=13.1
    build.sh->>build.sh: Validate CUDA_VERSION (131 now accepted)
    build.sh->>Docker: Build CUDA toolkit image
    Docker->>CUDA131_Dockerfile: Use Dockerfile.cuda131.{arch}.deps
    CUDA131_Dockerfile->>Ubuntu_Repo: Install base packages (wget, etc)
    CUDA131_Dockerfile->>NVIDIA_Repo: Add CUDA repository (ubuntu2204)
    CUDA131_Dockerfile->>NVIDIA_Repo: Install CUDA 13.1 packages (cuda-cudart-13-1, etc)
    CUDA131_Dockerfile->>NVIDIA_Repo: Install nvJPEG2K 0.9.0.43
    CUDA131_Dockerfile->>NVIDIA_Repo: Download nvcomp 5.1.0.21_cuda13
    CUDA131_Dockerfile->>CUDA131_Dockerfile: Create fatbinary wrapper
    CUDA131_Dockerfile-->>Docker: Return built toolkit image
    Docker->>build.sh: Toolkit image ready
    build.sh->>Docker: Build DALI with CUDA 13.1
    Docker-->>User: DALI wheel with CUDA 13.1 support
Loading

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [39761209]: BUILD PASSED

@rostan-t rostan-t self-assigned this Dec 8, 2025
@JanuszL JanuszL merged commit 9aa521d into NVIDIA:main Dec 9, 2025
6 checks passed
@JanuszL JanuszL deleted the cuda_13.1 branch December 9, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants