-
Notifications
You must be signed in to change notification settings - Fork 650
Remove old eager mode. #6113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old eager mode. #6113
Conversation
Signed-off-by: Michał Zientkiewicz <[email protected]>
| import nvidia.dali.types as _types | ||
| from nvidia.dali import _conditionals | ||
| from nvidia.dali._utils.eager_utils import _Classification, _transform_data_to_tensorlist | ||
| from nvidia.dali._debug_utils import _Classification, _transform_data_to_tensorlist |
Check notice
Code scanning / CodeQL
Cyclic import Note
nvidia.dali._debug_utils
| import nvidia.dali.tensors as _tensors | ||
| import nvidia.dali.types as _types | ||
|
|
||
| from nvidia.dali.external_source import _prep_data_for_feed_input |
Check notice
Code scanning / CodeQL
Cyclic import Note
nvidia.dali.external_source
Import of module
external_source
| """ | ||
|
|
||
| def __init__(self, data, type_name, arg_constant_len=-1): | ||
| from nvidia.dali._debug_mode import DataNodeDebug |
Check notice
Code scanning / CodeQL
Cyclic import Note
nvidia.dali._debug_mode
| @staticmethod | ||
| def _classify_data(data, type_name, arg_constant_len): | ||
| """Returns tuple (is_batch, device, unpacked data).""" | ||
| from nvidia.dali._debug_mode import DataNodeDebug |
Check notice
Code scanning / CodeQL
Cyclic import Note
nvidia.dali._debug_mode
Greptile OverviewGreptile SummaryThis PR removes the old experimental eager mode API from DALI, deleting over 3,100 lines of code including Python modules, C++ bindings, and tests. The key changes:
The refactoring is clean with no remaining references to removed code. The new Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User as User Code
participant FnInit as fn/__init__.py
participant DebugMode as _debug_mode.py
participant DebugUtils as _debug_utils.py (NEW)
participant Backend as backend_impl.cc
participant EagerOp as EagerOperator (kept)
Note over User,Backend: Before: Eager Mode Active
User->>FnInit: Import operator
FnInit->>Backend: Expose EagerOperator bindings
FnInit->>FnInit: Call _wrap_eager_op()
Backend->>Backend: Register TensorList arithmetic ops
User->>User: Use experimental.eager API
Note over User,Backend: After: Eager Mode Removed
User->>FnInit: Import operator
Note over FnInit: _wrap_eager_op() removed
Note over Backend: EagerOperator bindings removed
Note over Backend: TensorList arithmetic ops removed
Note over User,EagerOp: Debug Mode Still Works
User->>DebugMode: Use debug pipeline
DebugMode->>DebugUtils: Import _Classification, _transform_data_to_tensorlist
Note over DebugUtils: Functions extracted from eager_utils
DebugMode->>EagerOp: Call EagerOperator (internal use)
Note over EagerOp: Kept for debug mode
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 files reviewed, no comments
|
CI MESSAGE: [39676940]: BUILD STARTED |
Signed-off-by: Michał Zientkiewicz <[email protected]>
| @@ -0,0 +1,147 @@ | |||
| # Copyright (c) 2022-2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copied from the removed _eager_utils.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 files reviewed, no comments
|
CI MESSAGE: [39676940]: BUILD PASSED |
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
This PR removed the old experimental "eager" mode and tests for it.
Some small parts still used by pipeline debug mode were moved to a different file.
Additional information:
Affected modules and functionalities:
DALI eager.
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A