When adding invoices #462, we didn't handle the case of merging organizations: reassigning invoice relationships from one organization to another. While there is a test for this, it simply asserts that a foreign-key count is updated without additional context that this signals an unhandled relationship migration.
This hasn't yet been an issue since Org merges are infrequent, but it has the potential to bite us.
We'll resolve this by:
- Adding comments to explain why the foreign key test fails, and how to fix it
- Adding explicit tests for merging invoices with merged orgs
For bonus points, we could increase test coverage for the other 14 foreign key relationships that are impacted by a merge operation.
When adding invoices #462, we didn't handle the case of merging organizations: reassigning invoice relationships from one organization to another. While there is a test for this, it simply asserts that a foreign-key count is updated without additional context that this signals an unhandled relationship migration.
This hasn't yet been an issue since Org merges are infrequent, but it has the potential to bite us.
We'll resolve this by:
For bonus points, we could increase test coverage for the other 14 foreign key relationships that are impacted by a merge operation.