Store a players inventory and return it to the same slot doesnt work anymore for equipment slots

[Tintengold]

I tried both versions and while a return to the inventory slots still works, the equipment slots get ignored now.
It seems that items in these slots no longer have a "slot number" and instead just have {head: ; {chest: ; {legs: ; {feet: and offhand:
Furthermore they are no longer in the inventory nbt´s, so even if they still had numbers they couldn´t be dected with the current system.

[Tintengold]

I tested around a bit and i have a solution for the version with the chest as a storage so far.
By switching out the marker with an armor_stand it can now be used to store all equipment items.
Obviously marker would be better cause of lag, but i couldnt let it wear actual armor (seems like that is a /item limitation).
The armor_stand itself can also not have the marker tag for the same reasons. It just wouldnt work.

/summon minecraft:armor_stand ~ ~ ~{Invisible:true,Invulnerable:true,PersistenceRequired:true,NoBasePlate:true,NoGravity:true,ShowArms:true,Small:true,Tags:["inv_store","inv_new"]}

# copy over the equipment to the stand
execute as @e[type=minecraft:armor_stand,tag=inv_new] run item replace entity @s armor.head from entity @a[tag=inv_refund_target,limit=1] armor.head
execute as @e[type=minecraft:armor_stand,tag=inv_new] run item replace entity @s armor.chest from entity @a[tag=inv_refund_target,limit=1] armor.chest
execute as @e[type=minecraft:armor_stand,tag=inv_new] run item replace entity @s armor.legs from entity @a[tag=inv_refund_target,limit=1] armor.legs
execute as @e[type=minecraft:armor_stand,tag=inv_new] run item replace entity @s armor.feet from entity @a[tag=inv_refund_target,limit=1] armor.feet
execute as @e[type=minecraft:armor_stand,tag=inv_new] run item replace entity @s weapon.offhand from entity @a[tag=inv_refund_target,limit=1] weapon.offhand

and then when you load the items back to the player

# copy the equipment from the stand (i put this inside of the unnamed .mcfunction)
item replace entity @a[tag=inv_refund_target,limit=1] armor.head from entity @s armor.head
item replace entity @a[tag=inv_refund_target,limit=1] armor.chest from entity @s armor.chest
item replace entity @a[tag=inv_refund_target,limit=1] armor.legs from entity @s armor.legs
item replace entity @a[tag=inv_refund_target,limit=1] armor.feet from entity @s armor.feet
item replace entity @a[tag=inv_refund_target,limit=1] weapon.offhand from entity @s weapon.offhand

It isnt the most elegant solution, but it works with this band aid fix.

[EricristianBros]

Hi,

Thanks for submitting your issue.

Armor stands are laggy and should not be used for this prupose, markers can store the equipment data just fine (/data modify <enttiy> equipment from <entity> equipment). Im working on a PR that will include an updated version to store inventory in 1.21.5+ in storages, it just needs some final touches.

Sincerely,
Ericristian_bros