Crashes in repaint_file due to negative file_index on mc-4.8.33 / Fedora

[zyv]

I've noticed that on Fedora there are a couple of segfault reports in repaint_file:

• mc: string_file_size(): mc killed by SIGSEGV
• mc: mc_g_string_copy.isra.0(): mc killed by SIGSEGV

The crux seems to be that format_file is called with a negative file_index. Any idea how this can possibly come to be, @mc-worker ?

#2  0x000055b8d89a7956 in format_file (panel=panel@entry=0x55b8db466cc0, file_index=file_index@entry=-6, width=width@entry=88, attr=attr@entry=FATTR_MARKED, isstatus=isstatus@entry=0, field_length=field_length@entry=0x7ffdb4980884) at filemanager/panel.c:860
#3  0x000055b8d89a8398 in repaint_file (panel=panel@entry=0x55b8db466cc0, file_index=-6, attr=FATTR_MARKED) at filemanager/panel.c:980
#4  0x000055b8d89a84f9 in paint_dir (panel=panel@entry=0x55b8db466cc0) at filemanager/panel.c:1124

Thread no. 1 (15 frames)
 #0 string_file_size at filemanager/panel.c:550
 #1 format_file at filemanager/panel.c:860
 #2 repaint_file at filemanager/panel.c:980
 #3 paint_dir at filemanager/panel.c:1124
 #4 move_down at filemanager/panel.c:2212
 #6 chdir_other_panel at filemanager/panel.c:3106
 #7 panel_execute_cmd at filemanager/panel.c:3643
 #8 send_message at ../lib/widget/../../lib/widget/widget-common.h:255
 #9 group_handle_key at ../lib/widget/group.c:507
 #10 group_default_callback at ../lib/widget/group.c:637
 #11 dlg_key_event at ../lib/widget/dialog.c:252
 #12 dlg_process_event at ../lib/widget/dialog.c:539
 #13 frontend_dlg_run at ../lib/widget/dialog.c:321
 #14 dlg_run at ../lib/widget/dialog.c:573
 #15 do_nc at filemanager/filemanager.c:1826

Thread no. 1 (16 frames)
 #0 mc_g_string_copy.isra.0 at ../lib/glibcompat.c:248
 #1 string_file_name at filemanager/panel.c:497
 #2 format_file at filemanager/panel.c:860
 #3 repaint_file at filemanager/panel.c:980
 #4 paint_dir at filemanager/panel.c:1124
 #5 move_down at filemanager/panel.c:2212
 #7 chdir_other_panel at filemanager/panel.c:3106
 #8 panel_execute_cmd at filemanager/panel.c:3643
 #9 send_message at ../lib/widget/../../lib/widget/widget-common.h:255
 #10 group_handle_key at ../lib/widget/group.c:507
 #11 group_default_callback at ../lib/widget/group.c:637
 #12 dlg_key_event at ../lib/widget/dialog.c:252
 #13 dlg_process_event at ../lib/widget/dialog.c:539
 #14 frontend_dlg_run at ../lib/widget/dialog.c:321
 #15 dlg_run at ../lib/widget/dialog.c:573
 #16 do_nc at filemanager/filemanager.c:1826

[mc-worker]

mc: string_file_size(): mc killed by SIGSEGV is not reproducible for me. Probably, fixed in #4761.

mc: mc_g_string_copy.isra.0(): mc killed by SIGSEGV Unknown way how to reproduce.

[zyv]

I see. Thank you very much!