Skip to content

Commit 4a38a48

Browse files
mgreemgree
authored
[ci] drop redundant, flaky test (#34101)
#33871 adds a test in `types.slt` that flakes; #34095 fixed this, but some usage of `mz_now()` seems to be making things still flaky. The test is redundant with the parallel workload; I added it originally to find failures faster, but it doesn't seem worth it: it's too flaky, and we'll see failures in the parallel workload anyway. ### Motivation * This PR fixes a previously unreported bug. ### Checklist - [ ] This PR has adequate test coverage / QA involvement has been duly considered. ([trigger-ci for additional test/nightly runs](https://trigger-ci.dev.materialize.com/)) - [ ] This PR has an associated up-to-date [design doc](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/README.md), is a design doc ([template](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/00000000_template.md)), or is sufficiently small to not require a design. <!-- Reference the design in the description. --> - [ ] If this PR evolves [an existing `$T ⇔ Proto$T` mapping](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/command-and-response-binary-encoding.md) (possibly in a backwards-incompatible way), then it is tagged with a `T-proto` label. - [ ] If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label ([example](MaterializeInc/cloud#5021)). <!-- Ask in #team-cloud on Slack if you need help preparing the cloud PR. --> - [ ] If this PR includes major [user-facing behavior changes](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/guide-changes.md#what-changes-require-a-release-note), I have pinged the relevant PM to schedule a changelog post.
1 parent 2413ed5 commit 4a38a48

File tree

1 file changed

+0
-23
lines changed

1 file changed

+0
-23
lines changed

‎test/sqllogictest/types.slt‎

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1056,26 +1056,3 @@ Source materialize.public.t1
10561056
Target cluster: quickstart
10571057

10581058
EOF
1059-
1060-
# regression test from a randomly generated query that triggered a bug in column type unions
1061-
1062-
statement ok
1063-
CREATE TABLE "t-2"("c-0-uint8" uint8 not null, "c-1-mz_timestamp" mz_timestamp, "c-2-uint8" uint8, "c-3-uint4" uint4 not null, "c-4-numeric(38,3)" numeric(38, 3))
1064-
1065-
query T multiline
1066-
EXPLAIN OPTIMIZED PLAN AS VERBOSE TEXT FOR SELECT "t-2"."c-1-mz_timestamp", (((TIME '2:28:18.662888') + (INTERVAL '-42 years -29 days 63 seconds')) - (cast((TIME '15:42:7.524476') as interval))) - (TIME '22:19:14.412239'), "t-2"."c-4-numeric(38,3)", 92.17399200019122::numeric, list_cat(('{42, 30, 32, -8, -77}'::int list), (list_prepend(((~(1812081241::int)) # (bit_length('v26.0.0-dev.0'))), (list_cat(((('{43, -79, -82, -61, -68, -4, -74, 33, 58, 89, 75, 26, 32, -87, 86, 84, -72, -19, 32, -74}'::int list) || (list_prepend((643833376::int), ('{-54, 76, -11, 93, -7}'::int list)))) || (list_cat((list_append((list_prepend(((cast((TIMESTAMP '65400-10-12') as date)) - (cast(((cast(((DATE '91277-6-19') - ((TIME '12:39:7.558847') - (TIME '17:9:41.957019'))) as date)) - (cast((cast((cast((((TIME '15:22:18.671002') - ((TIME '22:33:56.971004') - (((TIME '0:8:33.902669') + ((TIMESTAMP '99999-12-31') - (TIMESTAMP '32881-5-7'))) - ((cast(("t-2"."c-1-mz_timestamp") as timestamp)) - (TIMESTAMP '10707-6-4'))))) + (((DATE '69879-12-21') + (TIME '16:37:0.805740')) - (TIMESTAMP '99999-12-31'))) as interval)) as time)) as interval))) as date))), ('{88, -27, 35, -5, 7, -65, -36, 31, -62, -15, -97, -62, 29, -55, 38, 41, -20, -25, 86, -46}'::int list))), (bit_length('bar')))), (list_prepend(((DATE '97905-11-25') - (cast((TIMESTAMP '32380-9-2') as date))), (list_cat((list_append((list_append((list_cat(('{60}'::int list), ('{-51}'::int list))), ((DATE '38037-4-24') - (cast(((cast((((TIMESTAMP '50016-6-26') + (cast(((TIME '21:19:52.524361') - (INTERVAL '35 days 80 seconds')) as interval))) + ((TIME '7:21:3.901932') - ((cast((((DATE '99999-12-31') + (TIME '2:32:20.53752')) - (cast((mz_now()) as timestamp))) as time)) + ((TIMESTAMP '45837-10-25') - (TIMESTAMP '66847-1-26'))))) as date)) + ((cast((INTERVAL '1 MINUTE') as time)) - ((TIME '15:13:11.375670') - (INTERVAL '1 MINUTE')))) as date))))), (-24090::int))), (list_append(('{83, 82, -97, 99, -59}'::int list), (char_length((("t-2"."c-4-numeric(38,3)") + (("t-2"."c-4-numeric(38,3)") - (("t-2"."c-4-numeric(38,3)") + ("t-2"."c-4-numeric(38,3)")))) || (cast(('{"key0": "94"}'::jsonb) as text))))))))))))), (list_append((list_append(('{60}'::int list), ((-127::int) / (-54::int)))), (bit_length('hJ0o3JZ70D'))))))))), list_append(('{97}'::int list), (4::int)), mod((-664621.2288346319::float4), (1.0::float4)), '{key0 => -73}'::map[text=>text], AVG("t-2"."c-2-uint8") OVER (PARTITION BY "t-2"."c-0-uint8" ORDER BY "t-2"."c-3-uint4") FROM "t-2" WHERE True UNION ALL SELECT "t-2"."c-1-mz_timestamp", (((TIME '2:28:18.662888') + (INTERVAL '-42 years -29 days 63 seconds')) - (cast((TIME '15:42:7.524476') as interval))) - (TIME '22:19:14.412239'), "t-2"."c-4-numeric(38,3)", 92.17399200019122::numeric, list_cat(('{42, 30, 32, -8, -77}'::int list), (list_prepend(((~(1812081241::int)) # (bit_length('v26.0.0-dev.0'))), (list_cat(((('{43, -79, -82, -61, -68, -4, -74, 33, 58, 89, 75, 26, 32, -87, 86, 84, -72, -19, 32, -74}'::int list) || (list_prepend((643833376::int), ('{-54, 76, -11, 93, -7}'::int list)))) || (list_cat((list_append((list_prepend(((cast((TIMESTAMP '65400-10-12') as date)) - (cast(((cast(((DATE '91277-6-19') - ((TIME '12:39:7.558847') - (TIME '17:9:41.957019'))) as date)) - (cast((cast((cast((((TIME '15:22:18.671002') - ((TIME '22:33:56.971004') - (((TIME '0:8:33.902669') + ((TIMESTAMP '99999-12-31') - (TIMESTAMP '32881-5-7'))) - ((cast(("t-2"."c-1-mz_timestamp") as timestamp)) - (TIMESTAMP '10707-6-4'))))) + (((DATE '69879-12-21') + (TIME '16:37:0.805740')) - (TIMESTAMP '99999-12-31'))) as interval)) as time)) as interval))) as date))), ('{88, -27, 35, -5, 7, -65, -36, 31, -62, -15, -97, -62, 29, -55, 38, 41, -20, -25, 86, -46}'::int list))), (bit_length('bar')))), (list_prepend(((DATE '97905-11-25') - (cast((TIMESTAMP '32380-9-2') as date))), (list_cat((list_append((list_append((list_cat(('{60}'::int list), ('{-51}'::int list))), ((DATE '38037-4-24') - (cast(((cast((((TIMESTAMP '50016-6-26') + (cast(((TIME '21:19:52.524361') - (INTERVAL '35 days 80 seconds')) as interval))) + ((TIME '7:21:3.901932') - ((cast((((DATE '99999-12-31') + (TIME '2:32:20.53752')) - (cast((mz_now()) as timestamp))) as time)) + ((TIMESTAMP '45837-10-25') - (TIMESTAMP '66847-1-26'))))) as date)) + ((cast((INTERVAL '1 MINUTE') as time)) - ((TIME '15:13:11.375670') - (INTERVAL '1 MINUTE')))) as date))))), (-24090::int))), (list_append(('{83, 82, -97, 99, -59}'::int list), (char_length((("t-2"."c-4-numeric(38,3)") + (("t-2"."c-4-numeric(38,3)") - (("t-2"."c-4-numeric(38,3)") + ("t-2"."c-4-numeric(38,3)")))) || (cast(('{"key0": "94"}'::jsonb) as text))))))))))))), (list_append((list_append(('{60}'::int list), ((-127::int) / (-54::int)))), (bit_length('hJ0o3JZ70D'))))))))), list_append(('{97}'::int list), (4::int)), mod((-664621.2288346319::float4), (1.0::float4)), '{key0 => -73}'::map[text=>text], AVG("t-2"."c-2-uint8") OVER (PARTITION BY "t-2"."c-0-uint8" ORDER BY "t-2"."c-3-uint4") FROM "t-2" WHERE False LIMIT 35;
1067-
----
1068-
Explained Query:
1069-
Finish limit=35 output=[#0..=#8]
1070-
Project (#3, #9, #4, #10, #7, #11..=#13, #8)
1071-
Map (record_get[1](#1), record_get[1](#2), record_get[4](#2), record_get[0](#1), record_get[0](#5), ([42, 30, 32, -8, -77] || (-1812081202 || (([43, -79, -82, -61, -68, -4, -74, 33, 58, 89, 75, 26, 32, -87, 86, 84, -72, -19, 32, -74, 643833376, -54, 76, -11, 93, -7] || ((((+65400-10-12 - timestamp_to_date((+91277-06-19 - time_to_interval(interval_to_time(time_to_interval(((15:22:18.671002 - (22:33:56.971004 - (00:08:33.902669 - (mz_timestamp_to_timestamp(#3{"c-1-mz_timestamp"}) - +10707-06-04 00:00:00)))) + -264026719:22:59.19426))))))) || [88, -27, 35, -5, 7, -65, -36, 31, -62, -15, -97, -62, 29, -55, 38, 41, -20, -25, 86, -46]) || 24) || (23932598 || ([60, -51, -4375302, -24090] || ([83, 82, -97, 99, -59] || char_length((numeric_to_text((#4{"c-4-numeric(38,3)"} + (#4{"c-4-numeric(38,3)"} - (#4{"c-4-numeric(38,3)"} + #4{"c-4-numeric(38,3)"})))) || "{\"key0\":\"94\"}"))))))) || [60, 2, 80]))), (record_get[1](#5) / bigint_to_numeric(case when (#6 = 0) then null else #6 end)), -11:32:00.273827, 92.17399200019122, [97, 4], -0.25, {key0: "-73"})
1072-
FlatMap unnest_list(#0)
1073-
Project (#1)
1074-
Reduce group_by=[#0] aggregates=[fused_window_agg(row(row(row(#0, #1, #2, #3, #4), row(#2{"c-2-uint8"}, #2{"c-2-uint8"})), #3{"c-3-uint4"}))]
1075-
ReadStorage materialize.public.t-2
1076-
1077-
Source materialize.public.t-2
1078-
1079-
Target cluster: quickstart
1080-
1081-
EOF

0 commit comments

Comments
 (0)