Merge pull request #34090 from petrosagg/fix-avro-spec-link

update url of current avro spec

Author: petrosagg

doc/user/content/sql/create-sink/kafka.md

@@ -184,7 +184,7 @@ When using a Confluent Schema Registry:
     and the value to the registry.
 
   * You can specify the
-    [fullnames](https://avro.apache.org/docs/current/specification/#names) for the
+    [fullnames](https://avro.apache.org/docs/++version++/specification/#names) for the
     Avro schemas Materialize generates using the `AVRO KEY FULLNAME` and `AVRO
     VALUE FULLNAME` [syntax](#syntax).
 

doc/user/content/sql/create-source/_index.md

@@ -43,15 +43,15 @@ The _latest_ schema is retrieved using the [`TopicNameStrategy`](https://docs.co
 
 ##### Schema evolution
 
-As long as the writer schema changes in a [compatible way](https://avro.apache.org/docs/current/spec.html#Schema+Resolution), Materialize will continue using the original reader schema definition by mapping values from the new to the old schema version. To use the new version of the writer schema in Materialize, you need to **drop and recreate** the source.
+As long as the writer schema changes in a [compatible way](https://avro.apache.org/docs/++version++/specification/#schema-resolution), Materialize will continue using the original reader schema definition by mapping values from the new to the old schema version. To use the new version of the writer schema in Materialize, you need to **drop and recreate** the source.
 
 ##### Name collision
 
 To avoid [case-sensitivity](/sql/identifiers/#case-sensitivity) conflicts with Materialize identifiers, we recommend double-quoting all field names when working with Avro-formatted sources.
 
 ##### Supported types
 
-Materialize supports all [Avro types](https://avro.apache.org/docs/current/spec.html), _except for_ recursive types and union types in arrays.
+Materialize supports all [Avro types](https://avro.apache.org/docs/++version++/specification/), _except for_ recursive types and union types in arrays.
 
 ### JSON
 

misc/python/materialize/data_ingest/data_type.py

@@ -36,7 +36,7 @@ class Backend(Enum):
 
 
 class DataType:
-    """As supported by Avro: https://avro.apache.org/docs/1.11.1/specification/_print/"""
+    """As supported by Avro: https://avro.apache.org/docs/++version++/specification/_print/"""
 
     @staticmethod
     def random_value(

src/avro/src/lib.rs

@@ -96,7 +96,7 @@
 //!
 //! For more information about schemas and what kind of information you can encapsulate in them,
 //! please refer to the appropriate section of the
-//! [Avro Specification](https://avro.apache.org/docs/current/spec.html#schemas).
+//! [Avro Specification](https://avro.apache.org/docs/++version++/specification/#schema-declaration).
 //!
 //! # Writing data
 //!
@@ -271,7 +271,7 @@
 //! The library will also automatically perform schema resolution while reading the data.
 //!
 //! For more information about schema compatibility and resolution, please refer to the
-//! [Avro Specification](https://avro.apache.org/docs/current/spec.html#schemas).
+//! [Avro Specification](https://avro.apache.org/docs/++version++/specification/#schema-declaration).
 //!
 //! There are two ways to handle deserializing Avro data in Rust, as you can see below.
 //!

src/avro/src/schema.rs

@@ -112,7 +112,7 @@ impl std::error::Error for ParseSchemaError {}
 
 /// Represents an Avro schema fingerprint
 /// More information about Avro schema fingerprints can be found in the
-/// [Avro Schema Fingerprint documentation](https://avro.apache.org/docs/current/spec.html#schema_fingerprints)
+/// [Avro Schema Resolution documentation](https://avro.apache.org/docs/++version++/specification/#schema-resolution)
 #[derive(Debug)]
 pub struct SchemaFingerprint {
     pub bytes: Vec<u8>,
@@ -186,11 +186,11 @@ pub enum SchemaPiece {
     Date,
     /// An `Int64` Avro schema with a semantic type being milliseconds since the unix epoch.
     ///
-    /// <https://avro.apache.org/docs/current/spec.html#Timestamp+%28millisecond+precision%29>
+    /// <https://avro.apache.org/docs/++version++/specification/#time_ms>
     TimestampMilli,
     /// An `Int64` Avro schema with a semantic type being microseconds since the unix epoch.
     ///
-    /// <https://avro.apache.org/docs/current/spec.html#Timestamp+%28microsecond+precision%29>
+    /// <https://avro.apache.org/docs/++version++/specification/#time-microsecond-precision>
     TimestampMicro,
     /// A `bytes` or `fixed` Avro schema with a logical type of `decimal` and
     /// the specified precision and scale.
@@ -350,7 +350,7 @@ impl SchemaPiece {
 
 /// Represents any valid Avro schema
 /// More information about Avro schemas can be found in the
-/// [Avro Specification](https://avro.apache.org/docs/current/spec.html#schemas)
+/// [Avro Specification](https://avro.apache.org/docs/++version++/specification/#schema-declaration)
 #[derive(Clone, PartialEq)]
 pub struct Schema {
     pub(crate) named: Vec<NamedSchemaPiece>,
@@ -527,7 +527,7 @@ impl<'a> From<&'a Schema> for SchemaKind {
 /// `aliases` can also be defined, to facilitate schema evolution.
 ///
 /// More information about schema names can be found in the
-/// [Avro specification](https://avro.apache.org/docs/current/spec.html#names)
+/// [Avro specification](https://avro.apache.org/docs/++version++/specification/#names)
 #[derive(Clone, Debug, PartialEq)]
 pub struct Name {
     pub name: String,
@@ -598,7 +598,7 @@ pub type Documentation = Option<String>;
 impl Name {
     /// Reports whether the given string is a valid Avro name.
     ///
-    /// See: <https://avro.apache.org/docs/1.11.1/specification/#names>
+    /// See: <https://avro.apache.org/docs/++version++/specification/#names>
     pub fn is_valid(name: &str) -> bool {
         static MATCHER: LazyLock<Regex> =
             LazyLock::new(|| Regex::new(r"(^[A-Za-z_][A-Za-z0-9_]*)$").unwrap());
@@ -708,7 +708,7 @@ impl Name {
     /// Return the `fullname` of this `Name`
     ///
     /// More information about fullnames can be found in the
-    /// [Avro specification](https://avro.apache.org/docs/current/spec.html#names)
+    /// [Avro specification](https://avro.apache.org/docs/++version++/specification/#names)
     pub fn fullname(&self, default_namespace: &str) -> FullName {
         FullName::from_parts(&self.name, self.namespace.as_deref(), default_namespace)
     }
@@ -1263,7 +1263,7 @@ impl SchemaParser {
     /// avro ones are documented at [Avro][2].
     ///
     /// [1]: https://debezium.io/docs/connectors/mysql/#temporal-values
-    /// [2]: https://avro.apache.org/docs/1.9.0/spec.html
+    /// [2]: https://avro.apache.org/docs/++version++/specification/
     fn parse_long(complex: &Map<String, Value>) -> Result<SchemaPiece, AvroError> {
         const AVRO_MILLI_TS: &str = "timestamp-millis";
         const AVRO_MICRO_TS: &str = "timestamp-micros";
@@ -1380,18 +1380,16 @@ impl Schema {
     /// Converts `self` into its [Parsing Canonical Form].
     ///
     /// [Parsing Canonical Form]:
-    /// https://avro.apache.org/docs/1.8.2/spec.html#Parsing+Canonical+Form+for+Schemas
+    /// https://avro.apache.org/docs/++version++/specification#parsing-canonical-form-for-schemas
     pub fn canonical_form(&self) -> String {
         let json = serde_json::to_value(self).unwrap();
         parsing_canonical_form(&json)
     }
 
-    /// Generate [fingerprint] of Schema's [Parsing Canonical Form].
+    /// Generate fingerprint of Schema's [Parsing Canonical Form].
     ///
     /// [Parsing Canonical Form]:
-    /// https://avro.apache.org/docs/1.8.2/spec.html#Parsing+Canonical+Form+for+Schemas
-    /// [fingerprint]:
-    /// https://avro.apache.org/docs/current/spec.html#schema_fingerprints
+    /// https://avro.apache.org/docs/++version++/specification#parsing-canonical-form-for-schemas
     pub fn fingerprint<D: Digest>(&self) -> SchemaFingerprint {
         let mut d = D::new();
         d.update(self.canonical_form());
@@ -2153,7 +2151,7 @@ impl<'a> Serialize for RecordFieldSerContext<'a> {
 }
 
 /// Parses a **valid** avro schema into the Parsing Canonical Form.
-/// <https://avro.apache.org/docs/1.8.2/spec.html#Parsing+Canonical+Form+for+Schemas>
+/// <https://avro.apache.org/docs/++version++/specification#parsing-canonical-form-for-schemas>
 fn parsing_canonical_form(schema: &serde_json::Value) -> String {
     pcf(schema, "", false)
 }

src/avro/src/types.rs

@@ -92,7 +92,7 @@ impl From<Scalar> for Value {
 
 /// Represents any valid Avro value
 /// More information about Avro values can be found in the
-/// [Avro Specification](https://avro.apache.org/docs/current/spec.html#schemas)
+/// [Avro Specification](https://avro.apache.org/docs/++version++/specification/#schema-declaration)
 #[derive(Clone, Debug, PartialEq)]
 pub enum Value {
     // Fixed-length types
@@ -353,7 +353,7 @@ impl ToAvro for JsonValue {
 impl Value {
     /// Validate the value against the given [Schema](../schema/enum.Schema.html).
     ///
-    /// See the [Avro specification](https://avro.apache.org/docs/current/spec.html)
+    /// See the [Avro specification](https://avro.apache.org/docs/++version++/specification/)
     /// for the full set of rules of schema validation.
     pub fn validate(&self, schema: SchemaNode) -> bool {
         match (self, schema.inner) {

src/avro/tests/schema.rs

@@ -354,7 +354,7 @@ static VALID_LOGICAL_TYPES: LazyLock<Vec<(&'static str, Value)>> = LazyLock::new
     ]
 });
 
-// From https://avro.apache.org/docs/current/spec.html#Logical+Types
+// From https://avro.apache.org/docs/++version++/specification/#logical-types
 // "Language implementations must ignore unknown logical types when reading, and should use the
 //  underlying Avro type. If a logical type is invalid, for example a decimal with scale greater
 //  than its precision, then implementations should ignore the logical type and use the underlying

src/interchange/src/avro.rs

@@ -78,7 +78,7 @@ mod tests {
     ///
     /// Complete list of primitive types in test, also found in this
     /// documentation:
-    /// https://avro.apache.org/docs/current/spec.html#schemas
+    /// https://avro.apache.org/docs/++version++/specification/#primitive-types
     fn test_diff_pair_to_avro_primitive_types() -> anyhow::Result<()> {
         use numeric::Numeric;
         // Data to be used later in assertions.