ci: update golangci-lint to v2.9

Author: MacroPower

.github/workflows/validate.yaml

@@ -3,7 +3,7 @@ name: validate
 on:
   push:
     branches:
-      - 'main'
+      - "main"
   pull_request:
 
 permissions:
@@ -59,4 +59,4 @@ jobs:
       - name: Run golangci-lint
         uses: golangci/golangci-lint-action@v9
         with:
-          version: v2.7
+          version: v2.9

.golangci.yaml

@@ -59,6 +59,7 @@ linters:
     - gocheckcompilerdirectives
     - goconst
     - gocritic
+    # - godoclint
     - godot
     - goprintffuncname
     - gosec
@@ -70,10 +71,12 @@ linters:
     - inamedparam
     - ineffassign
     - intrange
-    - ireturn
+    - iotamixing
+    # - ireturn
     - makezero
     - mirror
     - misspell
+    - modernize
     - musttag
     - nakedret
     - nestif
@@ -82,15 +85,15 @@ linters:
     - nilnil
     - noctx
     - noinlineerr
-    - nolintlint
+    # - nolintlint
     - nonamedreturns
     - nosprintfhostport
     - paralleltest
     - perfsprint
     - prealloc
     - predeclared
     - reassign
-    - recvcheck
+    # - recvcheck
     - revive
     - sloglint
     - staticcheck
@@ -124,6 +127,7 @@ linters:
       disable:
         - assign-exclusive
         - if
+        - err
 
     unused:
       field-writes-are-uses: false
@@ -161,6 +165,17 @@ linters:
       disabled-checks:
         - unnamedResult
         - singleCaseSwitch
+      settings:
+        hugeParam:
+          sizeThreshold: 256
+
+    # godoclint:
+    #   default: all
+    #   disable:
+    #     - require-pkg-doc
+    #   options:
+    #     max-len:
+    #       length: 80
 
     godot:
       scope: all
@@ -178,7 +193,6 @@ linters:
         - os.RemoveAll
 
     grouper:
-      const-require-single-const: true
       import-require-single-import: true
       var-require-single-var: true
 
@@ -197,6 +211,9 @@ linters:
           disabled: true
         - name: max-public-structs
           disabled: true
+        - name: nested-structs
+          exclude:
+            - "**/*_test.go"
         # Needed for future use.
         - name: unused-receiver
           disabled: true
@@ -220,6 +237,8 @@ linters:
         # Requires default cases.
         - name: enforce-switch-style
           disabled: true
+        - name: unhandled-error
+          disabled: true
 
     depguard:
       rules:
@@ -246,6 +265,10 @@ linters:
           - godot
           - gosec
           - gosmopolitan
+          - prealloc
+          - godoclint
+      - path: _test\.go
+        text: "fieldalignment:"
       - source: "= `"
         linters:
           - grouper

cmd/kclipper/commands/root_test.go

@@ -53,7 +53,7 @@ func TestRunCmd(t *testing.T) {
 }
 
 func BenchmarkRun(b *testing.B) {
-	for range b.N {
+	for b.Loop() {
 		tc := commands.NewRootCmd("bench_run", "", "")
 		stdout := &bytes.Buffer{}
 		stderr := &bytes.Buffer{}

pkg/crd/crd_kcl.go

@@ -68,6 +68,7 @@ func (s *KCLPackage) GenerateC(ctx context.Context) error {
 			merr = multierror.Append(merr, err)
 		}
 	}
+
 	if merr != nil {
 		return fmt.Errorf("failed to generate KCL from CRDs: %w", merr)
 	}
@@ -101,6 +102,7 @@ func (s *KCLPackage) writeToKCLSchema(uCRD *unstructured.Unstructured) error {
 			merr = multierror.Append(merr, fmt.Errorf("%s: %w", v.GetAPIVersion(), err))
 		}
 	}
+
 	if merr != nil {
 		return multierror.Prefix(merr, ErrGenerateKCL.Error()+":") //nolint:wrapcheck // Multierror
 	}

pkg/helm/chart_data.go

@@ -67,6 +67,7 @@ func (c *Chart) Template(ctx context.Context) ([]*unstructured.Unstructured, err
 	if c.TemplateOpts.Timeout > 0 {
 		ctx, cancel = context.WithTimeout(ctx, c.TemplateOpts.Timeout)
 	}
+
 	defer cancel()
 
 	pulledChart, err := c.Client.Pull(ctx,

pkg/helm/chart_files.go

@@ -91,6 +91,7 @@ func (c *ChartFiles) GetValuesJSONSchema(gen JSONSchemaGenerator, match func(str
 			if err != nil {
 				return fmt.Errorf("get relative path: %w", err)
 			}
+
 			// Use the relative path to match against the provided filter.
 			if match(relPath) {
 				// Append the unmodified/absolute path to the matched files.
@@ -164,6 +165,7 @@ func (c *ChartFiles) GetCRDFiles(gen CRDGenerator, match func(string) bool) ([]*
 			if err != nil {
 				return fmt.Errorf("get relative path: %w", err)
 			}
+
 			// Use the relative path to match against the provided filter.
 			if match(relPath) {
 				// Append the unmodified/absolute path to the matched files.

pkg/helmrepo/repo.go

@@ -201,8 +201,8 @@ func (m *Manager) addByName(name string, repo *Repo) error {
 // Get returns a repo by its name or URL. It calls [Manager.GetByName] or
 // [Manager.GetByURL] depending on the input.
 func (m *Manager) Get(repo string) (*Repo, error) {
-	if strings.HasPrefix(repo, "@") {
-		return m.GetByName(strings.TrimPrefix(repo, "@"))
+	if after, ok := strings.CutPrefix(repo, "@"); ok {
+		return m.GetByName(after)
 	}
 
 	return m.GetByURL(repo)

pkg/kclautomation/automation.go

@@ -82,7 +82,7 @@ func (a Automation) GetSpecs(specPath string) ([]string, error) {
 
 // SpecPathJoin joins path components with dots, splitting any components that already contain dots.
 func SpecPathJoin(path ...string) string {
-	pathParts := []string{}
+	pathParts := make([]string, 0, len(path))
 	for _, p := range path {
 		pathParts = append(pathParts, strings.FieldsFunc(p, func(c rune) bool {
 			return c == '.'

pkg/kclautomation/file_test.go

@@ -93,8 +93,8 @@ func TestFile_OverrideFile(t *testing.T) {
 			// since the exact formatting (spaces, etc.) may vary
 			for _, spec := range tc.specs {
 				key := spec
-				if idx := strings.Index(spec, "="); idx >= 0 {
-					key = spec[:idx]
+				if before, _, ok := strings.Cut(spec, "="); ok {
+					key = before
 				}
 
 				assert.Contains(t, string(content), key)

pkg/kclmodule/kclchart/chart.go

@@ -27,7 +27,7 @@ func (c *Chart) GenerateKCL(w io.Writer) error {
 		return fmt.Errorf("failed to create schema reflector: %w", err)
 	}
 
-	js := r.Reflect(reflect.TypeOf(Chart{}))
+	js := r.Reflect(reflect.TypeFor[Chart]())
 	js.Schema.Description = "All possible chart configuration, inheriting from `helm.Chart(helm.ChartBase)`."
 
 	js.SetProperty("chart", jsonschema.WithDefault(c.Chart))