Skip to content

Commit 69fb0d7

Browse files
committed
ci: drop redundant kclipper:format from validate
go:lint (golangci-lint run) already reports unformatted Go and fails, and kclipper:lint-prettier already gates yaml/md/json formatting. kclipper:format re-ran a full golangci-lint pass with --fix purely to assert the same formatting freshness, so validate ran golangci-lint twice over the whole tree concurrently on a 4-core runner. Under that contention a cold run exceeded golangci-lint's 5m timeout (exit 4), and because the run never completed the linter cache never warmed, so go:lint and kclipper:format both failed at ~5m35s on every push and PR. Drop kclipper:format from the check list: go:lint and kclipper:lint-prettier cover its gating, while go:generate and go:tidy remain for generator freshness. The +generate Format function is unchanged and still applies fixes under `dagger generate` and the pre-commit hook.
1 parent d991ab4 commit 69fb0d7

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/validate.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ jobs:
2929
with:
3030
version: "v0.21.4"
3131
verb: check
32-
args: go:lint kclipper:lint-prettier kclipper:lint-actions kclipper:lint-releaser kclipper:lint-kclmodules go:generate go:tidy kclipper:format
32+
args: go:lint kclipper:lint-prettier kclipper:lint-actions kclipper:lint-releaser kclipper:lint-kclmodules go:generate go:tidy
3333
cloud-token: ${{ secrets.DAGGER_CLOUD_TOKEN }}
3434
enable-github-summary: "true"
3535

0 commit comments

Comments
 (0)