-
Notifications
You must be signed in to change notification settings - Fork 736
Update NCDF Reader to read .ncrst Restart Files #5031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on GitHub Discussions so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.
|
Turning this PR into a draft for now, because there is a wide-affecting bug with the |
|
Now that #5052 has been fixed, would it be worthwhile to rebase the PR and see if can continue? |
|
Regarding the status of this PR:
|
|
Ok, thanks for the explanation.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I completely lapsed on reviewing this.
I'm unfortunately going to have to put a pause on this so that it doesn't get eagerly merged into the upcoming release. There's a few things I had in my notes I needed to check before we merged this - mostly AMBER format things.
Fixes #5030
Changes made in this Pull Request:
.ncrstrestart filesncrstfile is readed correctly. The test file I used is created from a .nc file already present in MDAnalysisTestPR Checklist
package/CHANGELOGfile updated?package/AUTHORS? (If it is not, add it!)Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
📚 Documentation preview 📚: https://mdanalysis--5031.org.readthedocs.build/en/5031/