[K7.0] Fix for removing Kunena via Tools (#9925)

* Fix for removing Kunena via Tools

* [K7.0] Fix: install scripts deleteFiles must je relative, and removed unused… (#9914)

* Fix: install scripts deleteFiles must je relative, and removed unused min requirements (these are enforced by package

* [K7.0] PLG kunena easysocial (#9915)

* [untested] plg_kunena_easysocial refactoring into service provider plugin

* refactored kunena easysocial + cleanup other kunena integration plugins

* Fix: 403 forbidden

* Fix: install scripts deleteFiles must je relative, and removed unused min requirements (these are enforced by package

* Uninstall via Joomla Extension manager

* Fix for removing Kunena via Tools

* Uninstall via Joomla Extension manager

Author: Ruud68

src/admin/kunena.xml

@@ -23,6 +23,13 @@
                 charset="utf8">sql/install/mysql/create_tables.utf8.sql</file>
         </sql>
     </install>
+    <uninstall>
+        <sql>
+            <file
+                driver="mysql"
+                charset="utf8">sql/uninstall/mysql/uninstall.mysql.utf8.sql</file>
+        </sql>
+    </uninstall>
     <files folder="site">
         <folder>language</folder>
         <folder>src</folder>

src/admin/language/en-GB/com_kunena.controllers.ini

@@ -123,8 +123,6 @@ COM_KUNENA_AJAX_RECOUNT_WAIT = "Recounting forum statistics, please wait!"
 COM_KUNENA_AJAX_ERROR = "An Error Occurred"
 COM_KUNENA_AJAX_DETAILS_BELOW = "Please see more details below."
 COM_KUNENA_AJAX_REQUESTED_RECOUNTED = "Requested statistics were recounted."
-COM_KUNENA_TOOLS_UNINSTALL_LOGIN_FAILED = "Login failed to launch uninstall process"
-COM_KUNENA_TOOLS_UNINSTALL_LOGIN_SECRETKEY_INVALID = "The secretkey entered is empty or it's not a number"
 
 ; JROOT/administrator/components/com_kunena/controllers/topicicons.php
 

src/admin/language/en-GB/com_kunena.install.ini

@@ -76,10 +76,6 @@ COM_KUNENA_INSTALL_STEP_FINISH = "Finish Installation"
 COM_KUNENA_INSTALL_STEP_INSTALL = "Select an Installation or Upgrade Option"
 COM_KUNENA_INSTALL_STEP_PLUGINS = "Install Plug-ins"
 COM_KUNENA_INSTALL_STEP_PREPARE = "Prepare Installation"
-COM_KUNENA_INSTALL_UNINSTALL = "Remove Kunena"
-COM_KUNENA_INSTALL_UNINSTALL_DESC = "Remove Kunena together with its data and all the files."
-COM_KUNENA_INSTALL_UNINSTALL_HINT = "You can use this option if you want to start over with a clean installation."
-COM_KUNENA_INSTALL_UNINSTALL_WARN = "This action will delete all the data from your forum, including categories, posts and attachments."
 COM_KUNENA_INSTALL_UPGRADE = "Upgrade Kunena"
 COM_KUNENA_INSTALL_UPGRADE_DESC = "Upgrade Kunena from version #VERSION_OLD# to #VERSION#."
 COM_KUNENA_INSTALL_UPGRADE_HINT = "Use this option to upgrade Kunena #VERSION_OLD# to the current version."

src/admin/language/en-GB/com_kunena.views.ini

@@ -1011,8 +1011,6 @@ COM_KUNENA_C_SYNCEUSERSDESC = "Sync the Kunena user table with the Joomla user t
 COM_KUNENA_GIT_INSTALL = "Git Install"
 COM_KUNENA_GIT_INSTALL_DESC = "Git Installation"
 COM_KUNENA_RECOUNTFORUMS = "Recount Category Statistics"
-COM_KUNENA_TOOLS_LABEL_UNINSTALL_PROCESS = "Uninstall Kunena"
-COM_KUNENA_TOOLS_LABEL_UNINSTALL_PROCESS_DESC = "Uninstall Kunena from joomla included database"
 
 ; JROOT/administrator/components/com_kunena/views/tools/tmpl/menu.php
 
@@ -1250,18 +1248,6 @@ COM_KUNENA_DIAGNOSTICS_LABEL_FIX_ISSUES = "FIX ISSUES"
 COM_KUNENA_DIAGNOSTICS_LABEL_TEST_PASSED = "TEST PASSED"
 COM_KUNENA_DIAGNOSTICS_LABEL_DELETE_BROKEN_ITEMS = "DELETE BROKEN ITEMS"
 
-; JROOT/administrator/components/com_kunena/views/tools/tmpl/uninstall.php
-
-COM_KUNENA_TOOLS_LABEL_UNINSTALL_TITLE = "Uninstall Kunena"
-COM_KUNENA_TOOLS_LABEL_UNINSTALL_ALERTBOX_WARNING = "WARNING!"
-COM_KUNENA_TOOLS_LABEL_UNINSTALL_ALERTBOX_DESC = "Proceed with caution. This action is irreversible and will permanently delete this Kunena installation."
-COM_KUNENA_TOOLS_LABEL_UNINSTALL_DESC = "All user data in the database including categories, topics, messages, and attachments will be deleted. Kunena installation directories will be removed from you Joomla install including the Kunena Site Component, Kunena Administrator Component, and Kunena Library. If you don't have a backup there is no way to go back and restore this data."
-COM_KUNENA_TOOLS_LABEL_UNINSTALL_TFA_DESC = "In order to execute the process, you need to log in with a super-administrator account. If you have Two-Factor Authentication enabled you may need to include the authenticator code to proceed."
-COM_KUNENA_TOOLS_LABEL_UNINSTALL_LOGIN = "Username"
-COM_KUNENA_TOOLS_LABEL_UNINSTALL_PASSWORD = "Password"
-COM_KUNENA_TOOLS_BUTTON_UNINSTALL_PROCESS = "Execute the process"
-COM_KUNENA_TOOLS_LABEL_UNINSTALL_SECRETKEY = "Secret key"
-
 ; JROOT/administrator/components/com_kunena/views/logs
 
 COM_KUNENA_LOG_MANAGER = "Logs"

src/admin/sql/uninstall/mysql/uninstall.mysql.utf8.sql

@@ -0,0 +1,28 @@
+DROP TABLE IF EXISTS `#__kunena_aliases`;
+DROP TABLE IF EXISTS `#__kunena_announcement`;
+DROP TABLE IF EXISTS `#__kunena_attachments`;
+DROP TABLE IF EXISTS `#__kunena_categories`;
+DROP TABLE IF EXISTS `#__kunena_karma`;
+DROP TABLE IF EXISTS `#__kunena_configuration`;
+DROP TABLE IF EXISTS `#__kunena_topics`;
+DROP TABLE IF EXISTS `#__kunena_messages`;
+DROP TABLE IF EXISTS `#__kunena_messages_text`;
+DROP TABLE IF EXISTS `#__kunena_polls`;
+DROP TABLE IF EXISTS `#__kunena_polls_options`;
+DROP TABLE IF EXISTS `#__kunena_polls_users`;
+DROP TABLE IF EXISTS `#__kunena_private`;
+DROP TABLE IF EXISTS `#__kunena_private_attachment_map`;
+DROP TABLE IF EXISTS `#__kunena_private_post_map`;
+DROP TABLE IF EXISTS `#__kunena_private_user_map`;
+DROP TABLE IF EXISTS `#__kunena_ranks`;
+DROP TABLE IF EXISTS `#__kunena_rate`;
+DROP TABLE IF EXISTS `#__kunena_sessions`;
+DROP TABLE IF EXISTS `#__kunena_smileys`;
+DROP TABLE IF EXISTS `#__kunena_thankyou`;
+DROP TABLE IF EXISTS `#__kunena_user_categories`;
+DROP TABLE IF EXISTS `#__kunena_user_read`;
+DROP TABLE IF EXISTS `#__kunena_user_topics`;
+DROP TABLE IF EXISTS `#__kunena_users`;
+DROP TABLE IF EXISTS `#__kunena_users_banned`;
+DROP TABLE IF EXISTS `#__kunena_logs`;
+DROP TABLE IF EXISTS `#__kunena_version`;

src/admin/src/Controller/InstallController.php

@@ -866,64 +866,6 @@ public function cancel($key = null)
         $this->app->redirect(KunenaRoute::_($this->baseurl, false));
     }
 
-    /**
-     * Method to completely remove kunena by checking before if the user is a super-administrator
-     *
-     * @return  void
-     *
-     * @since   Kunena 4.0
-     *
-     * @throws  null
-     * @throws  Exception
-     */
-    public function uninstall(): void
-    {
-        if (!Session::checkToken()) {
-            $this->app->enqueueMessage(Text::_('COM_KUNENA_ERROR_TOKEN'), 'error');
-            $this->setRedirect(KunenaRoute::_($this->baseurl, false));
-
-            return;
-        }
-
-        // Check if the user has the super-administrator rights
-        $username = $this->input->getString('username');
-        $password = $this->input->getString('password');
-        $code     = $this->input->getInt('secretkey');
-
-        $login = KunenaLogin::getInstance();
-
-        if ($login->isTFAEnabled()) {
-            if (empty($code) || $code == 0) {
-                $this->app->enqueueMessage(Text::_('COM_KUNENA_TOOLS_UNINSTALL_LOGIN_SECRETKEY_INVALID'), 'error');
-                $this->setRedirect(KunenaRoute::_($this->baseurl, false));
-            }
-        }
-
-        $params = new Registry();
-        $Joomlalogin = new KunenaLoginJoomla($params);
-
-        try {
-            $logged  = $Joomlalogin->loginUser($username, $password, false);
-        } catch (Exception $e) {
-            $this->app->enqueueMessage($e->getMessage(), 'error');
-        }
-
-        $user = Factory::getContainer()->get(UserFactoryInterface::class)->loadUserByUsername($username);
-
-        $isRoot = $user->authorise('core.admin');
-
-        if ($logged && $isRoot) {
-            $this->app->setUserState('com_kunena.uninstall.allowed', true);
-
-            $this->setRedirect(KunenaRoute::_('administrator/index.php?option=com_kunena&task=install.uninstall&' . Session::getFormToken() . '=1', false));
-
-            return;
-        }
-
-        $this->app->enqueueMessage(Text::_('COM_KUNENA_TOOLS_UNINSTALL_LOGIN_FAILED'), 'error');
-        $this->setRedirect(KunenaRoute::_($this->baseurl, false));
-    }
-
     /**
      * System Report
      *

src/admin/src/Controller/ToolsController.php

@@ -19,7 +19,6 @@
 use Joomla\CMS\Factory;
 use Joomla\CMS\Language\Text;
 use Joomla\CMS\MVC\View\HtmlView as BaseHtmlView;
-use Joomla\CMS\Toolbar\Toolbar;
 use Joomla\CMS\Toolbar\ToolbarHelper;
 use Kunena\Forum\Libraries\Access\KunenaAccess;
 use Kunena\Forum\Libraries\Forum\Topic\KunenaTopicHelper;
@@ -171,11 +170,6 @@ public function display($tpl = null)
             $this->setToolBarSubscriptions();
         } elseif ($layout == 'syncUsers') {
             $this->setToolBarSyncUsers();
-        } elseif ($layout == 'uninstall') {
-            $login              = KunenaLogin::getInstance();
-            $this->isTFAEnabled = $login->isTFAEnabled();
-
-            $this->setToolBarUninstall();
         }
 
         return parent::display($tpl);
@@ -359,19 +353,4 @@ protected function setToolBarSyncUsers(): void
         $helpUrl = 'https://docs.kunena.org/en/manual/backend/tools/synchronize-users';
         ToolbarHelper::help('COM_KUNENA', false, $helpUrl);
     }
-
-    /**
-     * @return  void
-     *
-     * @since   Kunena 6.0
-     */
-    protected function setToolBarUninstall(): void
-    {
-        ToolbarHelper::title(Text::_('COM_KUNENA'), 'tools');
-        ToolbarHelper::spacer();
-        ToolbarHelper::cancel();
-        ToolbarHelper::spacer();
-        $helpUrl = 'https://docs.kunena.org/en/manual/backend/tools/uninstall-kunena';
-        ToolbarHelper::help('COM_KUNENA', false, $helpUrl);
-    }
 }

src/admin/src/View/Tools/HtmlView.php

@@ -205,28 +205,6 @@
                     </a>
                 </div>
 
-                <div class="col-xl-3 col-md-6">
-                    <a href="<?php echo Route::_('index.php?option=com_kunena&view=tools&layout=uninstall'); ?>">
-                        <div class="card proj-t-card comp-card">
-                            <div class="card-body">
-                                <div class="row align-items-center">
-                                    <div class="col">
-                                        <h6 class="mb-25">
-                                            <?php echo Text::_('COM_KUNENA_TOOLS_LABEL_UNINSTALL_PROCESS'); ?>
-                                        </h6>
-                                        <h3 class="fw-700 text-cyan">
-                                            <?php echo Text::_('COM_KUNENA_TOOLS_LABEL_UNINSTALL_PROCESS_DESC'); ?>
-                                        </h3>
-                                    </div>
-                                    <div class="col-auto">
-                                        <i class="fas fa-wrench bg-cyan"></i>
-                                    </div>
-                                </div>
-                            </div>
-                        </div>
-                    </a>
-                </div>
-
                 <?php if (KunenaForum::isDev()) :
                 ?>
                     <div class="col-xl-3 col-md-6">