Skip to content

fix: detect and handle auto-inserted brackets in Ghost completions #3390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

fix: detect and handle auto-inserted brackets in Ghost completions #3390

wants to merge 4 commits into from
+190 −27

Conversation

@markijbema
Copy link
Contributor

  • Modified findMatchingSuggestion to return both text and original suggestion
  • Added logic to detect when VS Code auto-inserts closing brackets
  • Compare current suffix with cached suffix to identify auto-inserted characters
  • Replace auto-inserted brackets instead of inserting alongside them
  • Added comprehensive test coverage for bracket detection scenarios
  • Fixes issue where duplicate brackets appeared after accepting suggestions

@markijbema
fix: detect and handle auto-inserted brackets in Ghost completions
c85c322 
- Modified findMatchingSuggestion to return both text and original suggestion
- Added logic to detect when VS Code auto-inserts closing brackets
- Compare current suffix with cached suffix to identify auto-inserted characters
- Replace auto-inserted brackets instead of inserting alongside them
- Added comprehensive test coverage for bracket detection scenarios
- Fixes issue where duplicate brackets appeared after accepting suggestions
@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 938aeca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markijbema
Copy link
Contributor Author

Bad idea, the actual llm response causes this and this isnt subtle enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markijbema