Skip to content

Commit ba1b4af

Browse files
committed
pre-build : gird layout fixes, xml comments
1 parent c532974 commit ba1b4af

10 files changed

Lines changed: 32 additions & 17 deletions

File tree

uSync.BackOffice/Notifications/uSyncNotifications/uSyncBulkNotification.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,16 @@ public class uSyncBulkNotification : INotification
1313
/// <summary>
1414
/// generate new BulkNotificationObject
1515
/// </summary>
16-
/// <param name="actions"></param>
1716
public uSyncBulkNotification(IEnumerable<uSyncAction> actions, string? group)
1817
{
1918
this.Group = group;
2019
this.Actions = actions;
2120
}
2221

22+
/// <summary>
23+
/// generate a new bulk notification object without a group.
24+
/// </summary>
25+
2326
[Obsolete("Use the constructor with group and actions instead - will be removed in v19")]
2427
public uSyncBulkNotification(IEnumerable<uSyncAction> actions)
2528
{

uSync.BackOffice/Tracker/ISyncTrackerService.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,18 @@
33

44
namespace uSync.BackOffice.Tracker;
55

6+
/// <summary>
7+
/// Saves and Retrieves the last import date for the different groups.
8+
/// </summary>
69
public interface ISyncTrackerService
710
{
11+
/// <summary>
12+
/// get the last date stored in the db for an import for a given group.
13+
/// </summary>
814
Task<DateTime?> GetLastSync(string group);
15+
16+
/// <summary>
17+
/// set the last import date for a given group
18+
/// </summary>
919
Task SaveLastSync(string group);
1020
}

uSync.Backoffice.Management.Client/usync-assets/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

uSync.Backoffice.Management.Client/usync-assets/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"homepage": "https://jumoo.co.uk/uSync",
99
"license": "MPL-2.0",
1010
"type": "module",
11-
"version": "17.0.3",
11+
"version": "17.0.4",
1212
"main": "./dist/usync.js",
1313
"types": "./dist/index.d.ts",
1414
"module": "./dist/usync.js",

uSync.Backoffice.Management.Client/usync-assets/src/components/usync-action-box.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ export class uSyncActionBox extends UmbLitElement {
9595
.box-heading {
9696
font-size: var(--uui-type-h3-size);
9797
cursor: help;
98-
margin: 0;
98+
margin: var(--uui-size-space-3);
9999
}
100100
101101
umb-icon {

uSync.Backoffice.Management.Client/usync-assets/src/workspace/views/default/default.element.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ export class uSyncDefaultViewElement extends UmbLitElement {
328328
css`
329329
:host {
330330
display: block;
331-
margin-top: calc(var(--uui-size-space-4) * -1);
331+
// margin-top: calc(var(--uui-size-space-4) * -1);
332332
}
333333
334334
.wrapper {
@@ -356,7 +356,7 @@ export class uSyncDefaultViewElement extends UmbLitElement {
356356
display: grid;
357357
grid-template-columns: repeat(auto-fit, minmax(430px, 1fr));
358358
position: relative;
359-
gap: var(--uui-size-space-4);
359+
gap: var(--uui-size-space-5);
360360
flex-wrap: wrap;
361361
align-content: stretch;
362362
z-index: 1;

uSync.Backoffice.Management.Client/usync-assets/src/workspace/views/settings/settings.element.ts

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -163,24 +163,26 @@ export class USyncSettingsViewElement extends UmbElementMixin(LitElement) {
163163
static styles = css`
164164
:host {
165165
display: block;
166-
margin: calc(var(--uui-size-space-4) * -1) 0;
167166
}
168167
169168
.usync-settings-layout {
170169
display: grid;
171170
grid-template-columns: 5fr 5fr;
172171
grid-template-rows: auto auto;
173-
gap: var(--uui-size-space-4) var(--uui-size-space-4);
172+
gap: var(--uui-size-space-5);
173+
row-gap: var(--uui-size-space-5);
174174
grid-auto-flow: row;
175175
grid-template-areas: 'settings info', 'handler info';
176176
}
177177
178-
.setting-link {
179-
text-align: center;
178+
.usync-settings-layout > div {
179+
display: flex;
180+
flex-direction: column;
181+
gap: var(--uui-size-space-6);
180182
}
181183
182-
uui-box {
183-
margin: var(--uui-size-space-4) 0;
184+
.setting-link {
185+
text-align: center;
184186
}
185187
`;
186188
}

uSync.Core/Serialization/Serializers/ContentSerializer.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public ContentSerializer(
5050
SyncValueMapperCollection syncMappers,
5151
IUserService userService,
5252
ITemplateService templateService,
53-
ISyncDocumentUrlCleaner urlCleaner)
53+
ISyncDocumentUrlCleaner? urlCleaner)
5454
: base(entityService, languageService, relationService, shortStringHelper, logger, UmbracoObjectTypes.Document, syncMappers)
5555
{
5656
this.contentService = contentService;

uSync.History/history-client/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

uSync.History/history-client/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "usync-history-client",
3-
"version": "17.0.3",
3+
"version": "17.0.4",
44
"licence": "Custom",
55
"description": "uSync history function",
66
"type": "module",

0 commit comments

Comments
 (0)