Commit 431abfd
Bump JSOSolvers to 0.14 and in JSOSolvers tutorials (#148)
* docs(advanced-jsosolvers): update TRUNK/TRON subsolver usage to new keyword API (fixes #145)
- Add migration note showing old subsolver_type => new subsolver=:symbol API
- Update solver dictionary examples to use subsolver = :cgls, :crls, :lsqr, :lsmr
- Add explicit TRUNK and TRON examples with subsolver, rtol, atol, max_time
- Add reference to JSOSolvers allowed_subsolvers lists
- Link to Krylov.jl docs for subsolver algorithm details
- Fix grammar and copy edits (heading, wording, plurals)
* docs(advanced-jsosolvers): add migration note and Krylov.jl docs link for complete #145 fix
- Add migration note at top explaining subsolver_type => subsolver API change
- Link to Krylov.jl documentation for subsolver algorithm details
- Ensures users understand the new API and can find detailed subsolver info
* test: fix runtests.jl to only check tutorial directories
- Filter out non-directory items (like files in scripts/)
- Only check for index.jmd and Project.toml (not generated files)
- Fixes test suite that was failing on both main and fix branches
* Update index.jmd
* Update tutorials/advanced-jsosolvers/index.jmd
Co-authored-by: Tangi Migot <[email protected]>
* Revert to correct JSOSolvers 0.11 API
The previous changes attempted to use `subsolver = :symbol` API which doesn't exist in JSOSolvers 0.11.
Testing confirmed that JSOSolvers 0.11 uses `subsolver_type = Type` (e.g., CglsSolver, LsmrSolver).
This commit reverts to the correct working API that is compatible with JSOSolvers 0.11.2.
* Update runtests.jl
* Update tutorials to use JSOSolvers 0.14 with Symbol-based subsolver API
- Update JSOSolvers from 0.11 to 0.14 in Project.toml files
- Update Krylov from 0.9 to 0.10 (required by JSOSolvers 0.14)
- Replace Type-based subsolver API with Symbol-based API:
* subsolver_type = CglsSolver → subsolver = :cgls
* subsolver_type = LsmrSolver → subsolver = :lsmr
* etc.
- Remove Krylov.jl import (no longer needed for subsolver types)
- Remove compatibility note about JSOSolvers 0.11
This addresses issue #145 by updating to the new subsolver API
introduced in JSOSolvers 0.14.0.
Affected tutorials:
- tutorials/advanced-jsosolvers/
- tutorials/introduction-to-jsosolvers/
Tests: All package tests pass ✓
* intro tutorial: ensure `using JSOSolvers` precedes constants listing
The version badge on the site is derived from the local Project.toml,
so we test against tutorials/introduction-to-jsosolvers/Project.toml.
This change guarantees the constants are referenced after importing
JSOSolvers (v0.14+ Symbol subsolver API).
* Delete tutorials/introduction-to-jsosolvers/Manifest.toml
* Clean up code block formatting in index.jmd
Removed unnecessary code block delimiters from documentation.
* Modify import statements in index.jmd
Updated import statements to include ADNLPModels with JSOSolvers.
* Update tutorials/advanced-jsosolvers/Project.toml
---------
Co-authored-by: Tangi Migot <[email protected]>1 parent 8b527f4 commit 431abfd
File tree
4 files changed
+26
-19
lines changed- tutorials
- advanced-jsosolvers
- introduction-to-jsosolvers
4 files changed
+26
-19
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
| 11 | + | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
| 11 | + | |
16 | 12 | | |
17 | 13 | | |
18 | 14 | | |
19 | | - | |
| 15 | + | |
20 | 16 | | |
21 | 17 | | |
22 | 18 | | |
| |||
38 | 34 | | |
39 | 35 | | |
40 | 36 | | |
41 | | - | |
| 37 | + | |
42 | 38 | | |
43 | 39 | | |
44 | 40 | | |
45 | 41 | | |
46 | 42 | | |
47 | 43 | | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
48 | 50 | | |
49 | 51 | | |
50 | | - | |
| 52 | + | |
51 | 53 | | |
52 | 54 | | |
53 | | - | |
54 | | - | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
55 | 62 | | |
56 | 63 | | |
57 | 64 | | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
62 | 69 | | |
63 | 70 | | |
64 | 71 | | |
| |||
91 | 98 | | |
92 | 99 | | |
93 | 100 | | |
94 | | - | |
| 101 | + | |
95 | 102 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| 50 | + | |
50 | 51 | | |
51 | 52 | | |
52 | 53 | | |
| |||
0 commit comments