Test this package locally

[DilumAluthge]

We should test this package out locally, to make sure it works.

@DrChainsaw You have access to an LSF cluster, right? Would you be able to clone this package locally and test it out?

[DrChainsaw]

I just tried it and I think it works, but I can't tell for sure since I seem to be having some frequent cluster-jank issues with bpeek (which is used to read the stdout to get the connection info) where most workers come online just fine, but for a few the bpeek command just hangs.

This behaviour is the same when running bpeek from the shell. When I kill the job the correct host and port number is shown in the output log, so the worker itself seems to, uhm, work.

If I try to start a very small number of workers I often get all workers to come online though, so I think the overall verdict is that the package works. I also get the same issue with the latest version of ClusterManagers.

Maybe get a second opinion from @bjarthur before we close this?

[DilumAluthge]

If the behavior of the master branch of this package is identical to the behavior of the latest registered version (v0.4.7) of ClusterManagers.jl, then I think that it's fine.

@bjarthur What are your thoughts here? Do you have access to a LSF cluster where you could test this package out?

[DilumAluthge]

Bump @DrChainsaw @bjarthur

If the behavior of the master branch of this package is identical to the behavior of the latest registered version (v0.4.7) of ClusterManagers.jl, then I think that it's fine. After all, the code here is exactly copy-pasted from the master branch of ClusterManagers.jl.

@DrChainsaw @bjarthur Are we good to move forward with registering this package? Or is there more testing that we want to do first?

[DrChainsaw]

I'm pretty certain that the behaviour is identical so I'm fine with releasing (after we resolved the naming issue).

[bjarthur]

tests pass locally for me. i did not try with a large number of workers, just ran ]test.

[bjarthur]

i find test/runtests.jl i bit complicated with how one can pass in "lsf" to test_args and then the switches that follow. perhaps vestigially leftover from when it was in ClusterManagers.jl. could probably be simplified a lot.

[DilumAluthge]

Yes we should definitely work on simplifying the test suite now that we've brought this code into a standalone package.

It's good news to hear that you were able to get the tests passing on your local cluster!