This repository was archived by the owner on May 21, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
unsafe_gettpl!from JuliaPy/PyCall.jl#486 to get faster access to the elements from thes, r, done, infotuple returned by gymenv.stepfunctions in Python.This is two extra commits on top of #12
Requires
You can test this out by checking out the
devbranch on https://github.com/JobJob/PyCall.jl, and thefixes-for-1.0branch for https://github.com/JobJob/Reinforce.jl, and the branch for this PR -speediereron https://github.com/JobJob/OpenAIGym.jlThere may be some artifacts in the timing, but speed of stepping the environments in a loop (with random actions) seems slightly faster in Julia than Python for all envs.
Here's the performance vs Python 3 on my machine using the Julia and Python benchmarks the tests: