disable assert macro unless running in debug mode

Author: KristofferC

base/error.jl

@@ -183,7 +183,17 @@ windowserror(p, b::Bool; extrainfo=nothing) = b ? windowserror(p, extrainfo=extr
 windowserror(p, code::UInt32=Libc.GetLastError(); extrainfo=nothing) = throw(Main.Base.SystemError(string(p), 0, WindowsErrorInfo(code, extrainfo)))
 
 
-## assertion macro ##
+## assertion and ifdebug macros ##
+
+"""
+    @ifdebug expr
+
+Equivalent to `@static if isdebug()`
+"""
+macro ifdebug(expr)
+    isdefined(@__MODULE__, :isdebug) && !(isdebug()) && return nothing
+    return :(esc(expr))
+end
 
 
 """

test/exceptions.jl

@@ -369,6 +369,8 @@ end
 end
 
 # issue #36527
+s = raw"""
+using Test
 function f36527()
     caught = false
     🏡 = Core.eval(Main, :(module asdf36527 end))
@@ -383,6 +385,8 @@ function f36527()
 end
 
 @test f36527()
+"""
+@test success(`$(Base.julia_cmd()) -g2 -e $s`)
 
 # accessing an undefined var in tail position in a catch block
 function undef_var_in_catch()

test/misc.jl

@@ -714,19 +714,19 @@ end
 
 @kwdef struct TestInnerConstructor
     a = 1
-    TestInnerConstructor(a::Int) = (@assert a>0; new(a))
+    TestInnerConstructor(a::Int) = (a>0 || error(); new(a))
     function TestInnerConstructor(a::String)
-        @assert length(a) > 0
+        length(a) > 0 || error()
         new(a)
     end
 end
 
 @testset "@kwdef inner constructor" begin
     @test TestInnerConstructor() == TestInnerConstructor(1)
     @test TestInnerConstructor(a=2) == TestInnerConstructor(2)
-    @test_throws AssertionError TestInnerConstructor(a=0)
+    @test_throws ErrorException TestInnerConstructor(a=0)
     @test TestInnerConstructor(a="2") == TestInnerConstructor("2")
-    @test_throws AssertionError TestInnerConstructor(a="")
+    @test_throws ErrorException TestInnerConstructor(a="")
 end
 
 const outsidevar = 7
@@ -763,7 +763,7 @@ end
 
 @testset "Pointer to unsigned/signed integer" begin
     # assuming UInt and Ptr have the same size
-    @assert sizeof(UInt) == sizeof(Ptr{Nothing})
+    @test sizeof(UInt) == sizeof(Ptr{Nothing})
     uint = UInt(0x12345678)
     sint = signed(uint)
     ptr = reinterpret(Ptr{Nothing}, uint)