Fix Repeating tokens in WordEmbeddings #14693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevinTDHa
changed the base branch from
master
to
release/622-release-candidate
DevinTDHa
approved these changes
Nov 13, 2025
DevinTDHa
merged commit 5c7d0d7
into
release/622-release-candidate
1 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the splitter-based pipeline, the WordEmbeddings annotator is generating an excessive number of repeated embeddings.
Normally, when using the splitter base, some token overlap is expected — meaning a certain number of tokens should appear twice due to window overlap.
However, instead of appearing twice, tokens are being repeated four times, causing a mismatch between the token and embedding counts.
this is being fixed by updating
TokenizedWithSentenceto filter tokens such that tokens fall within the same sentence at most once so a token can't come up in two differnet sentences.Added a new FastTest to make sure correct behaviour ( no repeated tokens ) works