From 567ed8ab4efcdffd87902bb10373357a9f4f8299 Mon Sep 17 00:00:00 2001 From: Arnaud Giuliani Date: Fri, 30 Oct 2026 09:13:05 +0100 Subject: [PATCH] =?UTF-8?q?fix:=20warn=20when=20the=20startKoin=20module?= =?UTF-8?q?=20has=20no=20DSL=20definition=20=E2=80=94=20DSL=20graph=20not?= =?UTF-8?q?=20validated?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit DSL graph validation only runs when the module calling startKoin { } has at least one DSL definition of its own. An entry point that only loads other modules got no validation and no message: a missing dependency compiled clean. Now logs a warning (same severity setting as the other informational output). No validation change. --- .../src/org/koin/compiler/plugin/ir/KoinIrExtension.kt | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/koin-compiler-plugin/src/org/koin/compiler/plugin/ir/KoinIrExtension.kt b/koin-compiler-plugin/src/org/koin/compiler/plugin/ir/KoinIrExtension.kt index 4866e5d..8474c97 100644 --- a/koin-compiler-plugin/src/org/koin/compiler/plugin/ir/KoinIrExtension.kt +++ b/koin-compiler-plugin/src/org/koin/compiler/plugin/ir/KoinIrExtension.kt @@ -163,6 +163,13 @@ class KoinIrExtension( modulesWithIncompleteIncludes = koinTransformer.modulesWithIncompleteIncludes, ownsAuthoritativeGraph = startKoinTransformer.ownsAuthoritativeGraph ) + } else if (safetyValidator != null && dslDefinitions.isEmpty() + && safetyValidator.assembledGraphTypes.isEmpty() + && startKoinTransformer.hasKoinEntryPoint) { + // Disclosure, same stance as the no-entry-point one below: Phase 3.1 needs at least one + // local DSL definition, so an entry point that only loads other modules' DSL definitions + // validates nothing. Not changing that here — just not doing it silently. + KoinPluginLogger.warn("compile-safety: DSL graph not validated — no DSL definition in this entry-point module.") } // Phase 3.5: Validate pending call sites (simple loop, no tree walk)