-
Notifications
You must be signed in to change notification settings - Fork 45
Open
Description
🐛 Bug Report
Affected Repository
This issue affects slim-viewer when using the latest dcmjs release.
Reproduction Steps
- Draw one or more ROIs in the Slim viewer (each gets a generated
roi.uid). - Click on
Save ROIin SlideViewer which callshandleReportGeneration() - Observe console error:
Uncaught Error: Option 'trackingIdentifier' must include a human readable tracking identifier and a tracking unique identifier.
This is caused by a bug in the dcmjs module (see dcmjs-org/dcmjs#434), where TrackingIdentifier’s constructor calls super(options) and erroneously pushes the raw options object into the internal content sequence.
Impact
- All ROI measurement exports from slim-viewer will fail.
- Automated report‐generation workflows break until the upstream fix is released.
Workarounds
-
Wait for upstream merge
The fix has been submitted in dcmjs-org/dcmjs#434 and is pending review & merge. Once released in a patch fordcmjs, updating your dependency will resolve the error automatically. -
Use our temporary fix branch
You can point your project at the following branch to unblock development immediately:npm install git+https://github.com/nr59684/dcmjs/tree/fix/trackingidentifier-super-call
References
- Upstream dcmjs issue & PR discussion: TrackingIdentifier constructor calls super(options) and injects raw options into the ContentSequence dcmjs-org/dcmjs#434
Metadata
Metadata
Assignees
Labels
No labels