- Fixed auto update

Author: IgorMundstein

src/App.xaml.cs

@@ -27,7 +27,6 @@ public partial class App : IDisposable
         private static bool _isRunning;
         private static Mutex _mutex;
         private static NotifyIcon _notifyIcon;
-        private static readonly List<ProcessStartInfo> _processes = new List<ProcessStartInfo>();
         private static readonly List<string> _notifications = new List<string>();
         private static readonly object _showHidelock = new object();
 
@@ -151,9 +150,7 @@ protected virtual void Dispose(bool disposing)
                 try
                 {
                     if (_notifyIcon != null)
-                    {
                         _notifyIcon.Dispose();
-                    }
                 }
                 catch
                 {
@@ -298,16 +295,14 @@ private void OnProcessExit(object sender, EventArgs e)
         {
             Dispose();
 
-            foreach (var process in _processes)
+            try
             {
-                try
-                {
-                    Process.Start(process);
-                }
-                catch
-                {
-                    // ignored
-                }
+                if (Updater.Process != null)
+                    Process.Start(Updater.Process);
+            }
+            catch (Exception ex)
+            {
+                Logger.Error("Error starting update process." + ex);
             }
         }
 
@@ -354,11 +349,11 @@ private void OnNotifyIconClick(object sender, System.Windows.Forms.MouseEventArg
                                 MainWindow.Dispatcher.BeginInvoke((Action)(() =>
                                 {
                                     var mainWindow = MainWindow as MainWindow;
-                                    
+
                                     if (mainWindow != null)
                                     {
                                         var optimizeButton = mainWindow.FindName("Optimize") as UIElement;
-                                        
+
                                         if (optimizeButton != null)
                                         {
                                             Keyboard.Focus(optimizeButton);
@@ -398,13 +393,14 @@ private void OnNotifyIconClick(object sender, System.Windows.Forms.MouseEventArg
         /// <param name="startupEvent">The <see cref="StartupEventArgs" /> instance containing the event data.</param>
         protected override void OnStartup(StartupEventArgs startupEvent)
         {
+            var startupType = Enums.StartupType.App;
+
             try
             {
                 Initialize();
 
-                var commandLineArguments = startupEvent != null ? new List<string>(startupEvent.Args.Select(arg => arg.Replace("-", "/").Trim())) : null;
+                var commandLineArguments = startupEvent != null ? startupEvent.Args.Select(arg => arg.Replace("-", "/").Trim()).ToArray() : null;
                 var memoryAreas = Enums.Memory.Areas.None;
-                var startupType = Enums.StartupType.App;
 
                 if (commandLineArguments != null)
                 {
@@ -414,16 +410,6 @@ protected override void OnStartup(StartupEventArgs startupEvent)
                     // Process command‑line arguments
                     foreach (var argument in commandLineArguments.Select(arg => arg.Replace("/", string.Empty)))
                     {
-                        // Memory areas to optimize
-                        Enums.Memory.Areas area;
-
-                        if (Enum.TryParse(argument, out area))
-                            memoryAreas |= area;
-
-                        // Version (Update)
-                        if (argument.Equals(Version.ToString()))
-                            _notifications.Add(string.Format(Localizer.Culture, Localizer.String.UpdatedToVersion, string.Format(Localizer.Culture, Constants.App.VersionFormat, Version.Major, Version.Minor, Version.Build)));
-
                         // Startup Type
                         if (memoryAreas != Enums.Memory.Areas.None)
                             startupType = Enums.StartupType.Silent;
@@ -436,6 +422,16 @@ protected override void OnStartup(StartupEventArgs startupEvent)
 
                         if (argument.Equals(Constants.App.CommandLineArgument.Uninstall, StringComparison.OrdinalIgnoreCase))
                             startupType = Enums.StartupType.Uninstallation;
+
+                        // Memory areas to optimize
+                        Enums.Memory.Areas area;
+
+                        if (Enum.TryParse(argument, out area))
+                            memoryAreas |= area;
+
+                        // Notify version update
+                        if (argument.Equals(Version.ToString()))
+                            _notifications.Add(string.Format(Localizer.Culture, Localizer.String.UpdatedToVersion, string.Format(Localizer.Culture, Constants.App.VersionFormat, Version.Major, Version.Minor, Version.Build)));
                     }
                 }
 
@@ -528,7 +524,9 @@ protected override void OnStartup(StartupEventArgs startupEvent)
             catch (Exception e)
             {
                 Logger.Error(e);
-                ShowDialog(e);
+
+                if (startupType == Enums.StartupType.App)
+                    ShowDialog(e);
 
                 Shutdown(true);
             }

src/Core/Constants.cs

@@ -12,6 +12,7 @@ public static class Constants
         public static class App
         {
             public const int AutoOptimizationMemoryUsageInterval = 5; // Minute
+            public const int AutoUpdateInterval = 24; // Hour
             public const string EmbeddedResourcePath = "WinMemoryCleaner.Resources.";
             public const string EmbeddedResourcePathExtension = ".json";
             public const string Id = "4B3E3081-D421-4AAC-B3DE-808B1A9CCD30";
@@ -81,30 +82,6 @@ public static class Repository
                 public static readonly Uri LatestExeUri = new Uri(GitHub + "/releases/latest/download/WinMemoryCleaner.exe");
                 public static readonly Uri Uri = new Uri(GitHub);
             }
-
-            public static class Update
-            {
-                public const string BackupDirName = "Backups";
-                public const int BackupRetentionDays = 3; // Day
-                public const int CheckInterval = 24; // Hour
-                public const string ChecksumsFileName = "checksums.txt";
-                public const int ChecksumsMaxRetries = 3;
-                public const int ChecksumsRetryDelay = 2; // Second
-                public const int DownloadTimeout = 60; // Second
-                public const int MaxConnectionLimit = 10;
-                public const string MutexName = @"Local\WinMemoryCleaner_AutoUpdate_Mutex";
-                public const bool RequireAuthenticode = true; // Require Authenticode trust and known thumbprint
-                public const bool RequireChecksum = true; // Require checksum to be present and matching
-                public const bool RequireKnownDownloadUri = true; // Require expected HTTPS GitHub URL shape
-                public const int ReplaceMaxTries = 120; // Count
-                public const int ReplaceRetryDelayMs = 1000; // Millisecond
-                public const string TempRootDirName = "WinMemoryCleaner";
-                public const string TokenEnvVar = "WMC_UPDATE_TOKEN";
-                public const string TokenFilePrefix = "WMC.";
-                public const string TokenFileSuffix = ".txt";
-                public const string UserAgent = "WinMemoryCleaner-Updater/1.0";
-                public const bool VerifyFileVersionInfo = true;
-            }
         }
 
         public static class Windows