FlxTypedText still rendered off screen

[moxie-coder]

FlxTypedText seems to still render text that is off screen and this has caused severe lag issues when using a very long string. I’ve experienced this happening before, and it shouldn’t render text that is not possible to see.

Based on #391

[moxie-coder]

I know this issue is kind of dead and old but, I think this might’ve fixed it? I’m not sure, I’ve not gave it a try yet

[Geokureli]

FlxTypeText uses FlxText, the issues you linked is a change to FlxBitmapText so it has no impact.

I don't recommend using FlxTypeText, try this instead, it works with either FlxText or FlxBitmapText
https://github.com/Geokureli/flixel-tests/blob/main/Source/flixel/addons/text/FlxTextTyper.hx

[Geokureli]

Also FWIW, this isn't as big a problem with bitmap texts, regardless of that change and this is such a niche need, that I recommend just using a custom class that extends FlxTypeText with your override, rather than make it the default behavior. How often are you typing text off screen? Maybe a better fix is to disable your text entirely when it's off screen?

Furthermore your fix wouldn't redraw if the text is moved back into view after finishing

[moxie-coder]

Also FWIW, this isn't as big a problem with bitmap texts, regardless of that change and this is such a niche need, that I recommend just using a custom class that extends FlxTypeText with your override, rather than make it the default behavior. How often are you typing text off screen? Maybe a better fix is to disable your text entirely when it's off screen?

Furthermore your fix wouldn't redraw if the text is moved back into view after finishing

It was only once for an mod that I had worked on, and then quit so this issue wasn’t really important to me anymore, I just forgot to close it after the years, plus I made this when I was like 17 years old lol