chore: enforce use_self rule

Author: tvolk131

harbor-client/src/db_models/cashu_mint.rs

@@ -20,10 +20,10 @@ pub struct CashuMint {
 }
 
 impl CashuMint {
-    pub fn get(conn: &mut SqliteConnection, url: String) -> anyhow::Result<Option<CashuMint>> {
+    pub fn get(conn: &mut SqliteConnection, url: String) -> anyhow::Result<Option<Self>> {
         Ok(cashu_mint::table
             .filter(cashu_mint::mint_url.eq(url))
-            .first::<CashuMint>(conn)
+            .first::<Self>(conn)
             .optional()?)
     }
 
@@ -32,7 +32,7 @@ impl CashuMint {
         let exists = cashu_mint::table
             .filter(cashu_mint::mint_url.eq(&url))
             .filter(cashu_mint::active.eq(1))
-            .first::<CashuMint>(conn)
+            .first::<Self>(conn)
             .optional()?
             .is_some();
 
@@ -79,15 +79,15 @@ impl CashuMint {
         // First check if the federation exists and is active
         let exists = cashu_mint::table
             .filter(cashu_mint::mint_url.eq(&mint_url))
-            .first::<CashuMint>(conn)
+            .first::<Self>(conn)
             .optional()?
             .is_some();
 
         if exists {
             Self::set_active(conn, &mint_url)?;
         }
 
-        let mint = CashuMint {
+        let mint = Self {
             mint_url,
             active: 1,
         };

harbor-client/src/db_models/fedimint.rs

@@ -17,15 +17,15 @@ impl Fedimint {
     pub fn get_value(conn: &mut SqliteConnection, id: String) -> anyhow::Result<Option<Vec<u8>>> {
         Ok(fedimint::table
             .filter(fedimint::id.eq(id))
-            .first::<Fedimint>(conn)
+            .first::<Self>(conn)
             .optional()?
             .map(|v| v.value))
     }
 
-    pub fn get(conn: &mut SqliteConnection, id: String) -> anyhow::Result<Option<Fedimint>> {
+    pub fn get(conn: &mut SqliteConnection, id: String) -> anyhow::Result<Option<Self>> {
         Ok(fedimint::table
             .filter(fedimint::id.eq(id))
-            .first::<Fedimint>(conn)
+            .first::<Self>(conn)
             .optional()?)
     }
 
@@ -34,7 +34,7 @@ impl Fedimint {
         let exists = fedimint::table
             .filter(fedimint::id.eq(&id))
             .filter(fedimint::active.eq(1))
-            .first::<Fedimint>(conn)
+            .first::<Self>(conn)
             .optional()?
             .is_some();
 
@@ -101,7 +101,7 @@ pub struct NewFedimint {
 
 impl From<&NewFedimint> for Fedimint {
     fn from(new_fedimint: &NewFedimint) -> Self {
-        Fedimint {
+        Self {
             id: new_fedimint.id.clone(),
             invite_code: new_fedimint.invite_code.clone(),
             value: new_fedimint.value.clone(),

harbor-client/src/db_models/mint_metadata.rs

@@ -21,7 +21,7 @@ pub struct MintMetadata {
 
 impl MintMetadata {
     pub fn from(id: FederationId, meta: FederationMeta) -> Self {
-        MintMetadata {
+        Self {
             id: id.to_string(),
             federation_expiry_timestamp: meta
                 .federation_expiry_timestamp()
@@ -38,10 +38,10 @@ impl MintMetadata {
         }
     }
 
-    pub fn get(conn: &mut SqliteConnection, id: String) -> anyhow::Result<Option<MintMetadata>> {
+    pub fn get(conn: &mut SqliteConnection, id: String) -> anyhow::Result<Option<Self>> {
         Ok(mint_metadata::table
             .filter(mint_metadata::id.eq(id))
-            .first::<MintMetadata>(conn)
+            .first::<Self>(conn)
             .optional()?)
     }
 
@@ -73,8 +73,8 @@ impl MintMetadata {
 }
 
 impl From<MintMetadata> for FederationMeta {
-    fn from(value: MintMetadata) -> FederationMeta {
-        FederationMeta {
+    fn from(value: MintMetadata) -> Self {
+        Self {
             federation_name: value.name,
             federation_expiry_timestamp: value.federation_expiry_timestamp.map(|f| f.to_string()),
             welcome_message: value.welcome_message,

harbor-client/src/db_models/mod.rs

@@ -87,10 +87,10 @@ pub enum PaymentStatus {
 impl PaymentStatus {
     pub fn from_i32(status: i32) -> Self {
         match status {
-            0 => PaymentStatus::Pending,
-            1 => PaymentStatus::WaitingConfirmation,
-            2 => PaymentStatus::Success,
-            3 => PaymentStatus::Failed,
+            0 => Self::Pending,
+            1 => Self::WaitingConfirmation,
+            2 => Self::Success,
+            3 => Self::Failed,
             _ => panic!("invalid status"),
         }
     }

harbor-client/src/db_models/profile.rs

@@ -16,8 +16,8 @@ pub struct Profile {
 }
 
 impl Profile {
-    pub fn get_first(conn: &mut SqliteConnection) -> anyhow::Result<Option<Profile>> {
-        Ok(profile::table.first::<Profile>(conn).optional()?)
+    pub fn get_first(conn: &mut SqliteConnection) -> anyhow::Result<Option<Self>> {
+        Ok(profile::table.first::<Self>(conn).optional()?)
     }
 
     pub fn set_onchain_receive_enabled(
@@ -66,7 +66,7 @@ pub struct NewProfile {
 
 impl From<&NewProfile> for Profile {
     fn from(new_profile: &NewProfile) -> Self {
-        Profile {
+        Self {
             id: new_profile.id.clone(),
             seed_words: new_profile.seed_words.clone(),
             onchain_receive_enabled: 0,

harbor-client/src/fedimint_client.rs

@@ -56,15 +56,15 @@ pub enum FederationInviteOrId {
 impl FederationInviteOrId {
     pub fn federation_id(&self) -> FederationId {
         match self {
-            FederationInviteOrId::Invite(i) => i.federation_id(),
-            FederationInviteOrId::Id(i) => *i,
+            Self::Invite(i) => i.federation_id(),
+            Self::Id(i) => *i,
         }
     }
 
     pub fn invite_code(&self) -> Option<InviteCode> {
         match self {
-            FederationInviteOrId::Invite(i) => Some(i.clone()),
-            FederationInviteOrId::Id(_) => None,
+            Self::Invite(i) => Some(i.clone()),
+            Self::Id(_) => None,
         }
     }
 }
@@ -277,7 +277,7 @@ impl FedimintClient {
 
         debug!("Built fedimint client");
 
-        Ok(FedimintClient {
+        Ok(Self {
             fedimint_client,
             stop,
         })

harbor-client/src/lib.rs

@@ -16,8 +16,7 @@
     clippy::significant_drop_tightening,
     clippy::similar_names,
     clippy::single_char_pattern,
-    clippy::too_many_lines,
-    clippy::use_self
+    clippy::too_many_lines
 )]
 
 use crate::cashu_client::{
@@ -112,15 +111,15 @@ pub enum MintIdentifier {
 impl MintIdentifier {
     pub fn federation_id(&self) -> Option<FederationId> {
         match self {
-            MintIdentifier::Fedimint(id) => Some(*id),
-            MintIdentifier::Cashu(_) => None,
+            Self::Fedimint(id) => Some(*id),
+            Self::Cashu(_) => None,
         }
     }
 
     pub fn mint_url(&self) -> Option<MintUrl> {
         match self {
-            MintIdentifier::Cashu(url) => Some(url.clone()),
-            MintIdentifier::Fedimint(_) => None,
+            Self::Cashu(url) => Some(url.clone()),
+            Self::Fedimint(_) => None,
         }
     }
 }

harbor-client/src/metadata.rs

@@ -83,7 +83,7 @@ impl FederationMeta {
 
 impl From<Option<MintInfo>> for FederationMeta {
     fn from(info: Option<MintInfo>) -> Self {
-        FederationMeta {
+        Self {
             federation_name: info.as_ref().and_then(|i| i.name.clone()),
             federation_expiry_timestamp: None,
             welcome_message: None,

harbor-ui/src/components/indicator.rs

@@ -347,10 +347,8 @@ where
     Theme: container::Catalog + 'a,
     Renderer: iced::advanced::text::Renderer + 'a,
 {
-    fn from(
-        indicator: Indicator<'a, Message, Theme, Renderer>,
-    ) -> Element<'a, Message, Theme, Renderer> {
-        Element::new(indicator)
+    fn from(indicator: Indicator<'a, Message, Theme, Renderer>) -> Self {
+        Self::new(indicator)
     }
 }
 

harbor-ui/src/components/toast.rs

@@ -35,9 +35,9 @@ impl ToastStatus {
 impl fmt::Display for ToastStatus {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match self {
-            ToastStatus::Neutral => "Neutral",
-            ToastStatus::Good => "Good",
-            ToastStatus::Bad => "Bad",
+            Self::Neutral => "Neutral",
+            Self::Good => "Good",
+            Self::Bad => "Bad",
         }
         .fmt(f)
     }